From owner-svn-src-all@freebsd.org Mon Sep 11 10:00:14 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2F3D1E01997 for ; Mon, 11 Sep 2017 10:00:14 +0000 (UTC) (envelope-from mw@semihalf.com) Received: from mail-it0-x230.google.com (mail-it0-x230.google.com [IPv6:2607:f8b0:4001:c0b::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id EFCC37E7C9 for ; Mon, 11 Sep 2017 10:00:13 +0000 (UTC) (envelope-from mw@semihalf.com) Received: by mail-it0-x230.google.com with SMTP id v19so13198619ite.0 for ; Mon, 11 Sep 2017 03:00:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=ByMVD8iT/6lwBdG2kJ4snoT87dtf0l+HFPpr/g8rqdw=; b=Z/jkkljUCigk4h0g+sr2s+T2BhdwHGdD4pAqmZJGiOC4hS7l9DeOBfNDQU9L3hl6CH RORgbuvv5M+1+j4GuwWH6FV7PZzWkhowxRk1ILHASH0njUgePhJ/KYprXUvtW1FkuDT6 HU/1GnYO0UnuErivEXkLOdeM3oIyLGx1uT2v/MEjJ2qv5in/AZRP3jGFX85Dx5DA8IA+ M6atLwNMLuupsffOj9iEwhFndPpXz8Kyg82TL9vnJGTUWBP2CpAEgTzaqFSNdHXRguT9 4voPW5JEmx/ZciD+KYnGz1bpegaQ8jDQ4VcSiiQRcF0HlJJOhHFJUOW/OTAQuidgea2B ZLOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=ByMVD8iT/6lwBdG2kJ4snoT87dtf0l+HFPpr/g8rqdw=; b=h+PckarMcZ6nT0Q+d2oeK1E9rh/ejtk0cC1fAuFgRZ00gQEq+0e4aeHQ7TAb2IOhzh biIYzLVQeKenDYY6qNn6PMgigbUAl98EVL/DPCGJCfiW0PUsm1ARRgL/J8nwsQ7MKR9V HeR8WoETXDcUqOzBAsDJEdUOQsmKAwiugjdIGX0/zSLlUw67EdMr79nnHN1egO9Dl+z1 yGRkOFR2CzucMBHTzEm/Sjw+o0YX1MS1t9F6GtKDmYald2P1VrFD5T1qIjPIqzJycnPr MK10cKwvP9wU+INMrqgG0ZA9zdtFxJnlIum0y2778agvUpcmx7N2dy2Wq+KqjkWaMcYK cjNw== X-Gm-Message-State: AHPjjUhO3iBDdMSK2nhYipjibDd6P2lnMB5mC8xgiiqDqYDS1I3WhJJX 6TyhIoXKhXp3uoBZnhZomjdFVKNmmJeaFNe5l+gm7w== X-Google-Smtp-Source: ADKCNb5NL3I0P7M/IdX5k+Juw8VCEfJwGtd/VWxpWas8omMzDoGdXGqgpLV6S47vdMg+63bC+lWWhW5Mb2S7jHS7y68= X-Received: by 10.36.165.69 with SMTP id w5mr12971427iti.40.1505124013174; Mon, 11 Sep 2017 03:00:13 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.190.199 with HTTP; Mon, 11 Sep 2017 03:00:12 -0700 (PDT) In-Reply-To: <30B40281-5114-4C72-A9F2-408342BA8216@fubar.geek.nz> References: <201709091154.v89Bs4b9094975@repo.freebsd.org> <30B40281-5114-4C72-A9F2-408342BA8216@fubar.geek.nz> From: Marcin Wojtas Date: Mon, 11 Sep 2017 12:00:12 +0200 Message-ID: Subject: Re: svn commit: r323362 - in head/sys: conf dev/neta To: Andrew Turner Cc: Marcin Wojtas , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Sep 2017 10:00:14 -0000 2017-09-11 11:38 GMT+02:00 Andrew Turner : > >> On 9 Sep 2017, at 12:54, Marcin Wojtas wrote: >> >> Author: mw >> Date: Sat Sep 9 11:54:04 2017 >> New Revision: 323362 >> URL: https://svnweb.freebsd.org/changeset/base/323362 >> >> Log: >> Add support for Armada 3700 in the NETA driver >> >> This patch enables using NETA driver on Marvell Armada 3700 SoC >> by introducing new compatible string, modifying clock source >> obtaining and also excluding unnecessary parts. >> The driver is added as a build option for arm64 platforms as well. > > I=E2=80=99m getting the following when trying to build with gcc (I have i= nitial patches to build arm64 with gcc form ports). > > Andrew > > --- if_mvneta.o --- > /jenkins/workspace/FreeBSD-arm64-head-gcc/freebsd-head/sys/dev/neta/if_mv= neta.c:101:1: error: function declaration isn't a prototype [-Werror=3Dstri= ct-prototypes] > mvneta_get_clk() > ^~~~~~~~~~~~~~ > /jenkins/workspace/FreeBSD-arm64-head-gcc/freebsd-head/sys/dev/neta/if_mv= neta.c: In function 'mvneta_detach': > /jenkins/workspace/FreeBSD-arm64-head-gcc/freebsd-head/sys/dev/neta/if_mv= neta.c:834:16: warning: variable 'ifp' set but not used [-Wunused-but-set-v= ariable] > struct ifnet *ifp; > ^~~ > Can you apply below and confirm it helps? https://pastebin.com/8kfdnMz3 If yes, I'll issue a commit with fix. Marcin