From owner-dev-commits-ports-all@freebsd.org Fri Oct 1 07:24:34 2021 Return-Path: Delivered-To: dev-commits-ports-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id CFF2767F29A; Fri, 1 Oct 2021 07:24:34 +0000 (UTC) (envelope-from jbeich@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4HLM7Q5Qpsz3FRh; Fri, 1 Oct 2021 07:24:34 +0000 (UTC) (envelope-from jbeich@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1633073074; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ljOYxnoteBts4uU5CdNZxj1tLei7J8rBaaM+eabPlWA=; b=FByio0j+gZRyioxG3iGi5iownrwuWPE79aM71TDomTG6iJ3jadJG+PgnqZqFPLRxuRsUU2 neCSbWdq8+qni3tCoXo2WBcgWM9s+e4i/n4inHsh7wsxqQ1zGZ2hrpmOhMEnPv8PomZor/ uqKCYBh0QZy/8YjIHoQqmE/rezHESNLKwfYZE1yhdSgu/I4qh1ZAzTmBmmnmIkHYx6hAEW wnA+6MeAk4yUHp2xP+yapsEUbxnIX9/lhErRZ+ZyUBPrJiRozaYnOm+VqMP9iEL4eMWoiy q11170YUhrDpHC+jS9ZPZfJHvrmRR9sbIew4EVn+pc7GqUjY+MMEc/ppIKXijA== Received: by freefall.freebsd.org (Postfix, from userid 1354) id AC4B81C649; Fri, 1 Oct 2021 07:24:34 +0000 (UTC) From: Jan Beich To: Piotr Kubaj Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: fc75da3a3b2a - main - graphics/libjxl: fix build on powerpc64* References: <202109301550.18UFoo8j096475__2724.79643333412$1633017067$gmane$org@gitrepo.freebsd.org> Date: Fri, 01 Oct 2021 09:24:31 +0200 In-Reply-To: (Piotr Kubaj's message of "Thu, 30 Sep 2021 23:23:44 +0200") Message-ID: MIME-Version: 1.0 Content-Type: text/plain ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1633073074; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ljOYxnoteBts4uU5CdNZxj1tLei7J8rBaaM+eabPlWA=; b=cbZsJ5GMvV3T2d2i/roSybN0BZXPWlzxpCW0tEWUUmE7quBS0UMXDAbIr1HZRvYbfAAayD EQOyxp+V+FRMIrOGtuo9oRhJ2cJsPMX7NFdMAHvP9fKUx+hlncM22WzGQpG1Uz+83QFize 8HAFPLc8/dx4ruZg94KSLMZ4Z2YxeGMEnCmbpsGUC42nLYJCayy4zsWGH4NiYdjxhxe2sH 2j6xpUMTKUW+NnEnjVoCTcQHdhyWbY7Hp8DhGoOAzqwsVdY+nNfGlu2i6i0KkDfouYs0Y+ mxUE+zOkE5bxDnNd8WHS8FjmT2ojd85S7QQPKhndl0drownLSGNOTsle0VXcWg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1633073074; a=rsa-sha256; cv=none; b=bKOgChZTeeXybdRsYv+D+uNFUdIyfVBX4CvxIMwSbN1jaiXe3ngvvWvg5EKlmEzshK0gOb 7I6KkPE5ONydevnaGbO3cajYJa4DEIOpk2vV95sXUc3ZcvPQVH1pcKwWNbEaI/Y+VtrKcF r9CNhzZf8YYF4Gx2jfgr+E7NQ2ArtrE+lPwsEDCr9VOGIjDTIyAvdelAeO0772mI2dkZWJ zSULZcblyD44hGkQyZ/HT6vWI+VsHpRPeoVFFwcjIL1DeHYfRhensRs7Z8idy8Dmq5Vh95 7JItYmRld37XR1wCoNnc1ZEAFQguPCVpo5ci1LQpgCE/TD/RT7TGyj07W3XnUw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-BeenThere: dev-commits-ports-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the ports repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Oct 2021 07:24:34 -0000 Piotr Kubaj writes: > On 21-09-30 21:50:21, Jan Beich wrote: >> Piotr Kubaj writes: >> >> > The include in cpu.cc is not actually necessary, so I did not include anything for FreeBSD. >> [...] >> > +--- tools/cpu/cpu.cc.orig 2021-09-30 15:38:45 UTC >> > ++++ tools/cpu/cpu.cc >> > +@@ -19,7 +19,9 @@ >> > + #endif >> > + >> > + #if JXL_ARCH_PPC >> > +-#include // __ppc_get_timebase_freq >> > ++#if linux >> > ++#include // NOLINT __ppc_get_timebase_freq >> > ++#endif >> > + #endif >> >> Can you file a bug via https://github.com/libjxl/libjxl/issues/new ? >> That include is probably unused even on Linux after 5175d11717f3 >> removed __ppc_get_timebase_freq. >> >> Note, if you can't sign Google CLA don't submit a fix. Otherwise, upstream >> will refuse to read the rationale (PR description), let alone the patch e.g., >> https://github.com/libjxl/libjxl/pull/193 > > No, I don't have a Google account. It's not necessary for filing a bug. Doing so on your behalf is complicated by not having powerpc64 hardware to verify fixes proposed upstream and not having an error log/excerpt for upstream to better understand what needs to be changed. Outside of CLA upstream is very helpful. FreeBSD is officially supported (see JXL_OS_FREEBSD) and fixed timely e.g., https://gitlab.com/wg1/jpeg-xl/-/issues/65 https://gitlab.com/wg1/jpeg-xl/-/issues/66