From owner-freebsd-current@FreeBSD.ORG  Sun Apr 10 12:28:48 2005
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id DE95E16A4CE
	for <current@freebsd.org>; Sun, 10 Apr 2005 12:28:48 +0000 (GMT)
Received: from email.aon.at (warsl404pip7.highway.telekom.at [195.3.96.91])
	by mx1.FreeBSD.org (Postfix) with ESMTP id BD4CD43D48
	for <current@freebsd.org>; Sun, 10 Apr 2005 12:28:47 +0000 (GMT)
	(envelope-from shoesoft@gmx.net)
Received: (qmail 7869 invoked from network); 10 Apr 2005 12:28:11 -0000
Received: from m106p003.dipool.highway.telekom.at ([62.46.3.35])
          (envelope-sender <shoesoft@gmx.net>)
          by smarthub76.highway.telekom.at (qmail-ldap-1.03) with SMTP
          for <bsd@w.evip.pl>; 10 Apr 2005 12:28:11 -0000
From: Stefan Ehmann <shoesoft@gmx.net>
To: Wiktor Niesiobedzki <bsd@w.evip.pl>
In-Reply-To: <20050410111202.GA5980@dln55.neoplus.adsl.tpnet.pl>
References: <20050410111202.GA5980@dln55.neoplus.adsl.tpnet.pl>
Content-Type: text/plain
Date: Sun, 10 Apr 2005 14:28:43 +0200
Message-Id: <1113136123.1530.3.camel@taxman.pepperland>
Mime-Version: 1.0
X-Mailer: Evolution 2.2.1.1 FreeBSD GNOME Team Port 
Content-Transfer-Encoding: 7bit
cc: current@freebsd.org
cc: sos@freebsd.org
Subject: Re: ATA MkIII - Hang after resume solution
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 10 Apr 2005 12:28:49 -0000

On Sun, 2005-04-10 at 13:12 +0200, Wiktor Niesiobedzki wrote:
> Hi,
> 
> I think I found solution to the problem, that after MkIII disks does not
> reinit. Solution is simple:
> 
> --- /usr/src/sys/dev/ata/ata-pci.c      Fri Apr  8 11:37:47 2005
> +++ /tmp/ata-pci.c      Sun Apr 10 13:09:48 2005
> @@ -599,8 +599,8 @@
>      DEVMETHOD(device_attach,    ata_pcichannel_attach),
>      DEVMETHOD(device_detach,    ata_pcichannel_detach),
>      DEVMETHOD(device_shutdown,  bus_generic_shutdown),
> -    DEVMETHOD(device_suspend,   bus_generic_suspend),
> -    DEVMETHOD(device_resume,    bus_generic_resume),
> +    DEVMETHOD(device_suspend,   ata_suspend),
> +    DEVMETHOD(device_resume,    ata_resume),
>  
>      /* ATA methods */
>      DEVMETHOD(ata_setmode,      ata_pcichannel_setmode),
> 
> This is rollback of changes introduced by MkIII. After that change
> suspend/resume works again.
> 
> Can anybody review this?

This causes a kernel panic in ata_reinit for me. (no detailed info
available since the computer freezes hard at that point)