From nobody Tue Oct 14 14:16:17 2025 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cmGV966QZz6CWMk; Tue, 14 Oct 2025 14:16:17 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cmGV948Mlz3XJS; Tue, 14 Oct 2025 14:16:17 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1760451377; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=LzBN+bB7wuIvKpx0Lh608KUykJ1SrMu5dCTowGe4uuM=; b=owVpP5J6kknGHBgZL6aIyGflprkYGkf/I86q9ejZMAtyvS7L/Tj5QenODDJHlH5ukwuAh0 ot8DCY20K9V4LBMde+53ZzyG+RkQZpY35ot7a3DQon9cQb1YiuqdCmk+TfSogurygq6DAB Xfq32zRCf0AWtAstD6wxWgT5hVhoYIWFyrULniQagaVM/0kjEtyZvIjsOJ6y+wak4mOtQt dWMvZbfWpnaRcNBqhmkYY4s/2rPEVfKAokZk6UoCX23NJdOziSBlJMZyao9zm6bI6lyp54 7thqqzpSUf/+nWSCOTcjOKDPcCHp45a4pny8ddog2WDqIbg/mAx3hPRCycnoEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1760451377; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=LzBN+bB7wuIvKpx0Lh608KUykJ1SrMu5dCTowGe4uuM=; b=T5ddj37b6agtC76kRdV716jEyRz6IVs+umKZ/4s6FXiiygO5we9xHsapFrSa2Mu+7PJDaW BqMoorOHzpaEbGUZ8yRl4ZZh/fAOei5Beg4NpR1xQcKU4vWdVC+LuyxIYma38Z3HyXvQbv eqKS42nahFZd06w8BbiLxvllC1e5QpVp2Joy0/Wij8uFqQtGP1ZxiDmchMK90lp0p8egsa IG7ADc6qAr6BxT742sm028DCaUXV3tVW9T1rH+ryCKfqxK+BXIUzO046d1wlfHw9t5fjuK TVfZUjhZni2Kj1//1jXiBPSjzNGqycfodRV6E7iUdzn0zHeDuClMS5TdIa7U1w== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1760451377; a=rsa-sha256; cv=none; b=tycmvqaJjjS1+S3cPp+s+JR7BHnvhfCZndDdncwAYE3P6mXeLLkP3dAHGGOwo4qXaVylrA i0AAjRMgw00A2B1484C0ouMFQQbEy73nEyM2Kb76RiRhCUyFisy9mb13s+lhhtgADul3t1 vZ/v2fo818sN4qNFk00WHiLwIfgO62Oe5QC60S4ahAr7s1jfd15FopH2SBfzQsjcd7bxpV X+KGb5qBy2RX9bNUnrXkU9FGhNufWVvsPiqHHMrAMXn7dIiitw/DF3+duct/Cb5m0oIDc3 7l/Aa5/hKG/j4RTlRTCFdHaEu1D7wx4VfqW8FqKafJCdtlQVld4NC/Xn9gSZ8Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4cmGV93Yy2zvtK; Tue, 14 Oct 2025 14:16:17 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 59EEGHm4028210; Tue, 14 Oct 2025 14:16:17 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 59EEGHJW028207; Tue, 14 Oct 2025 14:16:17 GMT (envelope-from git) Date: Tue, 14 Oct 2025 14:16:17 GMT Message-Id: <202510141416.59EEGHJW028207@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Ahmad Khalifa Subject: git: 439909c48b0e - stable/14 - libm: remainder: make sure x is zero List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: vexeduxr X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 439909c48b0e8b0e8dda03b9a359b73dcabb546e Auto-Submitted: auto-generated The branch stable/14 has been updated by vexeduxr: URL: https://cgit.FreeBSD.org/src/commit/?id=439909c48b0e8b0e8dda03b9a359b73dcabb546e commit 439909c48b0e8b0e8dda03b9a359b73dcabb546e Author: Ahmad Khalifa AuthorDate: 2025-10-10 09:30:52 +0000 Commit: Ahmad Khalifa CommitDate: 2025-10-14 14:00:19 +0000 libm: remainder: make sure x is zero Make sure the entirety of x is zero before flipping the sign bit. Otherwise the sign would be wrong for small values of x when x is negative and |n*y| > |x| Reported by: alfredo PR: 251091 Reviewed by: kargl MFC after: 3 days Differential Revision: https://reviews.freebsd.org/D53023 (cherry picked from commit 25cca51ed294890d20a3c0290814cd26875db686) --- lib/msun/src/e_remainder.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/msun/src/e_remainder.c b/lib/msun/src/e_remainder.c index 406f12c14c2f..057da0e3d990 100644 --- a/lib/msun/src/e_remainder.c +++ b/lib/msun/src/e_remainder.c @@ -65,8 +65,8 @@ remainder(double x, double p) if(x>=p_half) x -= p; } } - GET_HIGH_WORD(hx,x); - if ((hx&0x7fffffff)==0) hx = 0; + EXTRACT_WORDS(hx, lx, x); + if (((hx&0x7fffffff)|lx) == 0) hx = 0; SET_HIGH_WORD(x,hx^sx); return x; }