From owner-svn-src-head@freebsd.org Tue Jun 27 17:04:59 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B313ED8AFCE; Tue, 27 Jun 2017 17:04:59 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pg0-x244.google.com (mail-pg0-x244.google.com [IPv6:2607:f8b0:400e:c05::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 877D57445A; Tue, 27 Jun 2017 17:04:59 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pg0-x244.google.com with SMTP id u62so5003331pgb.0; Tue, 27 Jun 2017 10:04:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:mime-version:from:in-reply-to:date:cc:message-id:references :to; bh=27BovzpmIwLNDVqbffE/JEQigaVRtwW12ATNZza9s5w=; b=T3la3a5j2Fokw41S7N7qGlSlB5Q5SnE1pHn8xFbKeANZd/Wf2vMxbHZhIm2QqeVljx 8WDSEarMd6jATOVOgWLvMtTOUNCLQQ2Gz012p/A1CNBe8o1oUmCJmiLqa80o7VztERse El2Ljq7Y8HMT/G/XauMerjqBOKNi5Bgl0ON1Q/PtTZAs9INeIRWt6nkpQnYr6jpolEyx GV5WvTf8K7aiIWoc/2qKpZaeHsQthcxhWiJEsvDovJF9V7spTvJc8bV8GqDDzzkvvI+N H+/h4nf9p++SI+kmTkKCnuhuLCaWSVEbEKEDR5cW/UvYHEHp4UpYRrxF4da93zximFq0 B43w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:mime-version:from:in-reply-to:date:cc :message-id:references:to; bh=27BovzpmIwLNDVqbffE/JEQigaVRtwW12ATNZza9s5w=; b=p2V7GPAEl11qkRT7dDHpaPE0h39CUnjEJU/qhQ1h6ZcyB6jcknntgMYZFFQIG6S/iQ toDN1pYuTRh6dxnFLLweb3p9Px5xhscf4p9MKawMznm55PMrekvc18JirCQWQLgUoi3K E9t29jhqRXaH5UDEfb4QS1ZKuq/HCaSUjwI2sbSUXJhOe9LrIaPr/940Rc1SeFI3WHkk MNTQr8NpJzfrN/ViESTgE97hEhvs9GRz/0/I4fk/mJlyQK4PkWzJD+wVooGFX0J/1VBa IuNe2BxafPliNEgvu/Lwj1cxBirjWTY/rcVTWtoRMIlJXuTVA63VqkWo88VBJDBmOuWW NBZQ== X-Gm-Message-State: AKS2vOy2uN8+j+0H9l54gFw7ZnFShd41+H9R+eQ4xz/5MGGAafOHCdSU xWwPtePAH5G2pgmWUac= X-Received: by 10.84.197.129 with SMTP id n1mr6773859pld.179.1498583098810; Tue, 27 Jun 2017 10:04:58 -0700 (PDT) Received: from pinklady.local (c-73-19-52-228.hsd1.wa.comcast.net. [73.19.52.228]) by smtp.gmail.com with ESMTPSA id s62sm4114572pfi.36.2017.06.27.10.04.57 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 27 Jun 2017 10:04:58 -0700 (PDT) Subject: Re: svn commit: r320388 - head/sys/arm64/include Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Content-Type: multipart/signed; boundary="Apple-Mail=_2E7BAFC2-741A-47D3-84A6-F564065BB6BB"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Pgp-Agent: GPGMail From: "Ngie Cooper (yaneurabeya)" In-Reply-To: <201706262232.v5QMWrBs048496@repo.freebsd.org> Date: Tue, 27 Jun 2017 10:04:56 -0700 Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-Id: <61D9C30C-BB98-484E-B817-6FE369A77453@gmail.com> References: <201706262232.v5QMWrBs048496@repo.freebsd.org> To: Andrew Turner X-Mailer: Apple Mail (2.3124) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Jun 2017 17:04:59 -0000 --Apple-Mail=_2E7BAFC2-741A-47D3-84A6-F564065BB6BB Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii > On Jun 26, 2017, at 15:32, Andrew Turner wrote: >=20 > Author: andrew > Date: Mon Jun 26 22:32:52 2017 > New Revision: 320388 > URL: https://svnweb.freebsd.org/changeset/base/320388 >=20 > Log: > In _bswap16 and _bswap32 cast constant values to the appropriate = type. This is > similar to what is done in the x86 code. >=20 > Sponsored by: DARPA, AFRL Hi Andrew, This change broke htons use in libsdp on arm64. =46rom = https://ci.freebsd.org/job/FreeBSD-head-aarch64-build/2932/console : 16:08:38 --- all_subdir_lib/libsdp --- 16:08:38 /usr/src/lib/libsdp/search.c:160:31: error: invalid operands to = binary expression ('int' and 'uint8_t *' (aka 'unsigned char *')) 16:08:38 xpdu.pdu.len =3D htons(req_cs - ss->req); 16:08:38 ~~~~~~~~~~~~~^~~~~~~~~~ It might be a good idea to revert the change, fix the fallout, = then recommit the change. Thanks, -Ngie --Apple-Mail=_2E7BAFC2-741A-47D3-84A6-F564065BB6BB Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJZUpA5AAoJEPWDqSZpMIYVQYEP/RHtfeSBgrpOTzoL9+zAQv9Q 1zXGqr/jsLgVGwdZ6lD1HhqIsFUEhkFwGPiqUxXdQ81Ik+XJ7cqGZqmKF012kfCy U0OS+Vguuhnu0teBuyeYayGotVeN2Lo0zTPIxrUhctQxU59Zcd2YfgNcZsU3iuP0 WYUAjFN+gI7lgXJ6LshTbz762XjVFyZeuReGOwbljXqltWXgKg6I+26mMd1+/GD0 SMfOiOAU/g7D2D45YiNHLwyWaDYLidUtlAPGq/hWmJ0SbblOj6qj+aypQbTEBPnQ l5D/sv1obNjbn1lBkicsXD9WYuMCD9I44F05IwMgj4+2OqaHf/MXISyPTeNp/z/T OEuFLVSLNkTlA3CbI48sSNlT8bAaFwNaq0sLp02THQqCxjStz4WM3r9sFTlbXYup VvZQGMsr0YB/+kojYgXsdJ497lDyOCJlPslEFLMAy5hB2EdOsBmYTOoXic9wMy7a jlIMb5wL535QLXfyiUpjoKzDgV191OtWHs86GmmQlTtUkGmZzokKtYtPCJWDRjC0 UpVt0G997hnJUIDwRyTN5EzJq0LXfWhJD0HCaZ9L9FU1zrmQ+zmKyOgtP5RE6f0v 0Jto7YRiuceIo/EPCzRFrCUbhTpS8DQhvjdJtv7xax9JP/bh298s4swKW9ss0RFZ fXajTEJWYnAe1tUPf4iy =PXLf -----END PGP SIGNATURE----- --Apple-Mail=_2E7BAFC2-741A-47D3-84A6-F564065BB6BB--