From nobody Mon May 29 22:11:26 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4QVV9V65m3z4XFnN; Mon, 29 May 2023 22:11:26 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4QVV9V2KpYz3KPJ; Mon, 29 May 2023 22:11:26 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1685398286; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=JgRzTAQCViLNi4VPUy6rAGLIAZV4ckcGrVPpe+inq1Q=; b=rqZhnY9kdwyW4eo0ZEHY9uff9ZYgNghX4zfAGyvjcrSchgdJ9MIdXjo6mVOx/DTZVlAnIT lKeECggzGHRwbfzYNblec1mw7gd5M+aICXhP6wv+B5A6kh4D/aVx8BI52xYpeDYy+oyTSL 4G4JKGY7oQlfkw5ImXaQ6JKmKWXezzuUWi8qjtOCbgJnv5U0rPGMlD/QdyEx+kbyGHLyT7 Cvl/k/uDL2T/Sw4gmKbOpPk1rHKvt6accObxw4zW+CAKeHqP+bdlCMqbjGwvMdTX42sNbE nQIHxxv2/ZjzxqulFPrEgJmH3avIzTk/ecAykpgL7kGDOvbHaLguQFSZfUEoEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1685398286; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=JgRzTAQCViLNi4VPUy6rAGLIAZV4ckcGrVPpe+inq1Q=; b=a8D25C1ZDZewYhvo8RqJ19xaIKweO2eUrsoeXJipj1lT6gi6fzWyFHhG5ZSg2gCPxU4D5W 4f2VBx+W7jUkB0Gollvp9x1mHmuEduUM2w3imnrbOrDl6St+TssUVnjtPiem4V3QAVT/Qs t62upBVTxqCx0xaRZui1/dY5tIgvS+ApHNnegLbPL15tZoJ5vqF6W36PJBhC0pEzwLATLE vaUtTvpalaqtWwNTn0nmDP6MWqp6D+LbzDMaKAFpPXtr9lb1cs+diKLni7eQLSWSXUEUX/ 0QsAAIRUreahELw1ECSvGsfEWn/JLYQ3n2EPPL2JkUqOHXqFdALlGg7p+vHrZQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1685398286; a=rsa-sha256; cv=none; b=PH0JA6tBe7IIh64AB29Ly3QAvTKRyHNRsGpJf1Z3FbC+aB3+Clc3FMl2vFcoGJGny9J8MM GKg5Tz5Pi7XNJ3wIhOwwxjw2OPU/D/yYJiRO142i1Bx4n4CNEYxnUR9/QbHXCFD8JJnI1O +1sts73/o1jhdeZa/SNgzibBfoBIEa1Ka8QqTvQAq58mBZbKOwIhnu41dbLed7Uvbd3axD 9QZwv7xchGJUjfdEQKZg70y/eEuWaEmHSPmbI/XXL8btACaaKz6oi1EX3LHwLL4TNHLRVt E2iDKpozNk3xMcTzMgnhICsh57GXNAL+mKy0IyDVsJHzrApeTpO2fqROfwegBA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4QVV9V1Rw5zSrw; Mon, 29 May 2023 22:11:26 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 34TMBQ4E044819; Mon, 29 May 2023 22:11:26 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 34TMBQ9d044818; Mon, 29 May 2023 22:11:26 GMT (envelope-from git) Date: Mon, 29 May 2023 22:11:26 GMT Message-Id: <202305292211.34TMBQ9d044818@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Konstantin Belousov Subject: git: 12db3c914fe0 - main - unr(9) iterator: add naive test List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kib X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 12db3c914fe0a985de1e393ee964c9cda5b3e0ca Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by kib: URL: https://cgit.FreeBSD.org/src/commit/?id=12db3c914fe0a985de1e393ee964c9cda5b3e0ca commit 12db3c914fe0a985de1e393ee964c9cda5b3e0ca Author: Konstantin Belousov AuthorDate: 2023-05-13 01:32:25 +0000 Commit: Konstantin Belousov CommitDate: 2023-05-29 22:10:36 +0000 unr(9) iterator: add naive test To use, compile userspace code e.g. into the subr_unit binary, then do $ while ./subr_unit -iv >|/tmp/subr_unit.log ; do :; done The loop should be left run for as long as possible. Reviewed by: markj Sponsored by: The FreeBSD Foundation MFC after: 1 week Differential revision: https://reviews.freebsd.org/D40089 --- sys/kern/subr_unit.c | 91 ++++++++++++++++++++++++++++++++++++++++++++++++++-- 1 file changed, 89 insertions(+), 2 deletions(-) diff --git a/sys/kern/subr_unit.c b/sys/kern/subr_unit.c index 61b7f86cda85..e343dd999d17 100644 --- a/sys/kern/subr_unit.c +++ b/sys/kern/subr_unit.c @@ -1176,15 +1176,93 @@ test_alloc_unr_specific(struct unrhdr *uh, u_int i, char a[]) } } +#define TBASE 7 +#define XSIZE 10 +#define ISIZE 1000 + +static int +test_iter_compar(const void *a, const void *b) +{ + return (*(const int *)a - *(const int *)b); +} + +static void +test_iter_fill(int *vals, struct unrhdr *uh, int i, int v, int *res) +{ + int x; + + vals[i] = v; + x = alloc_unr_specific(uh, v); + if (x != v) { + VPRINTF("alloc_unr_specific failed %d %d\n", x, v); + *res = 1; + } +} + static void test_iter(void) { + struct unrhdr *uh; + void *ihandle; + int vals[ISIZE]; + int i, j, v, x, res; + + res = 0; + uh = new_unrhdr(TBASE, INT_MAX, NULL); + for (i = 0; i < XSIZE; i++) { + vals[i] = i + TBASE; + x = alloc_unr_specific(uh, i + TBASE); + if (x != i + TBASE) { + VPRINTF("alloc_unr_specific failed %d %d\n", x, + i + TBASE); + res = 1; + } + } + for (; i < ISIZE; i++) { + for (;;) { +again: + v = arc4random_uniform(INT_MAX); + if (v < TBASE) + goto again; + for (j = 0; j < i; j++) { + if (v == vals[j] || v + 1 == vals[j]) + goto again; + } + break; + } + test_iter_fill(vals, uh, i, v, &res); + i++, v++; + if (i < ISIZE) + test_iter_fill(vals, uh, i, v, &res); + } + qsort(vals, ISIZE, sizeof(vals[0]), test_iter_compar); + + ihandle = create_iter_unr(uh); + i = 0; + while ((v = next_iter_unr(ihandle)) != -1) { + if (vals[i] != v) { + VPRINTF("iter %d: iter %d != val %d\n", i, v, vals[i]); + if (res == 0) { + if (verbose) + print_unrhdr(uh); + res = 1; + } + } else { + VPRINTF("iter %d: val %d\n", i, v); + } + i++; + } + free_iter_unr(ihandle); + clean_unrhdr(uh); + clear_unrhdr(uh); + delete_unrhdr(uh); + exit(res); } static void usage(char **argv) { - printf("%s [-h] [-r REPETITIONS] [-v]\n", argv[0]); + printf("%s [-h] [-i] [-r REPETITIONS] [-v]\n", argv[0]); } int @@ -1196,11 +1274,16 @@ main(int argc, char **argv) long reps = 1, m; int ch; u_int i; + bool testing_iter; verbose = false; + testing_iter = false; - while ((ch = getopt(argc, argv, "hr:v")) != -1) { + while ((ch = getopt(argc, argv, "hir:v")) != -1) { switch (ch) { + case 'i': + testing_iter = true; + break; case 'r': errno = 0; reps = strtol(optarg, NULL, 0); @@ -1221,6 +1304,10 @@ main(int argc, char **argv) } setbuf(stdout, NULL); + + if (testing_iter) + test_iter(); + uh = new_unrhdr(0, count - 1, NULL); print_unrhdr(uh);