From owner-freebsd-current Mon Feb 25 23: 9:42 2002 Delivered-To: freebsd-current@freebsd.org Received: from mail5.speakeasy.net (mail5.speakeasy.net [216.254.0.205]) by hub.freebsd.org (Postfix) with ESMTP id 55C4837B405 for ; Mon, 25 Feb 2002 23:09:29 -0800 (PST) Received: (qmail 9353 invoked from network); 26 Feb 2002 07:09:27 -0000 Received: from unknown (HELO laptop.baldwin.cx) ([65.90.117.19]) (envelope-sender ) by mail5.speakeasy.net (qmail-ldap-1.03) with SMTP for ; 26 Feb 2002 07:09:27 -0000 Message-ID: X-Mailer: XFMail 1.4.0 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: Date: Tue, 26 Feb 2002 02:09:27 -0500 (EST) From: John Baldwin To: Julian Elischer Subject: Re: First (easy) td_ucred patch Cc: current@FreeBSD.ORG, dillon@FreeBSD.ORG, Jake Burkholder Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On 24-Feb-02 Julian Elischer wrote: > I'm just saying that if this is the "simple p->p_ucred => td->td_ucred > > change that do only that and do the rewrite in a separate commit.. > I'm not against doing hte commit as is however.. it's only 3 small > nits.. > the one that may be real is the other one I mention (I think in another > email) where the capability of coping with a NULL td is lost. I can do separate commits, that's not a problem. > On Sun, 24 Feb 2002, Jake Burkholder wrote: > >> Apparently, On Sat, Feb 23, 2002 at 11:21:24AM -0800, >> Julian Elischer said words to the effect of; >> >> > >> > >> > On Fri, 22 Feb 2002, John Baldwin wrote: >> > >> > > >> > > http://www.FreeBSD.org/~jhb/patches/ucred.patch >> > >> > >> > the structural rewriting in kern_proc.c should be done as a separate >> > commit. (though I agree it should be done) >> > >> > the structural rewriting in kern/sysv_*.c >> > could be done as a separate commit as well. >> > (I agree it is worth doing) >> > >> > I'll let you get away with unp_listen() :-) >> >> I'd like to point out that in all cases that you mention, the original >> structure before the "giant pushdown" is being restored. A lot of >> structural >> rewriting occured in those commits. It was not done separately. I don't >> recall if the patches were posted for review, I certainly never saw them. >> >> This strikes me as a double standard. >> >> Jake >> > -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message