From owner-svn-src-head@FreeBSD.ORG Tue Nov 18 06:46:32 2014 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 33A4BD59; Tue, 18 Nov 2014 06:46:32 +0000 (UTC) Received: from dchagin.static.corbina.net (dchagin.static.corbina.ru [78.107.232.239]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "dchagin.static.corbina.net", Issuer "dchagin.static.corbina.net" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id B45EB880; Tue, 18 Nov 2014 06:46:30 +0000 (UTC) Received: from dchagin.static.corbina.net (localhost [127.0.0.1]) by dchagin.static.corbina.net (8.14.9/8.14.9) with ESMTP id sAI6kRNR000972 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Tue, 18 Nov 2014 09:46:27 +0300 (MSK) (envelope-from dchagin@dchagin.static.corbina.net) Received: (from dchagin@localhost) by dchagin.static.corbina.net (8.14.9/8.14.9/Submit) id sAI6kR9M000971; Tue, 18 Nov 2014 09:46:27 +0300 (MSK) (envelope-from dchagin) Date: Tue, 18 Nov 2014 09:46:26 +0300 From: Chagin Dmitry To: John Baldwin Subject: Re: svn commit: r274635 - head/sys/dev/pci Message-ID: <20141118064626.GA956@dchagin.static.corbina.net> References: <201411172025.sAHKPLMl055666@svn.freebsd.org> <2245618.H2SPKlpWdS@ralph.baldwin.cx> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="fUYQa+Pmc3FrFX/N" Content-Disposition: inline In-Reply-To: <2245618.H2SPKlpWdS@ralph.baldwin.cx> User-Agent: Mutt/1.5.23 (2014-03-12) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Nov 2014 06:46:32 -0000 --fUYQa+Pmc3FrFX/N Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Nov 17, 2014 at 05:45:23PM -0500, John Baldwin wrote: > On Monday, November 17, 2014 08:25:21 PM Dmitry Chagin wrote: > > Author: dchagin > > Date: Mon Nov 17 20:25:21 2014 > > New Revision: 274635 > > URL: https://svnweb.freebsd.org/changeset/base/274635 > >=20 > > Log: > > Use the correct device as the power_for_sleep() method > > always pass request up to parent bridge. > >=20 > > Reviewed by: jhb > > MFC after: 1 week > > xMFC: r274386,r274397 >=20 > Hmm, I had misread this diff as being another instance of what Adrian had= =20 > found. I think this is actually not correct. The parent of a pci device= =20 > ('dev' here) is a pciX device. pciX devices do not implement the=20 > PCIB_POWER_FOR_SLEEP method from pcib_if.m, so this probably just broke= =20 > Adrian's Asus laptop as now it will always use D3 again and ignore _SxD. ugh.. i understood, let me see more closely >=20 > You said that this change fixed your laptop, yes? Did it work before Adr= ian's=20 > change in r274386 and break afterwards? yes --=20 Have fun! chd --fUYQa+Pmc3FrFX/N Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEARECAAYFAlRq60IACgkQ0t2Tb3OO/O39JgCdHpPTc+4p2g2nm7LyggdTTNUv 8IAAoLP6nu/GLnfOBEFyenAJl293CZkz =xIpI -----END PGP SIGNATURE----- --fUYQa+Pmc3FrFX/N--