From owner-freebsd-current@freebsd.org Sat Sep 14 18:21:24 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id E7A18FB6F2 for ; Sat, 14 Sep 2019 18:21:24 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from outbound3d.ore.mailhop.org (outbound3d.ore.mailhop.org [54.186.57.195]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 46W16X4Ljkz4H5p for ; Sat, 14 Sep 2019 18:21:24 +0000 (UTC) (envelope-from ian@freebsd.org) ARC-Seal: i=1; a=rsa-sha256; t=1568485283; cv=none; d=outbound.mailhop.org; s=arc-outbound20181012; b=klFW3yvkPpzOyHUmvbCfgUzkP8BW6GdjNZLdF+Cnmlw6aSj0ZMBID9EjKLmIgPBzbyzaYYTCBUDSS tbdISjf0O3PkpmF++jEUxJpNKcbGeyIVa7t03ZS+j9MzSuWznU1zrKr1eY1N+cFkJBWMb5ZIjY9YxN wZ944662r4FF+tGUHQmLOZ6VikI+4TJUsUJfN4tvm2k7q4uuypEQScMiGWKgg8zQjcUr8D9wCiUTV/ 9JEpNnTmlkfmNxBuHZgJyJ9pP60xcFU6aa3LsjoL8U/EH0lhMicOfR5uQAEBpOZYNh+erqUbiFwQWv 16sUqAI7VczLf5nOR1RrroR6NEVqBig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=arc-outbound20181012; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:to:from:subject:message-id:dkim-signature:from; bh=WrGudQQQp/k6tQy/rIiXJ/OP84sFSGnd9aCvHMicsV0=; b=IV26p3+t6NoU1EGtppKkQhASR9yigUwqrQckijUDHCOR4rThfml62Tp9EtAXrrKG+eEJ4jcOsMvmr fnSF+i6RrspVSw/juAqVrosb/B445YIf1TAz3yrysQrWCMTmCRRc85+W6ybKrhGPWUhxttC6LuIpzV smPawJP8jQyKK+2VBzAuRis+ce5JNSnOlnAJGbd9XpnQ0DZFO+OXzkBgwLL/pu2EwcQiwHlVVsDCxK b91xovBajrC5LgbLtPB338pJ119BYYIbjnPvhhkUjfCc8lSdYTk0Ueb0jCWhMdqrpDbVjimu4BjjVF ZVqdRkI9Pe478pB+saV8VGSpatYZN5g== ARC-Authentication-Results: i=1; outbound3.ore.mailhop.org; spf=softfail smtp.mailfrom=freebsd.org smtp.remote-ip=67.177.211.60; dmarc=none header.from=freebsd.org; arc=none header.oldest-pass=0; DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=dkim-high; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:to:from:subject:message-id:from; bh=WrGudQQQp/k6tQy/rIiXJ/OP84sFSGnd9aCvHMicsV0=; b=UAenpQBp5VLn9MiUk04UsW9iUc3A1O+/f6Sbx88h7l9nob9BTFg+uA+ZiqEfimCRkg9rrEi6ang9I qmqG09c1eRnWhQRCx7cvKXg8n0julWCm1+T1Sd5BVrkR4w6xcrW81tSWZfS6IF4if1gT5wccUU09Cq T2SKD68xeNJEiQR3SrKh61mEWrQIYmNdct6/XJHOypcQKrOMCxmtrxEM+7Y3DetAjEhUFbX789LTqm BlMa1af8Bj7EqzMNYbmquuCXLvrplplcolA/LZV/yZladOc0AAawarV5S8T1i2Ja6ZZR0by79XxceE mcTDQPQVH6QbNBg8TywD9EmTwrWo4Pg== X-MHO-RoutePath: aGlwcGll X-MHO-User: 734be60b-d71c-11e9-b67d-cdd75d6ce7a8 X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 67.177.211.60 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (unknown [67.177.211.60]) by outbound3.ore.mailhop.org (Halon) with ESMTPSA id 734be60b-d71c-11e9-b67d-cdd75d6ce7a8; Sat, 14 Sep 2019 18:21:21 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.15.2) with ESMTP id x8EILK7m087044; Sat, 14 Sep 2019 12:21:20 -0600 (MDT) (envelope-from ian@freebsd.org) Message-ID: Subject: Re: head -r352274 buildkernel targetting armv7 failure: am335x/am335x_dmtpps.c:304:3: error: implicit declaration of function 'spinlock_enter' is invalid in C99 [-Werror,-Wimplicit-function-declaration] From: Ian Lepore To: Mark Millard , FreeBSD Current , freebsd-arm@freebsd.org Date: Sat, 14 Sep 2019 12:21:20 -0600 In-Reply-To: <0E884723-2826-4EDF-A16F-841E01E9D4EC@yahoo.com> References: <0E884723-2826-4EDF-A16F-841E01E9D4EC@yahoo.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 FreeBSD GNOME Team Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 46W16X4Ljkz4H5p X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-2.00 / 15.00]; local_wl_from(0.00)[freebsd.org]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; ASN(0.00)[asn:16509, ipnet:54.186.0.0/15, country:US]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 14 Sep 2019 18:21:25 -0000 On Sat, 2019-09-14 at 11:05 -0700, Mark Millard via freebsd-arm wrote: > After updating my amd64 context to head -r352274, > attempting an amd64->armv7 cross buildworld buildkernel > ended up failing with: > > > --- am335x_dmtpps.o --- > /usr/src/sys/arm/ti/am335x/am335x_dmtpps.c:304:3: error: implicit > declaration of function 'spinlock_enter' is invalid in C99 [-Werror,- > Wimplicit-function-declaration] > mtx_lock_spin(&sc->pps_mtx); > ^ > /usr/src/sys/sys/mutex.h:383:26: note: expanded from macro > 'mtx_lock_spin' > #define mtx_lock_spin(m) mtx_lock_spin_flags((m), 0) > ^ > /usr/src/sys/sys/mutex.h:452:2: note: expanded from macro > 'mtx_lock_spin_flags' > mtx_lock_spin_flags_((m), (opts), LOCK_FILE, LOCK_LINE) > ^ > /usr/src/sys/sys/mutex.h:429:2: note: expanded from macro > 'mtx_lock_spin_flags_' > __mtx_lock_spin((m), curthread, (opts), (file), (line)) > ^ > /usr/src/sys/sys/mutex.h:258:2: note: expanded from macro > '__mtx_lock_spin' > spinlock_enter(); > \ > ^ > /usr/src/sys/arm/ti/am335x/am335x_dmtpps.c:304:3: error: this > function declaration is not a prototype [-Werror,-Wstrict-prototypes] > /usr/src/sys/sys/mutex.h:383:26: note: expanded from macro > 'mtx_lock_spin' > #define mtx_lock_spin(m) mtx_lock_spin_flags((m), 0) > ^ > /usr/src/sys/sys/mutex.h:452:2: note: expanded from macro > 'mtx_lock_spin_flags' > mtx_lock_spin_flags_((m), (opts), LOCK_FILE, LOCK_LINE) > ^ > /usr/src/sys/sys/mutex.h:429:2: note: expanded from macro > 'mtx_lock_spin_flags_' > __mtx_lock_spin((m), curthread, (opts), (file), (line)) > ^ > /usr/src/sys/sys/mutex.h:258:2: note: expanded from macro > '__mtx_lock_spin' > spinlock_enter(); > \ > ^ > . . . > > (spinlock_enter was not the only example.) > > My bad, I forgot to include when I switched the code to spinlocks. Should be fixed by r352333. -- Ian