From owner-p4-projects@FreeBSD.ORG Wed Jan 2 20:19:03 2008 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 63CA416A473; Wed, 2 Jan 2008 20:19:03 +0000 (UTC) Delivered-To: perforce@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2794116A469; Wed, 2 Jan 2008 20:19:03 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from speedfactory.net (mail6.speedfactory.net [66.23.216.219]) by mx1.freebsd.org (Postfix) with ESMTP id B00B913C448; Wed, 2 Jan 2008 20:19:02 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (unverified [66.23.211.162]) by speedfactory.net (SurgeMail 3.8q) with ESMTP id 227051832-1834499 for multiple; Wed, 02 Jan 2008 15:16:57 -0500 Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.13.8/8.13.8) with ESMTP id m02KIpIb019397; Wed, 2 Jan 2008 15:18:52 -0500 (EST) (envelope-from jhb@freebsd.org) From: John Baldwin To: "M. Warner Losh" Date: Wed, 2 Jan 2008 14:12:08 -0500 User-Agent: KMail/1.9.6 References: <200712310531.lBV5VvH3092205@repoman.freebsd.org> <20080101.120601.106977236.imp@bsdimp.com> In-Reply-To: <20080101.120601.106977236.imp@bsdimp.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200801021412.09276.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Wed, 02 Jan 2008 15:18:52 -0500 (EST) X-Virus-Scanned: ClamAV 0.91.2/5343/Wed Jan 2 12:41:01 2008 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: jb@freebsd.org, perforce@freebsd.org Subject: Re: PERFORCE change 132153 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Jan 2008 20:19:03 -0000 On Tuesday 01 January 2008 02:06:01 pm M. Warner Losh wrote: > In message: <200712310531.lBV5VvH3092205@repoman.freebsd.org> > John Birrell writes: > : http://perforce.freebsd.org/chv.cgi?CH=132153 > : > : Change 132153 by jb@jb_freebsd1 on 2007/12/31 05:31:02 > : > : amd64 doesn't seem to have a program header in the kernel modules > : like i386 does. I don't know enough about amd64 to know if that's a > : problem or not. I have a feeling I'm not far off learning that. :-P > > I believe that amd64 is the only one that doesn't... Currently. :) amd64 uses the equivalent of a .o for klds whereas other archs use the equivalent of a .so. Hence link_elf.c (shared object for !amd64) and link_elf_object.c (handles plain object files). Other platforms could be switched to using plain objects IIRC, they are just using .so for their default. > Warner > > : Affected files ... > : > : .. //depot/projects/dtrace/src/contrib/opensolaris/lib/libdtrace/common/dt_module.c#14 edit > : > : Differences ... > : > : ==== //depot/projects/dtrace/src/contrib/opensolaris/lib/libdtrace/common/dt_module.c#14 (text) ==== > : > : @@ -927,6 +927,7 @@ > : #if defined(sun) > : dmp->dm_modid = (int)OBJFS_MODID(st.st_ino); > : #else > : +#if defined(__i386__) > : /* > : * Find the first load section and figure out the relocation > : * offset for the symbols. The kernel module will not need > : @@ -939,6 +940,7 @@ > : } > : } > : #endif > : +#endif > -- John Baldwin