From owner-cvs-src@FreeBSD.ORG Fri Jul 11 00:57:19 2008 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id F20121065683; Fri, 11 Jul 2008 00:57:18 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (bigknife-pt.tunnel.tserv9.chi1.ipv6.he.net [IPv6:2001:470:1f10:75::2]) by mx1.freebsd.org (Postfix) with ESMTP id 2C2608FC16; Fri, 11 Jul 2008 00:57:17 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from localhost.corp.yahoo.com (john@localhost [IPv6:::1]) (authenticated bits=0) by server.baldwin.cx (8.14.2/8.14.2) with ESMTP id m6B0v3Nd039564; Thu, 10 Jul 2008 20:57:11 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: obrien@freebsd.org Date: Thu, 10 Jul 2008 19:47:02 -0400 User-Agent: KMail/1.9.7 References: <200807101635.m6AGZv7I090311@svn.freebsd.org> <20080710233721.GA55073@dragon.NUXI.org> In-Reply-To: <20080710233721.GA55073@dragon.NUXI.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200807101947.02351.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [IPv6:::1]); Thu, 10 Jul 2008 20:57:11 -0400 (EDT) X-Virus-Scanned: ClamAV 0.93.1/7687/Thu Jul 10 16:24:56 2008 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-2.6 required=4.2 tests=AWL,BAYES_00,NO_RELAYS autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: cvs-src@freebsd.org, src-committers@freebsd.org, "cvs-all@freebsd.org" , Peter Wemm Subject: Re: svn commit: r180431 - in head/sys: kern sys X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Jul 2008 00:57:19 -0000 On Thursday 10 July 2008 07:37:21 pm David O'Brien wrote: > On Thu, Jul 10, 2008 at 10:35:35AM -0700, Peter Wemm wrote: > > On Thu, Jul 10, 2008 at 9:35 AM, David E. O'Brien wrote: > > > Author: obrien > > > Date: Thu Jul 10 16:35:57 2008 > > > New Revision: 180431 > > > URL: http://svn.freebsd.org/changeset/base/180431 > > > > > > Log: > > > Allow 'elf_file_t' to be used in a wider scope. > > > > > > Modified: > > > head/sys/kern/link_elf.c > > > head/sys/sys/link_elf.h > > > > This really was intentional. elf_file_t was supposed to be opaque and > > changeable. What do you need this for? > > Juniper needs to be able to call functions in the loadable modules before > the modules are actually linked into the kernel. This will be used to > call platform specific initialization functions early in the bootup > process. Will also need un-static link_elf_preload_parse_symbols, > parse_dynamic, symbol_name, link_elf_lookup_symbol, > link_elf_symbol_values. Might a better approach be to fix the loader to do the link instead of the kernel so that modules loaded via the loader are available from the very start of boot. As it is, it seems that this would be a very fragile thing to do (what happens if your platform routines call any other routines that aren't already in the module (like printf) that need to have their symbols resolved?). -- John Baldwin