From owner-freebsd-ports@FreeBSD.ORG Fri Jul 24 15:18:03 2009 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 384DF106566B for ; Fri, 24 Jul 2009 15:18:03 +0000 (UTC) (envelope-from alexanderchuranov@gmail.com) Received: from mail-bw0-f219.google.com (mail-bw0-f219.google.com [209.85.218.219]) by mx1.freebsd.org (Postfix) with ESMTP id 793BB8FC26 for ; Fri, 24 Jul 2009 15:18:02 +0000 (UTC) (envelope-from alexanderchuranov@gmail.com) Received: by bwz19 with SMTP id 19so1462146bwz.43 for ; Fri, 24 Jul 2009 08:18:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:date:message-id:subject :from:to:content-type:content-transfer-encoding; bh=QbI1P+qnn5G40FtO8VyIfWNDVOShQ/hZhBfMBIl1Kq4=; b=TUSXUrJHNZaIpCta5lShGorS6pIb2cjpIOTUGvR/WAhdVEycaL8NLnP1IiUlB//QDH GLEs85CyMBy8n5AzVUdD3nWba6sjwoJZYfeshZu/wuJfQoaKwdGTaTSr3rr9Ace364YB lPCSwHc6vq4LoM7xtDwkRUNNdp8u0In2izhpc= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:date:message-id:subject:from:to:content-type :content-transfer-encoding; b=kg0vr1wEm0qp2ungX6TZVDYoRPYfX6YM4/fDbIHyETCmWKva9j4aRmEYdtYc11BGFr Tl/O+Y01oYL1msqhe+rp4W4K7slYW7+fmJiXWfkkRqB4QFrxV43mxhdB2sC5cyGOIaGv zQomhzgQ7SsEKkXbtpeEf8gdtNxrmtdnJFqaA= MIME-Version: 1.0 Received: by 10.204.120.19 with SMTP id b19mr3367736bkr.36.1248448681380; Fri, 24 Jul 2009 08:18:01 -0700 (PDT) Date: Fri, 24 Jul 2009 19:18:01 +0400 Message-ID: <3cb459ed0907240818k392793abgd5a1f00395d9f4e5@mail.gmail.com> From: Alexander Churanov To: marcus@FreeBSD.org, FreeBSD Ports Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Subject: portlint: incorrect Makefile analysis X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Jul 2009 15:18:03 -0000 Hi Folks! I've encountered an issue with the portlint tool and do not find a better place to file it. Description: For the set of new boost-ports, I'm using included Makefiles to remove duplication. Portlint complains on variables contained in included Makefiles. For example, it prints: FATAL: Makefile: no MAINTAINER listed. While "make -V MAINTAINER" works properly. My ports are not checked in yet, if you need the source it's at http://alexanderchuranov.com/boost-port/boost-ports-200907241320.tar.bz2 If I edit the master Makefile (which includes others) for a port and add a MAINTAINER variable with the value "somebody", then portlint do not fails with the same. However, it examines the content of the variable listed in the master Makefile. It is incorrect, because according to the rules of make, the variable has the last assigned value. The assignment is done in the included Makefile. Output of portlint if master Makefile also contains assignment to the "MAINTAINER" variable: OK: seen MAINTAINER, in order. OK: MAINTAINER section is ordered properly. FATAL: Makefile: MAINTAINER address, somebody, does not appear to be a valid email address. Sincerely, Alexander Churanov