From owner-cvs-src@FreeBSD.ORG Wed Nov 1 20:20:51 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 556C116A50E; Wed, 1 Nov 2006 20:20:51 +0000 (UTC) (envelope-from keramida@freebsd.org) Received: from igloo.linux.gr (igloo.linux.gr [62.1.205.36]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3F66D43DCD; Wed, 1 Nov 2006 20:20:08 +0000 (GMT) (envelope-from keramida@freebsd.org) Received: from kobe.laptop (host5.bedc.ondsl.gr [62.103.39.229]) (authenticated bits=128) by igloo.linux.gr (8.13.8/8.13.8/Debian-2) with ESMTP id kA1KJmuR021647 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Wed, 1 Nov 2006 22:19:53 +0200 Received: from kobe.laptop (kobe.laptop [127.0.0.1]) by kobe.laptop (8.13.8/8.13.8) with ESMTP id kA1KJfUX004533; Wed, 1 Nov 2006 22:19:42 +0200 (EET) (envelope-from keramida@freebsd.org) Received: (from keramida@localhost) by kobe.laptop (8.13.8/8.13.8/Submit) id kA1KJf9u004532; Wed, 1 Nov 2006 22:19:41 +0200 (EET) (envelope-from keramida@freebsd.org) Date: Wed, 1 Nov 2006 22:19:41 +0200 From: Giorgos Keramidas To: Martin Blapp , Tor Egge Message-ID: <20061101201941.GC4417@kobe.laptop> References: <200610132049.k9DKnObw045731@repoman.freebsd.org> <20061015091459.V72308@godot.imp.ch> <20061018234916.GA1711@gothmog.pc> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20061018234916.GA1711@gothmog.pc> X-Hellug-MailScanner: Found to be clean X-Hellug-MailScanner-SpamCheck: not spam, SpamAssassin (score=-2.632, required 5, AWL -0.23, BAYES_00 -2.60, DNS_FROM_RFC_ABUSE 0.20, UNPARSEABLE_RELAY 0.00) X-Hellug-MailScanner-From: keramida@freebsd.org X-Spam-Status: No Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/kern kern_conf.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Nov 2006 20:20:51 -0000 On 2006-10-19 02:49, Giorgos Keramidas wrote: > Maybe it's not related, but all xterm's seem unkillable and blocked > forever in "devdrn" here, in a build from 2006.10.18.15.56.11. > > An earlier sync from 2006.10.13.12.45.54 didn't exhibit this behavior, > so I guess there's something mildly buggy with this change? I still have to use the following local diff to get "killable" xterm processes: % diff -r a61844fa2f23 sys/kern/kern_conf.c % --- a/sys/kern/kern_conf.c Wed Nov 01 21:49:16 2006 +0200 % +++ b/sys/kern/kern_conf.c Wed Nov 01 02:33:08 2006 +0200 % @@ -676,7 +676,6 @@ destroy_devl(struct cdev *dev) % dev->si_flags &= ~SI_CLONELIST; % } % % - dev->si_refcount++; /* Avoid race with dev_rel() */ % csw = dev->si_devsw; % dev->si_devsw = NULL; /* already NULL for SI_ALIAS */ % while (csw != NULL && csw->d_purge != NULL && dev->si_threadcount) { % @@ -686,10 +685,6 @@ destroy_devl(struct cdev *dev) % printf("Still %lu threads in %s\n", % dev->si_threadcount, devtoname(dev)); % } % - while (dev->si_threadcount != 0) { % - /* Use unique dummy wait ident */ % - msleep(&csw, &devmtx, PRIBIO, "devdrn", hz / 10); % - } % % dev->si_drv1 = 0; % dev->si_drv2 = 0; % @@ -704,7 +699,6 @@ destroy_devl(struct cdev *dev) % fini_cdevsw(csw); % } % dev->si_flags &= ~SI_ALIAS; % - dev->si_refcount--; /* Avoid race with dev_rel() */ % % if (dev->si_refcount > 0) { % LIST_INSERT_HEAD(&dead_cdevsw.d_devs, dev, si_list); If it is related, at all, I am using `kern.pts.enable=1' here, and a slightly modified GENERIC kernel config. The differences from GENERIC are mostly removed SCSI devices and added options for the PF firewall, but I can send a diff if needed. Has this been fixed in HEAD, in a way that I missed while looking at the recent changes? - Giorgos