From owner-cvs-all Tue May 8 20:19:50 2001 Delivered-To: cvs-all@freebsd.org Received: from green.bikeshed.org (localhost [127.0.0.1]) by hub.freebsd.org (Postfix) with ESMTP id 597CD37B422; Tue, 8 May 2001 20:19:46 -0700 (PDT) (envelope-from green@green.bikeshed.org) Received: from localhost (green@localhost) by green.bikeshed.org (8.11.2/8.11.1) with ESMTP id f493JiE24936; Tue, 8 May 2001 23:19:45 -0400 (EDT) (envelope-from green@green.bikeshed.org) Message-Id: <200105090319.f493JiE24936@green.bikeshed.org> X-Mailer: exmh version 2.3.1 01/18/2001 with nmh-1.0.4 To: Alfred Perlstein Cc: Brian Feldman , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/crypto/openssh auth-pam.c In-Reply-To: Message from Alfred Perlstein of "Tue, 08 May 2001 20:00:19 PDT." <20010508200018.S18676@fw.wintelcom.net> From: "Brian F. Feldman" Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Tue, 08 May 2001 23:19:44 -0400 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG Alfred Perlstein wrote: > * Brian Feldman [010508 15:30] wrote: > > green 2001/05/08 15:30:18 PDT > > > > Modified files: > > crypto/openssh auth-pam.c > > Log: > > Since PAM is broken, let pam_setcred() failure be non-fatal. > > That could be pretty bad if auth_pam_password fails with pam. > > here's what I think is a better fix. > > I sync'd the code up a bit with the "portable ssh" project. > > please review as soon as you can as i'm nervous about the > missing check for 'was_authenticated' It looks good. No objection here :) -- Brian Fundakowski Feldman \ FreeBSD: The Power to Serve! / green@FreeBSD.org `------------------------------' To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message