From owner-freebsd-hackers Thu Oct 7 11:20:17 1999 Delivered-To: freebsd-hackers@freebsd.org Received: from kronos.alcnet.com (kronos.alcnet.com [63.69.28.22]) by hub.freebsd.org (Postfix) with ESMTP id DBED4157E2 for ; Thu, 7 Oct 1999 11:20:11 -0700 (PDT) (envelope-from kbyanc@alcnet.com) X-Provider: ALC Communications, Inc. http://www.alcnet.com/ Received: from kbyanc (ws-41.alcnet.com [63.69.28.41]) by kronos.alcnet.com (8.9.3/8.9.3/antispam) with SMTP id OAA11628; Thu, 7 Oct 1999 14:20:08 -0400 (EDT) From: "Kelly Yancey" To: Cc: Subject: Re: Proposal for the kill-list (userland nfs) Date: Thu, 7 Oct 1999 14:20:07 -0400 Message-ID: <001e01bf10f0$961f6aa0$291c453f@kbyanc.alcnet.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit X-Priority: 3 (Normal) X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook 8.5, Build 4.71.2173.0 Importance: Normal X-MimeOLE: Produced By Microsoft MimeOLE V4.72.3110.3 Sender: owner-freebsd-hackers@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG > Date: Tue, 5 Oct 1999 12:33:24 -0700 (PDT) > From: Doug White > Subject: Re: Proposal for the kill-list (userland nfs) > > On Tue, 5 Oct 1999, Martin Blapp wrote: > > > > If you want to do this, I suggest a round of releases that have mount > > > complain about the @ syntax before you kill it. POLA, you know. > > > > > > A complaint such as: > > > > > > WARNING: path@server syntax is deprecated, use server:path > > > > > > would be sufficient. > > > > A good idea, but how can one make a difference between delimitors > > and path-components ? This would be impossible in some cases. > > Well, the current code must differentiate in some way, so attach the > warning to that. Looking at the code (on 3.2-STABLE) it looks like the suggested warning could be added but inserting warnx("WARNING: path@server syntax is deprecated, use server:path"); before line 667 of /usr/src/sbin/mount_nfs.c. But I don't see anywhere where it differentiates between delimitors and path-components. It is just a simple strchr() and the first @ or : it finds is assumed the be the delimitor. If you meant it as a path-component, you are SOL. In light of that, I think that adding the warning on line 667 then would be all that is needed. Unfortunately, this is just from my read of that section of code, as I don't have NFS running anywhere to test the actual behavior. Kelly ~kbyanc@posi.net~ FreeBSD - The Power To Serve - http://www.freebsd.org/ Join Team FreeBSD - http://www.posi.net/freebsd/Team-FreeBSD/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message