From owner-cvs-src@FreeBSD.ORG  Fri Jan 11 01:03:30 2008
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 5EEBF16A419;
	Fri, 11 Jan 2008 01:03:30 +0000 (UTC)
	(envelope-from bright@elvis.mu.org)
Received: from elvis.mu.org (elvis.mu.org [192.203.228.196])
	by mx1.freebsd.org (Postfix) with ESMTP id 7096E13C455;
	Fri, 11 Jan 2008 01:03:30 +0000 (UTC)
	(envelope-from bright@elvis.mu.org)
Received: by elvis.mu.org (Postfix, from userid 1192)
	id AE5621A4D89; Thu, 10 Jan 2008 17:00:33 -0800 (PST)
Date: Thu, 10 Jan 2008 17:00:33 -0800
From: Alfred Perlstein <alfred@freebsd.org>
To: John Baldwin <jhb@FreeBSD.org>
Message-ID: <20080111010033.GC52842@elvis.mu.org>
References: <200801102336.m0ANa0mP035046@repoman.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200801102336.m0ANa0mP035046@repoman.freebsd.org>
User-Agent: Mutt/1.4.2.3i
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/nfsclient nfs_socket.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 11 Jan 2008 01:03:30 -0000

* John Baldwin <jhb@FreeBSD.org> [080110 15:33] wrote:
> jhb         2008-01-10 23:36:00 UTC
> 
>   FreeBSD src repository
> 
>   Modified files:
>     sys/nfsclient        nfs_socket.c 
>   Log:
>   Pass curthread to various socket routines (socreate(), sobind(), and
>   soconnect()) instead of &thread0 when establishing a connection to the NFS
>   server.  Otherwise inconsistent credentials may be used when setting up
>   the NFS socket.

I'm not sure, but I think this may be a regression, I seem to recall
that a long time ago it was switched to &thread0 because otherwise
certain operations can fail due to curthread not running as root.

Rev 1.73 of this file might have some clues.

I think something weird with ipfw+uid rules can happen with curthread
rather than thread0, but I might be mistaking 1.73 for some other change.

>   
>   MFC after:      1 week
>   Reviewed by:    rwatson
>   
>   Revision  Changes    Path
>   1.156     +1 -1      src/sys/nfsclient/nfs_socket.c

-- 
- Alfred Perlstein