From owner-freebsd-current@FreeBSD.ORG Thu May 2 14:12:38 2013 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 668FC799; Thu, 2 May 2013 14:12:38 +0000 (UTC) (envelope-from davide.italiano@gmail.com) Received: from mail-vc0-f182.google.com (mail-vc0-f182.google.com [209.85.220.182]) by mx1.freebsd.org (Postfix) with ESMTP id 18EFB1EF1; Thu, 2 May 2013 14:12:37 +0000 (UTC) Received: by mail-vc0-f182.google.com with SMTP id ia10so502440vcb.41 for ; Thu, 02 May 2013 07:12:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:x-received:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=SLMz5B6Fvy6nW9YISVSZD4q8pigvpG9mtrGc6AfAnbc=; b=YAmUn3Nq+/8/Zncc1qu/sVCLFPxj1ALXdlEU/Xv1Sa9oC1jijekHNIWTyn7YDXBBN3 NvyYGdLTIAPO69jrF51UFhSfa2/mmA3/f670Yxu/CvfB/sDZFjHIN8X1HJreHgRhDTh1 lFhU5epYSE0RtOQS3VngF1RXInIpWNDt7mLiUsUcA8HqmIyscSoV/TOOlzQm3vCNkWsY YN1NuDVyYavt1kEFhUYaTlHklp3SpXDwsYjz1ymZInV2GINxgWfRIGnresMLwyWPjkyx wbgWFdkwD0+Q3d5ZrD8yZ7N9o9uGbOi2lMG0pwoLC4pgaiZUS6jbSwgL39bv8bv538+Z qXMQ== MIME-Version: 1.0 X-Received: by 10.52.231.231 with SMTP id tj7mr1872205vdc.111.1367503957072; Thu, 02 May 2013 07:12:37 -0700 (PDT) Sender: davide.italiano@gmail.com Received: by 10.220.203.199 with HTTP; Thu, 2 May 2013 07:12:36 -0700 (PDT) In-Reply-To: <51826D52.6030403@freebsd.org> References: <51820AFD.1030607@freebsd.org> <51826D52.6030403@freebsd.org> Date: Thu, 2 May 2013 16:12:36 +0200 X-Google-Sender-Auth: 97NCRG94pd0aVQWJTzMOibMm-bs Message-ID: Subject: Re: Kernel build error in hwpmc with system GNU cc From: Davide Italiano To: Andrey Chernov Content-Type: text/plain; charset=ISO-8859-1 Cc: current@freebsd.org X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 May 2013 14:12:38 -0000 On Thu, May 2, 2013 at 3:42 PM, Andrey Chernov wrote: > On 02.05.2013 14:06, Davide Italiano wrote: >>> /usr/src/sys/modules/hwpmc/../../dev/hwpmc/hwpmc_core.c:1935: warning: 'map' may be used uninitialized in this function >>> *** [hwpmc_core.o] Error code 1 > >> You can find a patch attached at the end of this mail that should fix >> the problem. > > Thanks, it fix this warning. > >> More generally speaking, why are you building -CURRENT using GCC while >> the default compiler has been clang since November 2012? > > 1) clang is not ready for production, it is too buggy. See its fixes > rate for very common things 'must work' in every compiler. It is > included into -current not because of its quality, but to involve > developers into clang bugfixes to make its progress faster, and > personally me don't want to find clang bugs. > > 2) Its build time is too long. > > 3) It generates bigger code. > >> Putting the additional burden of >> testing on the committer because two compilers are supported at the >> same time doesn't scale really well, at least according to me. > > You'll hit this error later in any case, attempting to MFC your changes > to -stable with GNU cc. > > -- > bitcoin:13fGiNutKNHcVSsgtGQ7bQ5kgUKgEQHn7N I won't object about your 2) and 3), but if you fear to hit bugs you shouldn't probably run -CURRENT. About the backport, I faced the problem of adapting code in the past when merging to stable releases, so this is actually a different problem. If I'd blindly merged the incrimined change to 9-STABLE without building and notifying the GCC warning, then I would expect you ranting at me because of build failure. There's a notion of "default compiler" in 9 and in 10 and they're different. My opinion is that people should live with it, and unless someone will introduce some mechanism a-la redports.org to overcome the issue, I will take my risks committing changes and fixing failures if they occur. It's already really difficult to have tinderbox not ranting these days, adding another compiler just result in another dimension of complexity in the whole scenario. Thanks, -- Davide "There are no solved problems; there are only problems that are more or less solved" -- Henri Poincare