From owner-freebsd-ports@freebsd.org Sat Nov 26 01:00:24 2016 Return-Path: Delivered-To: freebsd-ports@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6339BC5270C; Sat, 26 Nov 2016 01:00:24 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from tensor.andric.com (tensor.andric.com [IPv6:2001:7b8:3a7:1:2d0:b7ff:fea0:8c26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "tensor.andric.com", Issuer "COMODO RSA Domain Validation Secure Server CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 2B2EFE99; Sat, 26 Nov 2016 01:00:24 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from [IPv6:2001:7b8:3a7::50c7:6b2:9c5f:b69d] (unknown [IPv6:2001:7b8:3a7:0:50c7:6b2:9c5f:b69d]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id EB833428E8; Sat, 26 Nov 2016 02:00:20 +0100 (CET) Content-Type: multipart/signed; boundary="Apple-Mail=_0EF653AF-9350-4E6D-BBB2-3D19C509F9D4"; protocol="application/pgp-signature"; micalg=pgp-sha1 Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Subject: Re: svn commit: r427110 - head/lang/gcc/files [does lang/gcc49 need such too?] From: Dimitry Andric In-Reply-To: <86C72DB2-B9ED-4512-A88C-BD1D9A23806F@dsl-only.net> Date: Sat, 26 Nov 2016 02:00:13 +0100 Cc: svn-ports-head@freebsd.org, FreeBSD Ports , Gerald Pfeifer Message-Id: <9D54F0CC-F38C-4CCE-BC33-25C1457BD44B@FreeBSD.org> References: <86C72DB2-B9ED-4512-A88C-BD1D9A23806F@dsl-only.net> To: Mark Millard X-Mailer: Apple Mail (2.3124) X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 26 Nov 2016 01:00:24 -0000 --Apple-Mail=_0EF653AF-9350-4E6D-BBB2-3D19C509F9D4 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii On 26 Nov 2016, at 01:13, Mark Millard wrote: > >> Author: dim (src committer) >> Date: Fri Nov 25 12:54:01 2016 >> New Revision: 427110 >> URL: >> https://svnweb.freebsd.org/changeset/ports/427110 >> >> >> Log: >> Fix build of lang/gcc with libc++ 3.9.0, similar to r421625: >> . . . >> What is happening here, is that the source file includes gcc/system.h, >> which defines abort to fancy_abort, and then the source file includes >> , which attempts to call _VSTD::abort() (the _VSTD is a libc++ >> alias for std::). The macro definition then causes the above breakage. >> >> Newer gcc ports, such as gcc5 and gcc6 don't show this issue, because >> upstream gcc first added an include of (which indirectly >> includes ) in r217348 [1], and later even add a direct include of >> in r232736 [2]. >> >> Fix it for this version, by adding the direct include of to >> gcc/system.h. This makes the 'second' includes of in some .c >> files superfluous, but at least they won't result in errors. > > Will lang/gcc49 needs similar changes? Actually, the patch was copied from the lang/gcc49 port, which had already been fixed earlier, in r421625. > (I normally only use explicitly version numbered lang/gcc* 's and > I use lang/gcc49 on powerpc64's.) Well, lang/gcc is a special case, in the sense that some ports that have USE_GCC=yes, e.g. with an unspecified version, will default to it. -Dimitry --Apple-Mail=_0EF653AF-9350-4E6D-BBB2-3D19C509F9D4 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.30 iEYEARECAAYFAlg43qQACgkQsF6jCi4glqPXEQCbBTGHAybQmC1tvyoaJL/ORQPq atYAoOQ8N2gcwjeY/xP4W7B+oCCenarA =f8bk -----END PGP SIGNATURE----- --Apple-Mail=_0EF653AF-9350-4E6D-BBB2-3D19C509F9D4--