From owner-svn-src-head@FreeBSD.ORG Mon Aug 18 21:12:15 2014 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 8D41AEF4; Mon, 18 Aug 2014 21:12:15 +0000 (UTC) Received: from mail-wi0-x22a.google.com (mail-wi0-x22a.google.com [IPv6:2a00:1450:400c:c05::22a]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id B0DC73827; Mon, 18 Aug 2014 21:12:14 +0000 (UTC) Received: by mail-wi0-f170.google.com with SMTP id f8so4297834wiw.3 for ; Mon, 18 Aug 2014 14:12:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=38QGDx4ph54hc9DHiudufCUQPgXfXknT6IC7QzEkAok=; b=VY+XcBtULMvZfCKfvo02xLSTnfZsRExa+puQUvjkw9qUU1qWyUBRZ61cPBPsoRbKpi gqmXDWA6qUFdmOe1zhIH7F0DlVcvDVu5rGhgN+kOZzj+XwP3nh3vlmiWaqWRIDPPrDvN nXMYmjT8wXPt62BfDXkEx+i4DlYCr/5fPLPQN3BfjhRjrs/hqcy9BaBtEs7If19bSs9q 2VycUNcR0MjeeXoMZ85bhU/1m+5+5YBPMS5kvdKilYsXXGRnuSzqwLZL2RWz4OuabHz3 PCwLNdAE4Uf/FNpqSWr5EG4zjDwz5J5V2srjoagTEy7rwROrQ9hW9ukifyGUFf/yq0zm YHdA== MIME-Version: 1.0 X-Received: by 10.180.75.49 with SMTP id z17mr1609756wiv.80.1408396332506; Mon, 18 Aug 2014 14:12:12 -0700 (PDT) Sender: pluknet@gmail.com Received: by 10.217.157.137 with HTTP; Mon, 18 Aug 2014 14:12:12 -0700 (PDT) In-Reply-To: <20140818160554.121e16e7@kan> References: <201408181927.s7IJRm9P048886@svn.freebsd.org> <20140818160554.121e16e7@kan> Date: Tue, 19 Aug 2014 01:12:12 +0400 X-Google-Sender-Auth: Cc4fYOLb5mRATgFaDLsAlfQOiBM Message-ID: Subject: Re: svn commit: r270149 - head/sys/geom From: Sergey Kandaurov To: Alexander Kabaev Content-Type: text/plain; charset=ISO-8859-1 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Scott Long X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Aug 2014 21:12:15 -0000 On 19 August 2014 00:05, Alexander Kabaev wrote: > On Mon, 18 Aug 2014 23:51:32 +0400 > Sergey Kandaurov wrote: > >> On 18 August 2014 23:27, Scott Long wrote: >> > Author: scottl >> > Date: Mon Aug 18 19:27:47 2014 >> > New Revision: 270149 >> > URL: http://svnweb.freebsd.org/changeset/base/270149 >> > >> > Log: >> > Deal explicitly with possible failures of make_dev_alias_p() in >> > GEOM. >> > >> > Submitted by: Mariusz Zaborski >> > MFC after: 3 days >> > >> > Modified: >> > head/sys/geom/geom_dev.c >> > >> > Modified: head/sys/geom/geom_dev.c >> > ============================================================================== >> > --- head/sys/geom/geom_dev.c Mon Aug 18 18:07:28 2014 >> > (r270148) +++ head/sys/geom/geom_dev.c Mon Aug 18 19:27:47 >> > 2014 (r270149) >> [...] >> > @@ -263,6 +264,7 @@ g_dev_taste(struct g_class *mp, struct g >> > if (adev != NULL) { >> > adev->si_iosize_max = MAXPHYS; >> > adev->si_drv2 = cp; >> > + adev->si_flags |= SI_UNMAPPED; >> > } >> > >> > g_dev_attrchanged(cp, "GEOM::physpath"); >> > >> >> This part looks unrelated. >> > > Commit says that it deals with consequences of make_dev_alias_p > failing. Preventing trap happening on said failure seems to be > pretty much related to the stated goal. I missed setting SI_UNMAPPED was already there, nevermind. -- wbr, pluknet