From owner-svn-ports-all@freebsd.org Fri Nov 2 21:41:50 2018 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2700710DC3DB; Fri, 2 Nov 2018 21:41:50 +0000 (UTC) (envelope-from ler@FreeBSD.org) Received: from thebighonker.lerctr.org (thebighonker.lerctr.org [IPv6:2001:470:1f0f:3ad:bb:dcff:fe50:d900]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "*.lerctr.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id BE0297FF05; Fri, 2 Nov 2018 21:41:49 +0000 (UTC) (envelope-from ler@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lerctr.org; s=lerami; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=PlBCboDiz33aPovEEfd4N9ekCTtDQwjb98JfedIyMig=; b=HlnLeLI0+HGyp8msYkWS/Ojw40 kseUF9aVdlchCugWiY7CgUc+0mKmAtgBLoJQbOINyqYr9E5aumFcvS3/7Hw45udmkrvt9APmpG8W0 N1/ZDm3AvH22cKIi57PeQjGxBlgTXwRqG4+emTB+nPX2aNa27k0AX4DSB4gB1t5hgZDw=; Received: from [2600:1700:210:b18f:14ab:5742:a11f:4d3c] (port=53118 helo=ler-imac.local) by thebighonker.lerctr.org with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91 (FreeBSD)) (envelope-from ) id 1gIhCO-000Leo-9p; Fri, 02 Nov 2018 16:41:48 -0500 Date: Fri, 2 Nov 2018 16:41:47 -0500 From: Larry Rosenman To: Mathieu Arnold Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r483437 - in head/mail/dovecot: . files Message-ID: <20181102214147.3j4jf4bdujgaijjp@ler-imac.local> Mail-Followup-To: Mathieu Arnold , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org References: <201810292328.w9TNSRHm018030@repo.freebsd.org> <20181031150252.p4lhmlaposwurdgr@ogg.in.absolight.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="zaoma6c5uowzsavp" Content-Disposition: inline In-Reply-To: <20181031150252.p4lhmlaposwurdgr@ogg.in.absolight.net> User-Agent: NeoMutt/20180716 X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Nov 2018 21:41:50 -0000 --zaoma6c5uowzsavp Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Oct 31, 2018 at 04:02:52PM +0100, Mathieu Arnold wrote: > On Mon, Oct 29, 2018 at 11:28:27PM +0000, Larry Rosenman wrote: > > Modified: head/mail/dovecot/files/dovecot.in > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > > --- head/mail/dovecot/files/dovecot.in Mon Oct 29 23:25:58 2018 (r48343= 6) > > +++ head/mail/dovecot/files/dovecot.in Mon Oct 29 23:28:26 2018 (r48343= 7) > > @@ -60,6 +60,14 @@ for config in ${dovecot_config}; do > > required_files=3D"${config}" > > command_args=3D"-c ${config}" > > if [ -s ${config} ]; then > > + ${command} ${command_args} -a 2>/dev/null > > + if [ $? -ne 0 ]; then >=20 > Never test for $?. This should be: >=20 > if ${command} ${command_args} -a 2>/dev/null; then >=20 > All the rationale in https://github.com/koalaman/shellcheck/wiki/SC2181. But, for my own interest, what if I want to put out what the return code is in a message? >=20 >=20 > --=20 > Mathieu Arnold --=20 Larry Rosenman http://www.lerctr.org/~ler Phone: +1 214-642-9640 E-Mail: ler@lerctr.org US Mail: 5708 Sabbia Drive, Round Rock, TX 78665-2106 --zaoma6c5uowzsavp Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQHBBAABCgCrFiEEHjgknedhWzvJgwVzaXyZsatIp30FAlvcxJstFIAAAAAAFQAP cGthLWFkZHJlc3NAZ251cGcub3JnbGVyQEZyZWVCU0Qub3JnXxSAAAAAAC4AKGlz c3Vlci1mcHJAbm90YXRpb25zLm9wZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQxRTM4 MjQ5REU3NjE1QjNCQzk4MzA1NzM2OTdDOTlCMUFCNDhBNzdEAAoJEGl8mbGrSKd9 DKoIAKS0/dx7jo6u73V59Aw+XTBTKv1bXGZaC060eCOCuArsa0HDjau4uufwBwpQ fx6XX75+gu2tbM6k2myK6zccG0gf+Ng6imkBUsnr4Y5spkwz8m20v0jjeYSjkjr4 Uygy+uh33U2vv0D00CXte4nrOMON2wHX2+LbDv8Auysu8OII0h+/nfTzQ6u8QgIn n8fn1tRZcEffuIa1ctsSJ93/tFYVif47Ov/4Z9FOYd9LSKAIP2O5i3GldtHDUW/g MdH/pRAPuZZVzJPYzyo0LIZnuFDbxgdnHVYDgLEop/+T0HiKBCT6dG8ZzyhrjABP X+rPmJUjqSXH8ptLC0gN5lUxKIA= =xqYp -----END PGP SIGNATURE----- --zaoma6c5uowzsavp--