From owner-freebsd-bugs Thu Apr 6 5:30: 5 2000 Delivered-To: freebsd-bugs@freebsd.org Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21]) by hub.freebsd.org (Postfix) with ESMTP id EADDF37BBD7 for ; Thu, 6 Apr 2000 05:30:02 -0700 (PDT) (envelope-from gnats@FreeBSD.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.9.3/8.9.2) id FAA65129; Thu, 6 Apr 2000 05:30:02 -0700 (PDT) (envelope-from gnats@FreeBSD.org) Date: Thu, 6 Apr 2000 05:30:02 -0700 (PDT) Message-Id: <200004061230.FAA65129@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org Cc: From: Sheldon Hearn Subject: Re: bin/17824: [PATCH] /usr/bin/column has arithmetic overflows Reply-To: Sheldon Hearn Sender: owner-freebsd-bugs@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org The following reply was made to PR bin/17824; it has been noted by GNATS. From: Sheldon Hearn To: jdg@debian.org Cc: freebsd-gnats-submit@FreeBSD.ORG Subject: Re: bin/17824: [PATCH] /usr/bin/column has arithmetic overflows Date: Thu, 06 Apr 2000 14:25:53 +0200 On Thu, 06 Apr 2000 02:06:54 MST, jdg@debian.org wrote: > maxlength = (maxlength + TAB) & ~(TAB - 1); > numcols = termwidth / maxlength; > + if (!numcols) { I don't get it. You still don't seem to be protecting against divide-by-zero. Shouldn't you be testing the value of the dividend before dividing? Ciao, Sheldon. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message