From owner-svn-ports-all@freebsd.org Sun Jan 21 23:14:28 2018 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 26D81EC0BF5; Sun, 21 Jan 2018 23:14:28 +0000 (UTC) (envelope-from adamw@adamw.org) Received: from apnoea.adamw.org (apnoea.adamw.org [104.225.5.94]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "apnoea.adamw.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id B6EE4808CB; Sun, 21 Jan 2018 23:14:26 +0000 (UTC) (envelope-from adamw@adamw.org) Received: by apnoea.adamw.org (OpenSMTPD) with ESMTPSA id 1f5c24a3 TLS version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO; Sun, 21 Jan 2018 16:14:25 -0700 (MST) Content-Type: text/plain; charset=us-ascii; delsp=yes; format=flowed Mime-Version: 1.0 (Mac OS X Mail 11.2 \(3445.5.20\)) Subject: Re: svn commit: r459630 - in head/mail/openwebmail: . files From: Adam Weinberger In-Reply-To: Date: Sun, 21 Jan 2018 16:14:23 -0700 Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Content-Transfer-Encoding: 7bit Message-Id: <2A42A59A-B81E-4656-8A65-05D67F78141B@adamw.org> References: <201801212214.w0LMElpt069984@repo.freebsd.org> To: Chris Rees X-Mailer: Apple Mail (2.3445.5.20) X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 21 Jan 2018 23:14:28 -0000 > On 21 Jan, 2018, at 15:21, Adam Weinberger wrote: > >> On 21 Jan, 2018, at 15:14, Chris Rees wrote: >> >> Author: crees >> Date: Sun Jan 21 22:14:47 2018 >> New Revision: 459630 >> URL: https://svnweb.freebsd.org/changeset/ports/459630 >> >> Log: >> Correct array checks >> >> Submitted by: Emil Barta >> >> Modified: >> head/mail/openwebmail/Makefile >> head/mail/openwebmail/files/patch-fix-perl >> >> Modified: head/mail/openwebmail/Makefile >> ============================================================================== >> --- head/mail/openwebmail/Makefile Sun Jan 21 21:43:07 2018 (r459629) >> +++ head/mail/openwebmail/Makefile Sun Jan 21 22:14:47 2018 (r459630) >> @@ -3,7 +3,7 @@ >> >> PORTNAME= openwebmail >> PORTVERSION= 2.53 >> -PORTREVISION= 3 >> +PORTREVISION= 4 >> CATEGORIES= mail >> MASTER_SITES= http://openwebmail.acatysmoof.com/download/release/ \ >> http://openwebmail.org/openwebmail/download/release/ >> >> Modified: head/mail/openwebmail/files/patch-fix-perl >> ============================================================================== >> --- head/mail/openwebmail/files/patch-fix-perl Sun Jan 21 21:43:07 >> 2018 (r459629) >> +++ head/mail/openwebmail/files/patch-fix-perl Sun Jan 21 22:14:47 >> 2018 (r459630) >> @@ -69,7 +69,7 @@ diff -ruN openwebmail/shares/mailfilter.pl openwebmail >> } >> } >> - if (!defined @{$r_attachments}) { >> -+ if (!@{$r_attachments}) { >> ++ if (!ref{$r_attachments}) { >> ($header, $body, $r_attachments)=ow::mailparse::parse_rfc822block(\$currmessage); >> } >> >> @@ -78,7 +78,7 @@ diff -ruN openwebmail/shares/mailfilter.pl openwebmail >> } >> } >> - if (!defined @{$r_attachments}) { >> -+ if (!@{$r_attachments}) { >> ++ if (!ref{$r_attachments}) { > > Hi Chris, > > Are you sure about this change? {...} defines a hash reference, so I > believe ref{...} will always be true. Did you want just "ref > $r_attachments" instead? Actually, I think what you're looking for is !ref@{$r_attachments} # Adam -- Adam Weinberger adamw@adamw.org http://www.adamw.org