From owner-trustedbsd-audit@FreeBSD.ORG Sat Nov 18 12:05:59 2006 Return-Path: X-Original-To: trustedbsd-audit@freebsd.org Delivered-To: trustedbsd-audit@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 8106816A403 for ; Sat, 18 Nov 2006 12:05:59 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from cyrus.watson.org (cyrus.watson.org [209.31.154.42]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5D01B43D7D for ; Sat, 18 Nov 2006 12:05:56 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from fledge.watson.org (fledge.watson.org [209.31.154.41]) by cyrus.watson.org (Postfix) with ESMTP id CA46C46C44; Sat, 18 Nov 2006 07:05:58 -0500 (EST) Date: Sat, 18 Nov 2006 12:05:58 +0000 (GMT) From: Robert Watson X-X-Sender: robert@fledge.watson.org To: Diego Giagio In-Reply-To: <20061118094331.H67585@fledge.watson.org> Message-ID: <20061118120246.U50450@fledge.watson.org> References: <33453.36565.qm@web55503.mail.re4.yahoo.com> <455B89A5.1070607@gmail.com> <1b0798830611170822x15add173hfcad44ed830ec01e@mail.gmail.com> <20061118094331.H67585@fledge.watson.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: trustedbsd-audit@freebsd.org Subject: Re: Additional 64-bit token types to libbsm X-BeenThere: trustedbsd-audit@FreeBSD.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: TrustedBSD Audit Discussion List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 18 Nov 2006 12:05:59 -0000 On Sat, 18 Nov 2006, Robert Watson wrote: > On Fri, 17 Nov 2006, Diego Giagio wrote: > >> On 11/15/06, Diego Giagio wrote: >>> >>> No problem. Attached is a patch with XML printing support that applies >>> cleanly to HEAD as of today. >> >> Could anyone please review the patch? I didn't receive any response for the >> last two days. I'm about to assume its not any good. > > The version after Martin's comments looked good to me, so I've submitted it > to P4. I'll cut a new OpenBSM release in the next couple of days that will > include these changes and Martin's XML changes. I'll also look at getting > Martin's hostname changes (to include the hostname in the trail filename) in > before doing so. FYI, I modified the patch in the following ways in P4: - I modified the ex variants to write out addresses in the byte order passed to the function, rather than in network byte order, since we assume that passed addresses are already in network byte order. - I added test generation functions to openbsm/test/bsm and generated reference tokens. - I removed the now-unneeded __unused qualifiers to some functions (including some that already existed before your patch). Our code for generating ex tokens seems to differ slightly from OpenSolaris with respect to handling variable length addresses: the OpenSolaris code appears to always write out the full length 3x32-bit field for both IPv4 and IPv6 arguments, although it's possibly they generate ex entries for only IPv6 addresses, in which case this may not have a practical import yet. Robert N M Watson Computer Laboratory University of Cambridge