From owner-freebsd-current@FreeBSD.ORG Tue Jan 13 21:24:08 2009 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 298941065675 for ; Tue, 13 Jan 2009 21:24:08 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mail.terabit.net.ua (mail.terabit.net.ua [195.137.202.147]) by mx1.freebsd.org (Postfix) with ESMTP id C31A38FC18 for ; Tue, 13 Jan 2009 21:24:07 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from skuns.zoral.com.ua ([91.193.166.194] helo=mail.zoral.com.ua) by mail.terabit.net.ua with esmtps (TLSv1:AES256-SHA:256) (Exim 4.63 (FreeBSD)) (envelope-from ) id 1LMqk0-0004xu-3k; Tue, 13 Jan 2009 23:24:04 +0200 Received: from deviant.kiev.zoral.com.ua (root@deviant.kiev.zoral.com.ua [10.1.1.148]) by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id n0DLNuug030122 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 13 Jan 2009 23:23:57 +0200 (EET) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.3/8.14.3) with ESMTP id n0DLNuXf059323; Tue, 13 Jan 2009 23:23:56 +0200 (EET) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.3/8.14.3/Submit) id n0DLNtXw059319; Tue, 13 Jan 2009 23:23:55 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Tue, 13 Jan 2009 23:23:55 +0200 From: Kostik Belousov To: Jeremie Le Hen Message-ID: <20090113212355.GG2247@deviant.kiev.zoral.com.ua> References: <20090113210716.GI41799@obiwan.tataz.chchile.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="2E/hm+v6kSLEYT3h" Content-Disposition: inline In-Reply-To: <20090113210716.GI41799@obiwan.tataz.chchile.org> User-Agent: Mutt/1.4.2.3i X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on skuns.kiev.zoral.com.ua X-Virus-Scanned: mail.terabit.net.ua 1LMqk0-0004xu-3k 105578affd50d815ec25c6fa4af2884c X-Terabit: YES Cc: freebsd-current@freebsd.org Subject: Re: fstab type "dp" X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Jan 2009 21:24:08 -0000 --2E/hm+v6kSLEYT3h Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jan 13, 2009 at 10:07:16PM +0100, Jeremie Le Hen wrote: > Hi, >=20 > A year ago, I discussed with rwatson@ about having a new fs_type > for dump devices. I initially implemented it as "du" but I later > noticed that NetBSD already has this feature as "dp". >=20 > I'd like to get some review about this patch in the hope of getting this > patch eventually committed. >=20 > This patch contains: > - New fs_type "dp" for dump devices, along with "sw" for swap devices. > - dumpon(8) and savecore(8) updated accordingly. > - New dumpon(8) option -a that implements the logic to automatically > select a correct dump devices by scanning fstab(5). The logic is > backward compatible, that is if no "dp" entry is present, it will use > the first "sw" entry. Also, etc/rc.d/dumpon has been modified to use > this new option. > - New dumpon(8) option -f to force the use of a device not marked as > "dp" or "sw". This is a bonus. > - Manpages updated. >=20 > Note that both dumpon(8) and savecore(8) required the fs_vfstype to be > "swap" for "sw" devices for "XXX backward compatibility". Despite this > wasn't documented in the manpage, I didn't removed it and added "dump" > as a valid fs_vfstype. The fstab(5) manpage still doesn't mention them > though. What are the supposed advantages of this approach over the dumpdev variable in rc.conf ? I see that having whole partition usage configuration in fstab is natural, so the idea of the patch is probably right. One the other hand, is it possible to enchance this to allow specification of the swap partition that is also a dump partition, in fstab ? --2E/hm+v6kSLEYT3h Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (FreeBSD) iEUEARECAAYFAkltBmsACgkQC3+MBN1Mb4jKJgCYkldfwqd32mSLN0akdjDNMy87 tQCbBTvy8fj5ti5fcL4zdnxRGBil5dA= =7sLf -----END PGP SIGNATURE----- --2E/hm+v6kSLEYT3h--