Date: Tue, 8 Feb 2011 14:48:59 -0800 From: Jack Vogel <jfvogel@gmail.com> To: Karim Fodil-Lemelin <fodillemlinkarim@gmail.com>, Pyun YongHyeon <pyunyh@gmail.com>, Michael Tuexen <tuexen@freebsd.org>, beezarliu <beezarliu@yahoo.com.cn> Cc: freebsd-net@freebsd.org Subject: Re: igb driver RX (was TX) hangs when out of mbuf clusters Message-ID: <AANLkTin5DZBnr_VcXRyUmpcH2Gsr3GuaW4EsBtKJ6omd@mail.gmail.com> In-Reply-To: <AANLkTikMuFRY=W0%2BVtGKdWkJcOFVbdy=OOZNe_xFUC3R@mail.gmail.com> References: <AANLkTikrjkHDaBq%2Bx6MTZhzOeqWA=xtFpqQPsthFGmuf@mail.gmail.com> <D70A2DA6-23B7-442D-856C-4267359D66A5@lurchi.franken.de> <AANLkTinLg6QZz67e3Hhda-bzTX69XWNcdEkr3EZHFmSZ@mail.gmail.com> <AANLkTikMuFRY=W0%2BVtGKdWkJcOFVbdy=OOZNe_xFUC3R@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--001485f92346754a72049bcd27d7 Content-Type: text/plain; charset=ISO-8859-1 I have been following this, and thinking about it. I still am working from a theoretical standpoint, but based on a patch I got quite a long time back and never quite groked, I believe now that I might have a solution. The original PR and patch was kern/150516 from Beezar Liu, I was never quite comfortable with the code changes, nor convinced that it was a real issue and not a misunderstanding. However I think now that this very report might be behind what we are seeing today. I have a slightly different approach to solving it, of course it remains to be seen if it handles it properly. Please try the patch I've attached, I'm open to further correction or polishing of the changes. And thanks to Beezar for his original report and changes, this is not for em, but if this eliminates the problem its clearly needed in all drivers. Jack --001485f92346754a72049bcd27d7 Content-Type: text/x-patch; charset=US-ASCII; name="igb.patch" Content-Disposition: attachment; filename="igb.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_gjwwm4jo0 UHJveHlDaGFpbnMtMy4xIChodHRwOi8vcHJveHljaGFpbnMuc2YubmV0KQpJbmRleDogaWZfaWdi LmMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gaWZfaWdiLmMJKHJldmlzaW9uIDIxODQ2MykKKysrIGlmX2lnYi5j CSh3b3JraW5nIGNvcHkpCkBAIC00MzEyLDYgKzQzMTIsNyBAQAogCQlzdHJ1Y3QgbWJ1ZgkJKnNl bmRtcCwgKm1oLCAqbXA7CiAJCXN0cnVjdCBpZ2JfcnhfYnVmCSpyeGJ1ZjsKIAkJdTE2CQkJaGxl biwgcGxlbiwgaGRyLCB2dGFnOworCQlpbnQJCQljb21taXQ7CiAJCWJvb2wJCQllb3AgPSBGQUxT RTsKICAKIAkJY3VyID0gJnJ4ci0+cnhfYmFzZVtpXTsKQEAgLTQ0NDAsMTAgKzQ0NDEsMjIgQEAK IAkJYnVzX2RtYW1hcF9zeW5jKHJ4ci0+cnhkbWEuZG1hX3RhZywgcnhyLT5yeGRtYS5kbWFfbWFw LAogCQkgICAgQlVTX0RNQVNZTkNfUFJFUkVBRCB8IEJVU19ETUFTWU5DX1BSRVdSSVRFKTsKIAor CQljb21taXQgPSBpOwkvKiBjYXB0dXJlIHRoZSBvbGQgaW5kZXggKi8KKwogCQkvKiBBZHZhbmNl IG91ciBwb2ludGVycyB0byB0aGUgbmV4dCBkZXNjcmlwdG9yLiAqLwogCQlpZiAoKytpID09IGFk YXB0ZXItPm51bV9yeF9kZXNjKQogCQkJaSA9IDA7CiAJCS8qCisJCSoqIFNhbml0eSB0ZXN0IGZv ciByaW5nIGZ1bGwsIGlmIHRoaXMKKwkJKiogaGFwcGVucyB3ZSBuZWVkIHRvIHJlZnJlc2ggaW1t ZWRpYXRlbHkKKwkJKiogb3IgcmVmcmVzaCBtYXkgZGVhZGxvY2suCisJCSovCisJCWlmIChpID09 IHJ4ci0+bmV4dF90b19yZWZyZXNoKSB7CisJCQlpZ2JfcmVmcmVzaF9tYnVmcyhyeHIsIGNvbW1p dCk7CisJCQlwcm9jZXNzZWQgPSAwOworCQl9CisKKwkJLyoKIAkJKiogU2VuZCB0byB0aGUgc3Rh Y2sgb3IgTFJPCiAJCSovCiAJCWlmIChzZW5kbXAgIT0gTlVMTCkgewo= --001485f92346754a72049bcd27d7--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?AANLkTin5DZBnr_VcXRyUmpcH2Gsr3GuaW4EsBtKJ6omd>