From owner-freebsd-bugs Thu Dec 17 11:10:01 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id LAA02748 for freebsd-bugs-outgoing; Thu, 17 Dec 1998 11:10:01 -0800 (PST) (envelope-from owner-freebsd-bugs@FreeBSD.ORG) Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id LAA02677 for ; Thu, 17 Dec 1998 11:10:00 -0800 (PST) (envelope-from gnats@FreeBSD.org) Received: (from Unknown UID 563@localhost) by freefall.freebsd.org (8.8.8/8.8.5) id LAA05058; Thu, 17 Dec 1998 11:10:01 -0800 (PST) Date: Thu, 17 Dec 1998 11:10:01 -0800 (PST) Message-Id: <199812171910.LAA05058@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.ORG From: "David G. Andersen" Subject: Re: kern/8732: nfs mounts with 'intr' can cause system hang Reply-To: "David G. Andersen" Sender: owner-freebsd-bugs@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org The following reply was made to PR kern/8732; it has been noted by GNATS. From: "David G. Andersen" To: David Malone Cc: freebsd-gnats-submit@freebsd.org, danderse@cs.utah.edu, nops@maths.tcd.ie Subject: Re: kern/8732: nfs mounts with 'intr' can cause system hang Date: Thu, 17 Dec 1998 12:08:23 -0700 (MST) I decided to take the "return INTR on close, and don't worry about it" approach. This patch does exactly this. We're testing it here now, and it seems to work, and doesn't seem to have broken anything. Testers wanted. :-) Index: vfs_subr.c =================================================================== RCS file: /n/marker/usr/lsrc/FreeBSD/CVS/src/sys/kern/vfs_subr.c,v retrieving revision 1.174 diff -r1.174 vfs_subr.c 582,584c582,589 < tsleep((caddr_t)&vp->v_numoutput, < slpflag | (PRIBIO + 1), < "vinvlbuf", slptimeo); --- > if (error = tsleep((caddr_t)&vp->v_numoutput, > slpflag | (PRIBIO + 1), > "vinvlbuf", slptimeo)) { > if (error == EINTR) { > splx(s); > return (EINTR); > } > } To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message