From owner-cvs-all@FreeBSD.ORG Wed Oct 25 04:04:17 2006 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E971916A415; Wed, 25 Oct 2006 04:04:17 +0000 (UTC) (envelope-from sobomax@FreeBSD.org) Received: from sippysoft.com (gk.360sip.com [72.236.70.226]) by mx1.FreeBSD.org (Postfix) with ESMTP id 36F2E43D58; Wed, 25 Oct 2006 04:04:16 +0000 (GMT) (envelope-from sobomax@FreeBSD.org) Received: from [192.168.1.47] ([204.244.149.125]) (authenticated bits=0) by sippysoft.com (8.13.8/8.13.6) with ESMTP id k9P44D0E044885 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 24 Oct 2006 21:04:14 -0700 (PDT) (envelope-from sobomax@FreeBSD.org) Message-ID: <453EE201.9040305@FreeBSD.org> Date: Tue, 24 Oct 2006 21:03:13 -0700 From: Maxim Sobolev Organization: Sippy Software, Inc. User-Agent: Thunderbird 1.5.0.7 (Windows/20060909) MIME-Version: 1.0 To: Robert Watson References: <200610240818.k9O8IATH022313@repoman.freebsd.org> <20061024094643.N37455@fledge.watson.org> <453DDED4.3070208@FreeBSD.org> <20061024104143.Y37455@fledge.watson.org> <453DE26E.3040502@FreeBSD.org> <20061024105800.J37455@fledge.watson.org> <453DEB1B.6040900@FreeBSD.org> <20061024145506.G48521@fledge.watson.org> In-Reply-To: <20061024145506.G48521@fledge.watson.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/su su.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Oct 2006 04:04:18 -0000 Robert, Your patch works just fine. Please don't forget to MFC it before 6.2 is out. Thanks! Regards, Maxim Robert Watson wrote: > > On Tue, 24 Oct 2006, Maxim Sobolev wrote: > >> Robert Watson wrote: >>> The method by which the distinction between ENOSYS+SIGSYS and plain >>> ENOSYS is determined is in the implementation of the system call. If >>> a system call is flagged as unimplemented (i.e., you never hit the >>> function implementing it), you get SIGSYS+ENOSYS. If you enter the >>> stub, you get ENOSYS. So the problem is that the compat code doesn't >>> enter the stub, so never gets to the ENOSYS path. A casual glance at >>> the system call arguments for audit suggest that wrappers aren't >>> needed (no pointers embedded in structure arguments), so simply >>> marking them as implemented will likely work. >> >> Well unless I have confused something it is not really the case. For >> example, getauid() system call takes pointer as an argument. > > I've gone ahead and updated the freebsd32 syscalls.master file to hook > up the audit system calls. Could you locally back out your change and > see if a kernel built with these changes operates properly? > > Thanks, > > Robert N M Watson > Computer Laboratory > University of Cambridge > >