Date: Sun, 12 May 2013 21:05:19 -0400 From: Eitan Adler <eadler@freebsd.org> To: Alexey Dokuchaev <danfe@freebsd.org> Cc: svn-ports-head@freebsd.org, Mark Linimon <linimon@lonesome.com>, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r317934 - in head/games: doom-data duke3d-data quake-data quake2-data quake3-data Message-ID: <CAF6rxgmpWs2BfvzG6b1ivH=PFwd%2B-hwpXfk_1m6t-SQjYEu-SQ@mail.gmail.com> In-Reply-To: <20130513003231.GC32639@FreeBSD.org> References: <201305120806.r4C86W9X001716@svn.freebsd.org> <20130512183849.GA19247@lonesome.com> <20130513003231.GC32639@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 12 May 2013 20:32, Alexey Dokuchaev <danfe@freebsd.org> wrote:
> On Sun, May 12, 2013 at 01:38:49PM -0500, Mark Linimon wrote:
>> On Sun, May 12, 2013 at 08:06:32AM +0000, Alexey Dokuchaev wrote:
>> > Log:
>> > If port is setting PKGNAMEPREFIX=${FOOPKGNAMEPREFIX}, but .include's this
>> > file before <bsd.port.options.mk>, options handling gets broken because
>> > options will be loaded from OPTIONSFILE which is based on UNIQUENAME and
>> > thus PKGNAMEPREFIX, which is empty at that point. Prevent this: ensure
>> > that FOOPKGNAMEPREFIX is defined in advance for ports that use it to set
>> > their PKGNAMEPREFIX and having OPTIONS.
>>
>> As I feared, this commit broke INDEX. Please see
>> http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/dads-dot-error.html .
>
> Sorry for that. I suppose my r317936 fixed that, did it?
>
> I'll see if I can avoid using .error though.
Please use IGNORE instead of .error
--
Eitan Adler
Source, Ports, Doc committer
Bugmeister, Ports Security teams
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAF6rxgmpWs2BfvzG6b1ivH=PFwd%2B-hwpXfk_1m6t-SQjYEu-SQ>