From owner-dev-commits-src-main@freebsd.org Wed Aug 4 13:44:34 2021 Return-Path: Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 2FA8065ECA0; Wed, 4 Aug 2021 13:44:34 +0000 (UTC) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: from gndrsh.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4GftJd6PClz3vND; Wed, 4 Aug 2021 13:44:33 +0000 (UTC) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: from gndrsh.dnsmgr.net (localhost [127.0.0.1]) by gndrsh.dnsmgr.net (8.13.3/8.13.3) with ESMTP id 174DiVeu052683; Wed, 4 Aug 2021 06:44:31 -0700 (PDT) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: (from freebsd@localhost) by gndrsh.dnsmgr.net (8.13.3/8.13.3/Submit) id 174DiVr0052682; Wed, 4 Aug 2021 06:44:31 -0700 (PDT) (envelope-from freebsd) From: "Rodney W. Grimes" Message-Id: <202108041344.174DiVr0052682@gndrsh.dnsmgr.net> Subject: Re: git: 184d64af1344 - main - locales: stop hardcoding the directories in the mtree In-Reply-To: <1acb127e-1d2c-4c9f-96e6-23bfbf9695ac@FreeBSD.org> To: Baptiste Daroussin Date: Wed, 4 Aug 2021 06:44:31 -0700 (PDT) CC: "Rodney W. Grimes" , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Reply-To: rgrimes@freebsd.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: 4GftJd6PClz3vND X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-src-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for the main branch of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Aug 2021 13:44:34 -0000 > 3 ao?t 2021 19:32:44 Rodney W. Grimes : > > >> The branch main has been updated by bapt: > >> > >> URL: https://cgit.FreeBSD.org/src/commit/?id=184d64af1344d6f3c370499510cede49320f4863 > >> > >> commit 184d64af1344d6f3c370499510cede49320f4863 > >> Author:???? Baptiste Daroussin > >> AuthorDate: 2021-08-03 12:25:00 +0000 > >> Commit:???? Baptiste Daroussin > >> CommitDate: 2021-08-03 12:25:00 +0000 > >> > >> ??? locales: stop hardcoding the directories in the mtree > >> ??? > >> ??? The framework knows how to create directories and tag them properly > >> ??? for a the creation of a mtree, not need to hardcode all the locales > >> ??? entries in bsd.usr.mk > >> ??? > >> ??? This simplifies addition of new locales but also allow people building > >> ??? with WITHOUT_LOCALES to end up with a directory full of empty files > > > > The uses of /etc/mtree go beyond the simple directory creation, > > please cause something to build a BSD.locale.dist file and install > > it in /etc/mtree to replace the functionality removal you have > > just performed. > > > > Thanks, > > Rod > > > > Please provide a valid use case not working anymore after this change and I will consider. >From mtree(1): The mtree utility compares a file hierarchy against a specification, Since the shipped specification is now incomplete it can no longer be used to do validate the hiararchy of a system against RELEASED /etc/mtree files. > > Note that this is not the only part of the tree where the same thing is done. More regression does not make regression right. > Best, > Bapt -- Rod Grimes rgrimes@freebsd.org