Date: Sun, 24 Aug 2014 18:46:17 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 192964] [New Port] devel/go-hashicorp-logutils Message-ID: <bug-192964-13-HR4Cce5MXU@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-192964-13@https.bugs.freebsd.org/bugzilla/> References: <bug-192964-13@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=192964 --- Comment #7 from Thomas Bartelmess <thomas@bartelmess.io> --- I think the @dirrmtry %%GO_SRCDIR%%/%%GO_PKGNAME%% @dirrmtry %%GO_SRCDIR%%/github.com/hashicorp @dirrmtry %%GO_SRCDIR%%/github.com @dirrmtry %%GO_SRCDIR%% @dirrmtry %%GO_LIBDIR%%/github.com/hashicorp @dirrmtry %%GO_LIBDIR%%/github.com @dirrmtry %%GO_LIBDIR%% @dirrmtry share/go/pkg @dirrmtry share/go is still required since go installs the sources of the package there. (In reply to John Marino from comment #5) > (In reply to Thomas Bartelmess from comment #4) > > For me it seems like > > bsd.port.pre.mk has to be included before bsd.go.mk > > If it's not included, I am getting an error, because the $ARCH variable is > > not set > > > > WARNING (devel/go-hashicorp-logutils): make: > > "/usr/ports/devel/go-hashicorp-logutils/../../lang/go/files/bsd.go.mk" line > > 20: Malformed conditional (${ARCH} == "i386") > > WARNING (devel/go-hashicorp-logutils): make: Fatal errors encountered -- > > cannot continue > > > crap, bsd.go.mk is what needs it. > > > > > > > > Is there a reason why > > > > .include "${.CURDIR}/../../lang/go/files/bsd.go.mk" > > > > if preferred over > > .include "${PORTSDIR}/lang/go/files/bsd.go.mk" > > > One good reason is that it eliminates the need for <pre> and <post> > normally. A second reason is that the absolute path fails in some use > cases, relative paths never fail. > > Still make this relative patch, but leave <pre>/<post> with a "#" comment > saying that bsd.go.mk has $ARCH requiring <pre> inclusion first. (In reply to John Marino from comment #3) > 1) you can just past portlint output in comment, we don't need attachment > for that > > 2) when you attach a shar, set mime = text/plain > > 3) You tabbed too much, everything except PORTVERSION > > 4) you did this again: > > X.include <bsd.port.pre.mk> > X.include "${PORTSDIR}/lang/go/files/bsd.go.mk" > X.include <bsd.port.post.mk> > > 5) see this? > > X@dirrmtry %%GO_SRCDIR%%/%%GO_PKGNAME%% > X@dirrmtry %%GO_SRCDIR%%/github.com/hashicorp > X@dirrmtry %%GO_SRCDIR%%/github.com > X@dirrmtry %%GO_SRCDIR%% > X@dirrmtry %%GO_LIBDIR%%/github.com/hashicorp > X@dirrmtry %%GO_LIBDIR%%/github.com > X@dirrmtry %%GO_LIBDIR%% > X@dirrmtry share/go/pkg > X@dirrmtry share/go > > I think only the first one is needed; the rest probably belong to go. And > the first one should be @dirrm, not @dirrmtry. Never use @dirrmtry if > @dirrm is guaranteed to work. > > Please update the shar. -- You are receiving this mail because: You are the assignee for the bug.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-192964-13-HR4Cce5MXU>