From owner-freebsd-current@FreeBSD.ORG Tue Nov 9 02:12:02 2004 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D4B6B16A4CE; Tue, 9 Nov 2004 02:12:02 +0000 (GMT) Received: from daintree.corp.yahoo.com (daintree.corp.yahoo.com [216.145.52.172]) by mx1.FreeBSD.org (Postfix) with ESMTP id B53AC43D41; Tue, 9 Nov 2004 02:12:02 +0000 (GMT) (envelope-from peter@wemm.org) Received: by daintree.corp.yahoo.com (Postfix, from userid 2154) id B039F197A9; Mon, 8 Nov 2004 18:12:02 -0800 (PST) From: Peter Wemm To: freebsd-current@freebsd.org Date: Mon, 8 Nov 2004 18:12:02 -0800 User-Agent: KMail/1.7 References: <25080.1099840843@critter.freebsd.dk> <418E664A.1080709@freebsd.org> In-Reply-To: <418E664A.1080709@freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200411081812.02419.peter@wemm.org> cc: Poul-Henning Kamp cc: Tim Kientzle cc: current@freebsd.org Subject: Re: bsdtar breakage ? X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Nov 2004 02:12:03 -0000 On Sunday 07 November 2004 10:15 am, Tim Kientzle wrote: > Poul-Henning Kamp wrote: > > i386 -current buildworld: > > > > ===> gnu/usr.bin/tar (all) > > /bang/src1/src/gnu/usr.bin/tar/../../../contrib/tar/src/create.c: > > In function `mode_to_chars': > > /bang/src1/src/gnu/usr.bin/tar/../../../contrib/tar/src/create.c:26 > >4: warning: comparison is always false due to limited range of data > > type ===> gnu/usr.bin/tar/doc (all) > > ===> gnu/usr.bin/texinfo (all) > > This is gtar. > > The relevant code here is: > mode_t v; > int negative; > negative = v < 0; > > Since mode_t is unsigned, the comparison > "v < 0" is always false, hence the warning. > > This file hasn't been touched in over two years. > mode_t has been unsigned for at least that long. > > I smell a compiler upgrade. ;-) The funny thing, is that back in '92 or so, the AT&T SVR4 C compiler drove me nuts because of useless warnings like this. I put a lot of effort into getting gcc going on my machines, even though it was slower to build etc. And it seems things are finally coming full circle.. gcc is now just about as picky and uselessly pedantic as the AT&T compiler was back then. Except now it is about 50 times slower. :-] -- Peter Wemm - peter@wemm.org; peter@FreeBSD.org; peter@yahoo-inc.com "All of this is for nothing if we don't go to the stars" - JMS/B5