Date: Tue, 4 Mar 1997 05:47:29 -0500 (EST) From: "Matthew N. Dodd" <winter@jurai.net> To: Bruce Evans <bde@zeta.org.au> Cc: cvs-all@freefall.freebsd.org, CVS-committers@freefall.freebsd.org, cvs-sys@freefall.freebsd.org, gpalmer@freefall.freebsd.org, Gary Palmer <gpalmer@mail.webspan.net> Subject: Re: cvs commit: src/sys/i386/isa clock.c Message-ID: <Pine.BSF.3.95q.970304054446.366B-200000@sasami.jurai.net> In-Reply-To: <199703040958.UAA03727@godzilla.zeta.org.au>
next in thread | previous in thread | raw e-mail | index | archive | help
This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. Send mail to mime@docserver.cac.washington.edu for more info. --0-1147898-857472449=:366 Content-Type: TEXT/PLAIN; charset=US-ASCII On Tue, 4 Mar 1997, Bruce Evans wrote: > >gpalmer 97/03/04 01:24:03 > > > > Modified: sys/i386/isa clock.c > > Log: > > Split the rather long and line-wrapping clock probe messages on boot. > > (2.2?) > > > > Submitted by: Mathew Dood <winter@jurai.net> > > Arrgh. The clock calibration messages were carefully phrased to provide > complete information on one for all paths through the code. Formatting > them on one line is particularly useful with option CLK_CALIBRATION_LOOP > and boot flag -v. Then the calibration is repeated until you hit a key, > and printing one line per call gives a readable tabular format. This was > broken in rev.1.60, fixed in rev.1.71 and is now broken again. Since Gary just crashed I'll point out that its not too difficult to add the proper #ifdef's for CLK_CALIBRATION_LOOP to have your cake and eat it too. Attached is a patch against 1.77 to make everyone happy. Though as Gary and Bruce indicate putting the whole mess behind bootverbose might be the best way to deal with this. I didn't really mind seeing the clock probes, just seeing them wrapped. *grin* Have a good one. /* Matthew N. Dodd | A memory retaining a love you had for life winter@jurai.net | As cruel as it seems nothing ever seems to http://www.jurai.net/~winter | go right - FLA M 3.1:53 */ --0-1147898-857472449=:366 Content-Type: TEXT/PLAIN; charset=US-ASCII; name="clock-diff_v1.77" Content-Transfer-Encoding: BASE64 Content-ID: <Pine.BSF.3.95q.970304054729.366C@sasami.jurai.net> Content-Description: clock-diff_v1.77 KioqIGNsb2NrLmMub2xkCVR1ZSBNYXIgIDQgMDU6MzI6NDMgMTk5Nw0KLS0t IGNsb2NrLmMJVHVlIE1hciAgNCAwNTozOTowNiAxOTk3DQoqKioqKioqKioq KioqKioNCioqKiA1MTUsNTE5ICoqKioNCi0tLSA1MTUsNTIzIC0tLS0NCiAg CWludCBzZWMsIHN0YXJ0X3NlYywgdGltZW91dDsNCiAgDQorICNpZmRlZiBD TEtfQ0FMSUJSQVRJT05fTE9PUA0KICAJcHJpbnRmKCJDYWxpYnJhdGluZyBj bG9jayhzKSByZWxhdGl2ZSB0byBtYzE0NjgxOEEgY2xvY2sgLi4uICIpOw0K KyAjZWxzZQ0KKyAJcHJpbnRmKCJDYWxpYnJhdGluZyBjbG9jayhzKSByZWxh dGl2ZSB0byBtYzE0NjgxOEEgY2xvY2suXG4iKTsNCisgI2VuZGlmDQogIAlp ZiAoIShydGNpbihSVENfU1RBVFVTRCkgJiBSVENTRF9QV1IpKQ0KICAJCWdv dG8gZmFpbDsNCioqKioqKioqKioqKioqKg0KKioqIDU4OCw2MDAgKioqKg0K LS0tIDU5Miw2MTYgLS0tLQ0KICAJaWYgKGNwdV9jbGFzcyA9PSBDUFVDTEFT U181ODYgfHwgY3B1X2NsYXNzID09IENQVUNMQVNTXzY4Nikgew0KICAJCXNl dF9pNTg2X2N0cl9mcmVxKCh1X2ludClyZHRzYygpLCB0b3RfY291bnQpOw0K KyAjaWZkZWYgQ0xLX0NBTElCUkFUSU9OX0xPT1ANCiAgCQlwcmludGYoImk1 ODYgY2xvY2s6ICV1IEh6LCAiLCBpNTg2X2N0cl9mcmVxKTsNCisgI2Vsc2UN CisgCQlwcmludGYoIiAgaTU4NiBjbG9jazogJXUgSHpcbiIsIGk1ODZfY3Ry X2ZyZXEpOw0KKyAjZW5kaWYNCiAgCX0NCiAgI2VuZGlmDQogIA0KKyAjaWZk ZWYgQ0xLX0NBTElCUkFUSU9OX0xPT1ANCiAgCXByaW50ZigiaTgyNTQgY2xv Y2s6ICV1IEh6XG4iLCB0b3RfY291bnQpOw0KKyAjZWxzZQ0KKyAJcHJpbnRm KCIgIGk4MjU0IGNsb2NrOiAldSBIelxuIiwgdG90X2NvdW50KTsNCisgI2Vu ZGlmDQogIAlyZXR1cm4gKHRvdF9jb3VudCk7DQogIA0KICBmYWlsOg0KKyAj aWZkZWYgQ0xLX0NBTElCUkFUSU9OX0xPT1ANCiAgCXByaW50ZigiZmFpbGVk LCB1c2luZyBkZWZhdWx0IGk4MjU0IGNsb2NrIG9mICV1IEh6XG4iLCB0aW1l cl9mcmVxKTsNCisgI2Vsc2UNCisgCXByaW50ZigiICBGYWlsZWQsIHVzaW5n IGRlZmF1bHQgaTgyNTQgY2xvY2sgb2YgJXUgSHpcbiIsIHRpbWVyX2ZyZXEp Ow0KKyAjZW5kaWYNCiAgCXJldHVybiAodGltZXJfZnJlcSk7DQogIH0NCg== --0-1147898-857472449=:366--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.3.95q.970304054446.366B-200000>