From owner-cvs-src@FreeBSD.ORG Wed Apr 21 02:32:21 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 51E5416A4CF for ; Wed, 21 Apr 2004 02:32:21 -0700 (PDT) Received: from ns1.interbgc.com (mail.interbgc.com [217.9.224.3]) by mx1.FreeBSD.org (Postfix) with SMTP id 3BBF343D4C for ; Wed, 21 Apr 2004 02:32:20 -0700 (PDT) (envelope-from nike_d@cytexbg.com) Received: (qmail 92591 invoked from network); 21 Apr 2004 09:32:18 -0000 Received: from nike_d@cytexbg.com by keeper.interbgc.com by uid 1002 with qmail-scanner-1.14 (uvscan: v4.1.60/v4335. spamassassin: 2.63. Clear:SA:0(-4.9/8.0):. Processed in 0.795304 secs); 21 Apr 2004 09:32:18 -0000 X-Spam-Status: No, hits=-4.9 required=8.0 Received: from 213-240-206-214.ddns.cablebg.net (HELO tormentor.totalterror.net) (213.240.206.214) by mail.interbgc.com with SMTP; 21 Apr 2004 09:32:17 -0000 Received: (qmail 93792 invoked by uid 1006); 21 Apr 2004 09:36:31 -0000 Received: from nike_d@cytexbg.com by tormentor.cytexbg.com by uid 1003 with qmail-scanner-1.15 (sweep: 2.14/3.62. Clear:. Processed in 2.841001 secs); 21 Apr 2004 09:36:31 -0000 Received: from unknown (HELO phobos.totalterror.net) (10.0.0.6) by tormentor.totalterror.net with SMTP; 21 Apr 2004 09:36:28 -0000 References: <200404210229.i3L2TSes070256@repoman.freebsd.org> Message-ID: X-Mailer: http://www.courier-mta.org/cone/ From: Niki Denev To: Bill Paul Date: Wed, 21 Apr 2004 12:32:16 +0300 Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=_mimegpg-phobos.totalterror.net-569-1082539936-0001"; micalg=pgp-sha1; protocol="application/pgp-signature" cc: cvs-src@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/if_ndis if_ndis.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Apr 2004 09:32:21 -0000 This is a MIME GnuPG-signed message. If you see this text, it means that your E-mail or Usenet software does not support MIME signed messages. --=_mimegpg-phobos.totalterror.net-569-1082539936-0001 Content-Type: text/plain; format=flowed; charset="US-ASCII" Content-Disposition: inline Content-Transfer-Encoding: 7bit Bill Paul writes: > wpaul 2004/04/20 19:29:28 PDT > > FreeBSD src repository > > Modified files: > sys/dev/if_ndis if_ndis.c > Log: > Fix the problems people have been having with the Intel 2100B Centrino > wireless ever since I added the new spinlock code. Previously, I added > a special ndis_rxeof_serial() function to insure that when we receive > a packet, we never end up calling the MiniportReturnPacket() routine > until after the receive handler has finished. I set things up so that > ndis_rxeof_serial() would only be used for serialized miniports since > they depend on this property. Well, it turns out deserialized miniports > depend on a similar property: you can't let MiniportReturnPacket() be > called from the same context as the receive handler at all. The 2100B > driver happens to use a single spinlock for all of its synchronization, > and it tries to acquire it both while in MiniportHandleInterrupt() and > in MiniportReturnPacket(), so if we call MiniportReturnPacket() from > the MiniportHandleInterrupt() context, we will end up trying to acquire > the spinlock recursively, which you can't do. > > To fix this, I made the ndis_rxeof_serial() handler the default. An > alternate solution would be to make ndis_return_packet() submit > the call to MiniportReturnPacket() to the NDIS task queue thread. > I may do that in the future, after I've tested things a bit more. > > Revision Changes Path > 1.54 +19 -107 src/sys/dev/if_ndis/if_ndis.c > _______________________________________________ > cvs-src@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/cvs-src > To unsubscribe, send any mail to "cvs-src-unsubscribe@freebsd.org" > > doesn't seem to help here.... i got exactly the same lockup after the first packets transmitted/recvd over the wireless as before... the machine is ibm tp X31, with the above mentioned centrino wireless mini pci card, and -current as from 1-2 hours ago. is there any info that i can provide, to help on this? --niki --=_mimegpg-phobos.totalterror.net-569-1082539936-0001 Content-Type: application/pgp-signature Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (FreeBSD) iD8DBQBAhj+hHNAJ/fLbfrkRAjAiAJ91IjPBvkcD7kFrPOsyNrA0XzRe0wCdEJbg 8BNGP+lusBHZYnh+1VYknXk= =aTDZ -----END PGP SIGNATURE----- --=_mimegpg-phobos.totalterror.net-569-1082539936-0001--