From owner-freebsd-ports-bugs@FreeBSD.ORG Sun Nov 13 18:50:23 2005 Return-Path: X-Original-To: freebsd-ports-bugs@hub.freebsd.org Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8F8FA16A41F for ; Sun, 13 Nov 2005 18:50:23 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id A4D6043D55 for ; Sun, 13 Nov 2005 18:50:21 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.3/8.13.3) with ESMTP id jADIoLTb023504 for ; Sun, 13 Nov 2005 18:50:21 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.3/8.13.1/Submit) id jADIoLBw023503; Sun, 13 Nov 2005 18:50:21 GMT (envelope-from gnats) Resent-Date: Sun, 13 Nov 2005 18:50:21 GMT Resent-Message-Id: <200511131850.jADIoLBw023503@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Mats Dufberg Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BA1BD16A41F for ; Sun, 13 Nov 2005 18:48:45 +0000 (GMT) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [216.136.204.117]) by mx1.FreeBSD.org (Postfix) with ESMTP id 697E043D46 for ; Sun, 13 Nov 2005 18:48:45 +0000 (GMT) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.13.1/8.13.1) with ESMTP id jADImjDX042104 for ; Sun, 13 Nov 2005 18:48:45 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.13.1/8.13.1/Submit) id jADImjK4042100; Sun, 13 Nov 2005 18:48:45 GMT (envelope-from nobody) Message-Id: <200511131848.jADImjK4042100@www.freebsd.org> Date: Sun, 13 Nov 2005 18:48:45 GMT From: Mats Dufberg To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-2.3 Cc: Subject: ports/88941: Suggested updates of mail/cclient Makefile X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 13 Nov 2005 18:50:23 -0000 >Number: 88941 >Category: ports >Synopsis: Suggested updates of mail/cclient Makefile >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Sun Nov 13 18:50:21 GMT 2005 >Closed-Date: >Last-Modified: >Originator: Mats Dufberg >Release: N/A >Organization: private >Environment: N/A >Description: 1. By default the cclient uses the old-fashioned unix type of mail folder format. Included in cclient there is an alternative, MBX format, which is recommended by the Pine development team as a more effecient format, which it really is. The mail/cclient port does not offer any convinient way of using that as the default folder format. I suggest that there is an options to patch the source to get MBX as the default mailbox format. 2. The mail/cclient port has serveral options. Today they are handled in the old-fashioned way which requires that the user includes those as options on the command line when upgrading, which makes upgrades more cumbersome. I suggets that the mail/cclient port uses settings with OPTIONS to achieve a simpler handling. >How-To-Repeat: N/A >Fix: The patch below will update the mail/cclient Makefile to support the two suggested changes. I have locally tested the patch, and found no problems with it. --- Makefile.orig Sat Oct 8 05:14:27 2005 +++ Makefile Sun Nov 13 13:40:29 2005 @@ -20,6 +20,13 @@ MAINTAINER= anders@FreeBSD.org COMMENT= Mark Crispin's C-client mail access routines +OPTIONS= SSL "Compile with SSL support" on \ + SSL_AND_PLAINTEXT "Accept plain text passwords with SSL" off \ + IPV6 "Support IPv6" on \ + MBX_DEFAULT "Use MBX as default mailbox format" off + +.include + INSTALLS_SHLIB= yes ALL_TARGET= bsf .if defined(WITHOUT_SSL) @@ -42,8 +49,6 @@ MAKE_ENV= SHLIBNAME=${SHLIBNAME} SHLIBBASE=${SHLIBBASE} PLIST_SUB= SHLIBNAME=${SHLIBNAME} SHLIBBASE=${SHLIBBASE} -.include - .if ${PORTOBJFORMAT} == "aout" SHLIBNAME= lib${SHLIBBASE}.so.${SHLIBMAJ}.0 .endif @@ -58,6 +63,16 @@ @${REINPLACE_CMD} -e "s|^IP=4|IP=6|" ${WRKSRC}/Makefile \ ${WRKSRC}/src/osdep/unix/Makefile .endif +# Do this here because other patches also modifies this file +.if defined(WITH_MBX_DEFAULT) + @${CP} ${WRKSRC}/src/osdep/unix/Makefile \ + ${WRKSRC}/src/osdep/unix/Makefile.presed2 + @${SED} -e 's:^CREATEPROTO=unixproto:CREATEPROTO=mbxproto:' \ + ${WRKSRC}/src/osdep/unix/Makefile.presed2 > \ + ${WRKSRC}/src/osdep/unix/Makefile +.endif +# + post-configure: @${ECHO_MSG} ">> The c-client shared library will be named ${SHLIBNAME}" >Release-Note: >Audit-Trail: >Unformatted: