From owner-freebsd-pkg@freebsd.org Sat Aug 12 17:13:38 2017 Return-Path: Delivered-To: freebsd-pkg@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id DFD9FD94795 for ; Sat, 12 Aug 2017 17:13:38 +0000 (UTC) (envelope-from pmc@citylink.dinoex.sub.org) Received: from mailman.ysv.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id C14F669343 for ; Sat, 12 Aug 2017 17:13:38 +0000 (UTC) (envelope-from pmc@citylink.dinoex.sub.org) Received: by mailman.ysv.freebsd.org (Postfix) id C09A6D94794; Sat, 12 Aug 2017 17:13:38 +0000 (UTC) Delivered-To: pkg@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C0340D94793 for ; Sat, 12 Aug 2017 17:13:38 +0000 (UTC) (envelope-from pmc@citylink.dinoex.sub.org) Received: from uucp.dinoex.sub.de (uucp.dinoex.sub.de [IPv6:2001:1440:5001:1::2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "uucp.dinoex.sub.de", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4CBB269342 for ; Sat, 12 Aug 2017 17:13:38 +0000 (UTC) (envelope-from pmc@citylink.dinoex.sub.org) Received: from uucp.dinoex.sub.de (uucp.dinoex.sub.de [194.45.71.2]) by uucp.dinoex.sub.de (8.15.2/8.14.9) with ESMTPS id v7CHD4ac054735 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO) for ; Sat, 12 Aug 2017 19:13:04 +0200 (CEST) (envelope-from pmc@citylink.dinoex.sub.org) X-MDaemon-Deliver-To: Received: from citylink.dinoex.sub.org (uucp@localhost) by uucp.dinoex.sub.de (8.15.2/8.14.9/Submit) with UUCP id v7CHD46X054734 for pkg@FreeBSD.org; Sat, 12 Aug 2017 19:13:04 +0200 (CEST) (envelope-from pmc@citylink.dinoex.sub.org) Received: from gate.oper.dinoex.org (gate-e [192.168.98.2]) by citylink.dinoex.sub.de (8.15.2/8.15.2) with ESMTP id v7CGRcgF008767 for ; Sat, 12 Aug 2017 18:27:38 +0200 (CEST) (envelope-from pmc@citylink.dinoex.sub.org) Received: from disp.oper.dinoex.org (disp-e.oper.dinoex.org [192.168.97.18]) by gate.oper.dinoex.org (8.15.2/8.15.2) with ESMTP id v7CGQ8R9008514 for ; Sat, 12 Aug 2017 18:26:08 +0200 (CEST) (envelope-from pmc@citylink.dinoex.sub.org) Newsgroups: m2n.fbsd.stable X-Mozilla-News-Host: news://localhost:119 To: pkg@FreeBSD.org From: Peter Subject: errors from port make (analyzed: bug in pkg) Message-ID: Date: Sat, 12 Aug 2017 18:25:24 +0200 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:51.0) Gecko/20100101 Firefox/51.0 SeaMonkey/2.48 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Milter: Spamilter (Reciever: uucp.dinoex.sub.de; Sender-ip: 194.45.71.2; Sender-helo: uucp.dinoex.sub.de; ) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (uucp.dinoex.sub.de [194.45.71.2]); Sat, 12 Aug 2017 19:13:05 +0200 (CEST) X-BeenThere: freebsd-pkg@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Binary package management and package tools discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 12 Aug 2017 17:13:39 -0000 For a long time already, I get these strange messages whenever building a port: pkg: Bad argument on pkg_set 2143284626 Today I looked into it, and found it is easily reproducible: # pkg audit whatever pkg: Bad argument on pkg_set 2143284618 0 problem(s) in the installed packages found. # Looking closer, I found this offending call in src/audit.c:exec_audit(): pkg_set(pkg, PKG_UNIQUEID, name); This goes into libpkg/pkg.c:pkg_vset(), but there nobody is interested in an UNIQUEID parameter, so that the parameter does not get fetched from the va_list. It does not do any harm, but it is ugly. Please fix.