From owner-svn-src-all@FreeBSD.ORG Tue Dec 20 09:22:00 2011 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6D560106564A; Tue, 20 Dec 2011 09:22:00 +0000 (UTC) (envelope-from yanegomi@gmail.com) Received: from mail-tul01m020-f182.google.com (mail-tul01m020-f182.google.com [209.85.214.182]) by mx1.freebsd.org (Postfix) with ESMTP id EF8908FC0C; Tue, 20 Dec 2011 09:21:59 +0000 (UTC) Received: by obbwd18 with SMTP id wd18so3496262obb.13 for ; Tue, 20 Dec 2011 01:21:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=QMSiY1lMNICsZqkRDecdV2hRW6qRwypEZtGI1MAkJLo=; b=dlJhp4SUxTVf3Sy6s/c4uF0mp1rsrHF+4dI+lyQIa386R3rVYRutsdbaHDxqUrFMDm ZGZNlIQG7c4eN4NHo3YiLNJuBkZDoX+xCe+wWZJsuOOHgO50H5mTDvVTh/0vTmFPbWFR Whgw0d0XVOxb2XsOAqsIckOaduSv0KJ8A52pA= MIME-Version: 1.0 Received: by 10.182.115.5 with SMTP id jk5mr982114obb.6.1324372919570; Tue, 20 Dec 2011 01:21:59 -0800 (PST) Received: by 10.182.62.227 with HTTP; Tue, 20 Dec 2011 01:21:59 -0800 (PST) In-Reply-To: <20111220171740.X1005@besplex.bde.org> References: <201111291946.pATJkHMs064094@svn.freebsd.org> <4ED544E1.3050307@t-hosting.hu> <4ED545A9.8000304@FreeBSD.org> <0CAA5754-4FAC-4B87-92B7-439B109473C0@bsdimp.com> <20111220171740.X1005@besplex.bde.org> Date: Tue, 20 Dec 2011 01:21:59 -0800 Message-ID: From: Garrett Cooper To: Bruce Evans Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: Doug Barton , Max Khon , svn-src-all@freebsd.org, src-committers@freebsd.org, =?ISO-8859-1?B?R+Fib3IgS/Z2ZXNk4W4=?= , svn-src-head@freebsd.org, Warner Losh Subject: Re: svn commit: r228143 - in head: . share/mk tools/build/options X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Dec 2011 09:22:00 -0000 On Mon, Dec 19, 2011 at 10:20 PM, Bruce Evans wrote: > On Mon, 19 Dec 2011, Warner Losh wrote: > >> On Nov 29, 2011, at 1:53 PM, Garrett Cooper wrote: >> >>> 2011/11/29 Doug Barton : >>>> >>>> On 11/29/2011 12:47, G=E1bor K=F6vesd=E1n wrote: >>>>> >>>>> On 2011.11.29. 20:46, Max Khon wrote: >>>>>> >>>>>> Log: >>>>>> =A0 Turn off profiled libs build by default. >>>>>> =A0 Can be enabled back using WITH_PROFILE=3Dyes in /etc/src.conf >>>>> >>>>> I think it was useful. Profiling is useful for developing any piece o= f >>>>> software that builds on libc or other common libs, even for software >>>>> that is not directly related to FreeBSD. I think it should be reverte= d. >>>> >>>> >>>> Since we ask users to read -current, it would be useful if our >>>> developers did too. :) >>>> >>>> As Max pointed out in his message about this, the profiled libs are on= ly >>>> really useful to a tiny percentage of developers. If you need them, >>>> twist the knob. Building them should be off by default. >>> >>> >>> +1. The needs of the many outweigh the needs of the few. As suggested >>> elsewhere, I think it would also be a good idea to enable it in >>> tinderbox builds. >> >> >> -1. =A0The needs of the many? =A0Please. =A0Let's break a useful feature= because >> some people don't understand it and are impatient? =A0That's lame. > > Don't be silly. =A0Building profiled libraries takes as much as 1 minute. > Many would not want to wait that long (if they noticed how long it takes)= . > This is not 1994 when building of profiling libraries was left in because > it only took an extra hour or or so. The assumption (that isn't clearly stated) is that I am building things on suped up x86 hardware, not arm CPUs, Intel Atoms, etc. On those platforms building superfluous things still do matter (in particular because cross-building some things still isn't doable 100% of the time, but also because flash, some platter media, etc is slow). But I suppose I digress... Thanks, -Garrett