From owner-svn-ports-all@freebsd.org Sun May 6 15:45:39 2018 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CD7BFFBDA63; Sun, 6 May 2018 15:45:39 +0000 (UTC) (envelope-from adamw@adamw.org) Received: from apnoea.adamw.org (apnoea.adamw.org [104.225.5.94]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "apnoea.adamw.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 6E7E6762FE; Sun, 6 May 2018 15:45:38 +0000 (UTC) (envelope-from adamw@adamw.org) Received: by apnoea.adamw.org (OpenSMTPD) with ESMTPSA id d590bc7a TLS version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO; Sun, 6 May 2018 09:45:36 -0600 (MDT) Content-Type: text/plain; charset=utf-8; delsp=yes; format=flowed Mime-Version: 1.0 (Mac OS X Mail 11.3 \(3445.6.18\)) Subject: Re: svn commit: r469188 - head/ports-mgmt/pkg_replace From: Adam Weinberger In-Reply-To: <20180506150441.52w3lodurubkz2lb@ivaldir.net> Date: Sun, 6 May 2018 09:45:34 -0600 Cc: Alexey Dokuchaev , Koichiro Iwao , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Content-Transfer-Encoding: 8bit Message-Id: <612D8486-6A77-4CBD-8276-AFE53DF2AC92@adamw.org> References: <201805061015.w46AF3HQ070595@repo.freebsd.org> <20180506102749.GA58637@FreeBSD.org> <20180506150441.52w3lodurubkz2lb@ivaldir.net> To: Baptiste Daroussin X-Mailer: Apple Mail (2.3445.6.18) X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 06 May 2018 15:45:40 -0000 > On 6 May, 2018, at 09:04, Baptiste Daroussin wrote: > > On Sun, May 06, 2018 at 08:41:36AM -0600, Adam Weinberger wrote: >>> On 6 May, 2018, at 04:27, Alexey Dokuchaev wrote: >>> >>> On Sun, May 06, 2018 at 10:15:03AM +0000, Koichiro Iwao wrote: >>>> New Revision: 469188 >>>> URL: https://svnweb.freebsd.org/changeset/ports/469188 >>>> >>>> Log: >>>> ports-mgmt/pkg_replace: Update to 20180424 >>>> >>>> - Cleanup code >>>> - Speed up and strictly check package's dependencies >>>> - While here, pet portlint by using pkg-plist instead of PLIST_FILES >>> >>> Could you explain what did you achieve by moving three-line PLIST_FILES >>> into pkg-plist? How can "pet portlint" be a reason for a change while >>> we generally encourage converting <6-line pkg-plist's into PLIST_FILES? >>> >>> ./danfe >>> >>>> - >>>> -PLIST_FILES= sbin/pkg_replace \ >>>> - man/man1/pkg_replace.1.gz \ >>>> - "@sample %%ETCDIR%%/pkg_replace.conf.sample" >>> >>> Correct PLIST_FILES should read: >>> >>> PLIST_FILES= sbin/pkg_replace \ >>> man/man1/pkg_replace.1.gz \ >>> @sample\ etc/pkg_replace/pkg_replace.conf.sample >>> >>> ./danfe >> >> Sorry, Alexey, but portlint was right here. @sample and other macros >> should >> *never* appear in PLIST_FILES. Even if the port installs only a single >> file, >> if it’s a @sample, it goes in pkg-plist. > Same why :) > > Alexey is wrong imho about the '\' the quotes where fine, but he is right > about > the replacement of the %%ETCDIR%%. > > I don't understand why keywords should be forbiddent in PLIST_FILES macros? > > The framework itself uses macros in PLIST_FILES Oh, my. I thought this was a thing! I was so certain that this was (at least at one time) policy. Did this change, or did I just invent the whole thing? # Adam — Adam Weinberger adamw@adamw.org http://www.adamw.org