From owner-freebsd-current@FreeBSD.ORG Sat Apr 18 17:03:49 2015 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 730DA828 for ; Sat, 18 Apr 2015 17:03:49 +0000 (UTC) Received: from mail-wi0-f181.google.com (mail-wi0-f181.google.com [209.85.212.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 104CD80C for ; Sat, 18 Apr 2015 17:03:48 +0000 (UTC) Received: by widdi4 with SMTP id di4so54209078wid.0 for ; Sat, 18 Apr 2015 10:03:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :subject:references:in-reply-to:content-type :content-transfer-encoding; bh=ISCUD8MyUX7Un5S1LUYSq25n+oIbS1tu898+g1ErLTE=; b=CpYaWOKt2OzG1boJE6EFTj5Fc75T8pTnshtru4wry0AfKJk6hhi6FB/CWrUK9mj3c2 OINHWSKmW0BT+W39+XBVDQxjuityFAc3Qbg4TfLofnwGvaq49Y4zsVeZ0SnnQO1rCY2Q fb8GhQj/PojSZlpF7ehrR3wE+1RzWbZJjWO1rVcIFDK2VEvsePhoYCHbeF8I2Wvgt8G4 EQPQUzHK2qa/0XZaT5iJqmhIZ8JROPkIXWKAclnGSxAqMPnwd/gPUw/tDeHA1yM7zC9s hnyu8R+9E2frLjwldVWZqH01ht6z7ftEtK/wnPEF8qpViljoC/DrpPePpJNho2tkPz/B YO1Q== X-Gm-Message-State: ALoCoQlm5XY08+eWyznn9Tp9bQ3b5xNxcUxFOJkilhNNaBr9vWMiOZ/spfvGPIGtyNX4tzjN61ik X-Received: by 10.194.94.164 with SMTP id dd4mr16308848wjb.56.1429376620103; Sat, 18 Apr 2015 10:03:40 -0700 (PDT) Received: from [10.10.1.68] (82-69-141-170.dsl.in-addr.zen.co.uk. [82.69.141.170]) by mx.google.com with ESMTPSA id ge8sm19643171wjc.32.2015.04.18.10.03.38 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 18 Apr 2015 10:03:39 -0700 (PDT) Message-ID: <55328E6E.2060807@multiplay.co.uk> Date: Sat, 18 Apr 2015 18:03:42 +0100 From: Steven Hartland User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: freebsd-current@freebsd.org Subject: Re: Fix for r281680 -- broke i386 world References: <20150418151702.GB36163@albert.catwhisker.org> <20150418153459.GX2390@kib.kiev.ua> <20150418163057.GD36163@albert.catwhisker.org> In-Reply-To: <20150418163057.GD36163@albert.catwhisker.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 18 Apr 2015 17:03:49 -0000 On 18/04/2015 17:30, David Wolfskill wrote: > On Sat, Apr 18, 2015 at 06:34:59PM +0300, Konstantin Belousov wrote: >> ... >>> - printf("LE_STATUS: %d %d %lx\n", e, rp.status, rp.le_status); >>> + printf("LE_STATUS: %d %d %jx\n", e, rp.status, rp.le_status); >>> >>> return 0; >>> } >> The j modificator specifies that the type of the argument is (u)intmax_t. >> It is only a coincidense that uint64_t is max integer type, the arg should >> be casted to uintmax_t. >> >> Could you, please, update and test ? >> .... > Thank you for the correction; the attached patch survives both i386 & > amd64 "make buildworld" ... and comes a bit closer to the above > specification. (I had tried "(uintmax_t)rp.le_features" at first; that > failed (at least on amd64), with: > > --- usr.sbin.all__D --- > /usr/src/usr.sbin/bluetooth/hccontrol/le.c:236:15: error: expected ')' > (uintmax_t)rp.le_features); > ^ > /usr/src/usr.sbin/bluetooth/hccontrol/le.c:235:8: note: to match this '(' > printf("LOCAL SUPPORTED: %d %d %ju\n", e, rp.status, > ^ > /usr/src/usr.sbin/bluetooth/hccontrol/le.c:253:60: error: expected ')' > printf("LE_STATUS: %d %d %jx\n", e, rp.status, (uintmax_t)rp.le_status); > ^ > /usr/src/usr.sbin/bluetooth/hccontrol/le.c:253:8: note: to match this '(' > printf("LE_STATUS: %d %d %jx\n", e, rp.status, (uintmax_t)rp.le_status); > ^ > 2 errors generated. > > So I took a bit of evasive action.) > The errors not very good, but I'm guessing your missing #include for uintmax_t where as u_int64_t is from sys/types.h iirc. Regards Steve