From nobody Wed Dec 31 03:06:38 2025 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4dgvxY6z34z6Lx0J for ; Wed, 31 Dec 2025 03:06:41 +0000 (UTC) (envelope-from agh@riseup.net) Received: from mx1.riseup.net (mx1.riseup.net [198.252.153.129]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mx1.riseup.net", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4dgvxY4XGlz3GNb; Wed, 31 Dec 2025 03:06:41 +0000 (UTC) (envelope-from agh@riseup.net) Authentication-Results: mx1.freebsd.org; none Received: from fews04-sea.riseup.net (fews04-sea-pn.riseup.net [10.0.1.154]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx1.riseup.net (Postfix) with ESMTPS id 4dgvxW6TPtzDqpP; Wed, 31 Dec 2025 03:06:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=riseup.net; s=squak; t=1767150400; bh=SfXBbXEYNr0v+BkMfxGrtEcLh4Tj4qiDT3yxOizezkM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=fSgeuJcbun8HicgW4p1CBBV4XlrWe4cUgyeqG7BZYNMOPvSFRWSE62QA2pDAiB/8m iUCae8nChMO63VxaPir3yCZL4Z9cNeW+i3tN0/iXayfTo3GyAMXmvrlnrMyuFvqUOP YkJhx1swf3bXqXVbft2QUGOOHZB8ptq0gTH2RrVc= X-Riseup-User-ID: 0ABB15BF6D4C22001E1DE722236232FA463B8FFAAB8E0F49B49D2DE6DD61FCA3 Received: from [127.0.0.1] (localhost [127.0.0.1]) by fews04-sea.riseup.net (Postfix) with ESMTPSA id 4dgvxW160pz5yQ6; Wed, 31 Dec 2025 03:06:39 +0000 (UTC) List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@FreeBSD.org MIME-Version: 1.0 Date: Wed, 31 Dec 2025 03:06:38 +0000 From: Alastair Hogge To: Gleb Smirnoff Cc: "Dan Mahoney (ports)" , FreeBSD User , Ronald Klop , FreeBSD CURRENT Subject: Re: CURRENT: kernel panic in IPFW while stopping jails In-Reply-To: References: Message-ID: <6ed6434fce515fb9dab694bb649da95b@riseup.net> Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Queue-Id: 4dgvxY4XGlz3GNb On 2025-12-31 01:02, Gleb Smirnoff wrote: > Hi, Hi Gleb, > I have found the problem, thanks to Alastair for a core file. > > The problem affects rules with automatic rule numbers and logging. > > The attached patch should fix the problem, but it is not a final version. Is there a special patch incantation I should be aware of? I have tried the patch against both 8e951583936980909d34a6104ace781541fb62b1[1], and 4fecc8e3fe9408621429777b1028c9afb83c3925[2], and observed the following: $ patch -C -E --posix < /exports/fafnir/var/tmp/ipfw-log.diff Hmm... Looks like a unified diff to me... The text leading up to this was: -------------------------- |diff --git a/sys/netpfil/ipfw/ip_fw_bpf.c b/sys/netpfil/ipfw/ip_fw_bpf.c |index d9897f700d57..2a9f8d889f43 100644 |--- a/sys/netpfil/ipfw/ip_fw_bpf.c |+++ b/sys/netpfil/ipfw/ip_fw_bpf.c -------------------------- Patching file sys/netpfil/ipfw/ip_fw_bpf.c using Plan A... Hunk #1 failed at 81. Hunk #2 failed at 108. 2 out of 2 hunks failed while patching sys/netpfil/ipfw/ip_fw_bpf.c Hmm... The next patch looks like a unified diff to me... The text leading up to this was: -------------------------- |diff --git a/sys/netpfil/ipfw/ip_fw_sockopt.c b/sys/netpfil/ipfw/ip_fw_sockopt.c |index a91fb2e84da9..38e134a21141 100644 |--- a/sys/netpfil/ipfw/ip_fw_sockopt.c |+++ b/sys/netpfil/ipfw/ip_fw_sockopt.c -------------------------- Patching file sys/netpfil/ipfw/ip_fw_sockopt.c using Plan A... Hunk #1 failed at 210. Hunk #2 failed at 552. Hunk #3 failed at 2515. 3 out of 3 hunks failed while patching sys/netpfil/ipfw/ip_fw_sockopt.c done > Dan & Alastair, if any of you can confirm that the patch heals your setup - I > will appreciate. I manually patched in your work, and was able to boot a sync'd -CURRENT[2], with logging counters re-enabled, there has been no panics for ~20 minutes now. > Again very sorry for this breakage. Thanks for your prompt response, and efforts during the Holiday period. Happy Holidays, and good health to you and your friends/families. 1: https://codeberg.org/FreeBSD/freebsd-src/commit/8e951583936980909d34a6104ace781541fb62b1 2: https://codeberg.org/FreeBSD/freebsd-src/commit/4fecc8e3fe9408621429777b1028c9afb83c3925