Date: Wed, 17 Apr 2024 20:35:15 +0000 From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 278418] GEOM GPT partition table handling class defaults filling inconsistency. Message-ID: <bug-278418-227@https.bugs.freebsd.org/bugzilla/>
index | next in thread | raw e-mail
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=278418 Bug ID: 278418 Summary: GEOM GPT partition table handling class defaults filling inconsistency. Product: Base System Version: Unspecified Hardware: Any OS: Any Status: New Severity: Affects Only Me Priority: --- Component: kern Assignee: bugs@FreeBSD.org Reporter: andrew@rinet.ru I'm neither GEOM hacker nor GPT expert, but as I can understand English language on one side and C programming language on another, comment in g_gpt_set_defaults() above alignment handling code and if() condition contradict with each other. === /* * Don't force alignment of any kind whatsoever on resize, restore or ~~~~~~~~~~~~~~~~~~~~~ ~~ * recover. resize doesn't go through this path, recover has a NULL gpp ~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~ * and restore has flags == restore (maybe with an appended 'C' to * commit the operation). For these operations, we have to trust the * user knows what they are doing. . . . . . . . . */ === === if (gpp == NULL || ... . . . alignment handling code . . . === I think that condition should contain "gpp != NULL", shouldn't it? -- You are receiving this mail because: You are the assignee for the bug.home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-278418-227>