From owner-freebsd-bugs@FreeBSD.ORG Mon May 9 15:30:07 2005 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9988516A4F4 for ; Mon, 9 May 2005 15:30:07 +0000 (GMT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7534243D3F for ; Mon, 9 May 2005 15:30:07 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.3/8.13.3) with ESMTP id j49FU74b039735 for ; Mon, 9 May 2005 15:30:07 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.3/8.13.1/Submit) id j49FU6tC039726; Mon, 9 May 2005 15:30:06 GMT (envelope-from gnats) Date: Mon, 9 May 2005 15:30:06 GMT Message-Id: <200505091530.j49FU6tC039726@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org From: Rostislav Krasny Subject: Re: bin/80732: [PATCH]: getty(8) and telnetd(8) ignore the 'if' option of gettytab(5) and don't print initial message from a file (by default /etc/issue) before the login prompt X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Rostislav Krasny List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 May 2005 15:30:07 -0000 The following reply was made to PR bin/80732; it has been noted by GNATS. From: Rostislav Krasny To: bug-followup@FreeBSD.org Cc: Subject: Re: bin/80732: [PATCH]: getty(8) and telnetd(8) ignore the 'if' option of gettytab(5) and don't print initial message from a file (by default /etc/issue) before the login prompt Date: Mon, 9 May 2005 17:28:12 +0200 ------=_Part_2638_24198527.1115652492256 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline This is an updated version of the telnetd(8) patch. It solves two more prob= lems: 1. if a lexically cultivated or original contents of /etc/issue file or 'im' parameter of /etc/gettytab is longer than BUFSIZ - 1 (1023 bytes) then telnetd will crash 2. if the last byte of the /etc/issue file or the 'im' parameter of /etc/gettytab is a '%' char then telnetd will jump over the null-terminator of the string. The patch is attached to this email. P.S. Original patch of getty(8) (of the main.c file) is still good and desirable. ------=_Part_2638_24198527.1115652492256 Content-Type: text/plain; name="telnetd.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="telnetd.patch" ZGlmZiAtdXIgdGVsbmV0ZC5vcmlnL2V4dC5oIC91c3Ivc3JjL2NvbnRyaWIvdGVsbmV0L3RlbG5l dGQvZXh0LmgKLS0tIHRlbG5ldGQub3JpZy9leHQuaAlNb24gTWF5ICA5IDE2OjQxOjQ1IDIwMDUK KysrIC91c3Ivc3JjL2NvbnRyaWIvdGVsbmV0L3RlbG5ldGQvZXh0LmgJTW9uIE1heSAgOSAxNzow MTozMCAyMDA1CkBAIC0xMTIsOCArMTEyLDcgQEAKICNlbmRpZgogCXByb2Nlc3Nfc2xjKHVuc2ln bmVkIGNoYXIsIHVuc2lnbmVkIGNoYXIsIGNjX3QpLAogCXB0eWZsdXNoKHZvaWQpLAotCXB1dGNo cihpbnQpLAotCXB1dGYoY2hhciAqLCBjaGFyICopLAorCXB1dGYoY2hhciAqLCBjaGFyICosIHNp emVfdCksCiAJcmVjdl9heXQodm9pZCksCiAJc2VuZF9kbyhpbnQsIGludCksCiAJc2VuZF9kb250 KGludCwgaW50KSwKZGlmZiAtdXIgdGVsbmV0ZC5vcmlnL3RlbG5ldGQuYyAvdXNyL3NyYy9jb250 cmliL3RlbG5ldC90ZWxuZXRkL3RlbG5ldGQuYwotLS0gdGVsbmV0ZC5vcmlnL3RlbG5ldGQuYwlN b24gTWF5ICA5IDE2OjQyOjEzIDIwMDUKKysrIC91c3Ivc3JjL2NvbnRyaWIvdGVsbmV0L3RlbG5l dGQvdGVsbmV0ZC5jCU1vbiBNYXkgIDkgMTc6MDE6NDUgMjAwNQpAQCAtNDIsNyArNDIsNiBAQAog I2luY2x1ZGUgInRlbG5ldGQuaCIKICNpbmNsdWRlICJwYXRobmFtZXMuaCIKIAotI2luY2x1ZGUg PHN5cy9tbWFuLmg+CiAjaW5jbHVkZSA8ZXJyLmg+CiAjaW5jbHVkZSA8bGlidXRpbC5oPgogI2lu Y2x1ZGUgPHBhdGhzLmg+CkBAIC03NDAsNiArNzM5LDcgQEAKIAljaGFyICpIRTsKIAljaGFyICpI TjsKIAljaGFyICpJTTsKKwljaGFyICpJRjsKIAlpbnQgbmZkOwogCiAJLyoKQEAgLTkwMCwyMiAr OTAwLDQwIEBACiAJICovCiAKIAlpZiAoZ2V0ZW50KGRlZmVudCwgImRlZmF1bHQiKSA9PSAxKSB7 Ci0JCWNoYXIgKmNwPWRlZnN0cnM7CisJCWNoYXIgKmNwID0gZGVmc3RyczsKIAogCQlIRSA9IEdl dHN0cigiaGUiLCAmY3ApOwogCQlITiA9IEdldHN0cigiaG4iLCAmY3ApOwotCQlJTSA9IEdldHN0 cigiaW0iLCAmY3ApOwotCQlpZiAoSE4gJiYgKkhOKQorCQlJRiA9IEdldHN0cigiaWYiLCAmY3Ap OworCQlpZiAoSE4gIT0gTlVMTCAmJiAqSE4gIT0gMCkKIAkJCSh2b2lkKSBzdHJsY3B5KGhvc3Rf bmFtZSwgSE4sIHNpemVvZihob3N0X25hbWUpKTsKLQkJaWYgKElNID09IDApCi0JCQlJTSA9IHN0 cmR1cCgiIik7CisJCWlmIChJRiAhPSBOVUxMKSB7CisJCQlpbnQgaWZfZmQ7CisKKwkJCWlmICgo aWZfZmQgPSBvcGVuKElGLCBPX1JET05MWSkpICE9IC0xKSB7CisJCQkJc3RydWN0IHN0YXQgaWZf ZnN0OworCisJCQkJZnN0YXQoaWZfZmQsICZpZl9mc3QpOworCQkJCUlNID0gbWFsbG9jKGlmX2Zz dC5zdF9zaXplICsgMSk7CisJCQkJcmVhZChpZl9mZCwgSU0sIGlmX2ZzdC5zdF9zaXplKTsKKwkJ CQlJTVtpZl9mc3Quc3Rfc2l6ZV0gPSAwOworCQkJCWNsb3NlKGlmX2ZkKTsKKwkJCX0gZWxzZSB7 CisJCQkJSUYgPSBOVUxMOworCQkJfQorCQl9CisJCWlmIChJRiA9PSBOVUxMKSB7CisJCQlJTSA9 IEdldHN0cigiaW0iLCAmY3ApOworCQkJaWYgKElNID09IE5VTEwpCisJCQkJSU0gPSBzdHJkdXAo IiIpOworCQl9CiAJfSBlbHNlIHsKIAkJSU0gPSBzdHJkdXAoREVGQVVMVF9JTSk7Ci0JCUhFID0g MDsKKwkJSEUgPSBOVUxMOwogCX0KIAllZGl0aG9zdChIRSwgaG9zdF9uYW1lKTsKIAlpZiAoaG9z dGluZm8gJiYgKklNKQotCQlwdXRmKElNLCBwdHlpYnVmMik7CisJCXB1dGYoSU0sIHB0eWlidWYy LCBCVUZTSVopOwogCiAJaWYgKHBjYykKIAkJKHZvaWQpIHN0cm5jYXQocHR5aWJ1ZjIsIHB0eWlw LCBwY2MrMSk7CmRpZmYgLXVyIHRlbG5ldGQub3JpZy91dGlsaXR5LmMgL3Vzci9zcmMvY29udHJp Yi90ZWxuZXQvdGVsbmV0ZC91dGlsaXR5LmMKLS0tIHRlbG5ldGQub3JpZy91dGlsaXR5LmMJTW9u IE1heSAgOSAxNjo0MjoyMiAyMDA1CisrKyAvdXNyL3NyYy9jb250cmliL3RlbG5ldC90ZWxuZXRk L3V0aWxpdHkuYwlNb24gTWF5ICA5IDE3OjAxOjM4IDIwMDUKQEAgLTY2LDExICs2Niw5IEBACiAg KiBhbHNvIGZsdXNoIHRoZSBwdHkgaW5wdXQgYnVmZmVyIChieSBkcm9wcGluZyBpdHMgZGF0YSkg aWYgaXQgYmVjb21lcwogICogdG9vIGZ1bGwuCiAgKi8KLQotICAgIHZvaWQKLXR0bG9vcCgpCit2 b2lkCit0dGxvb3Aodm9pZCkKIHsKLQogICAgIERJQUcoVERfUkVQT1JULCBvdXRwdXRfZGF0YSgi dGQ6IHR0bG9vcFxyXG4iKSk7CiAgICAgaWYgKG5mcm9udHAgLSBuYmFja3AgPiAwKSB7CiAJbmV0 Zmx1c2goKTsKQEAgLTM5MywyMiArMzkxLDYgQEAKIAllZGl0ZWRob3N0W3NpemVvZiBlZGl0ZWRo b3N0IC0gMV0gPSAnXDAnOwogfQogCi1zdGF0aWMgY2hhciAqcHV0bG9jYXRpb247Ci0KLXN0YXRp YyB2b2lkCi1wdXRzdHIoY29uc3QgY2hhciAqcykKLXsKLQotCXdoaWxlICgqcykKLQkJcHV0Y2hy KCpzKyspOwotfQotCi12b2lkCi1wdXRjaHIoaW50IGNjKQotewotCSpwdXRsb2NhdGlvbisrID0g Y2M7Ci19Ci0KICNpZmRlZiBfX0ZyZWVCU0RfXwogc3RhdGljIGNoYXIgZm10c3RyW10gPSB7ICIl KyIgfTsKICNlbHNlCkBAIC00MTYsMTEgKzM5OCwxMiBAQAogI2VuZGlmCiAKIHZvaWQKLXB1dGYo Y2hhciAqY3AsIGNoYXIgKndoZXJlKQorcHV0ZihjaGFyICpjcCwgY2hhciAqd2hlcmUsIHNpemVf dCB3aGVyZV9zaXplKQogewogCWNoYXIgKnNsYXNoOwogCXRpbWVfdCB0OwogCWNoYXIgZGJbMTAw XTsKKwljaGFyIGNoX3N0clsyXSA9IHswLCAwfTsKICNpZmRlZiBfX0ZyZWVCU0RfXwogCXN0YXRp YyBzdHJ1Y3QgdXRzbmFtZSBrZXJuaW5mbzsKIApAQCAtNDI4LDE5ICs0MTEsMTMgQEAKIAkJdW5h bWUoJmtlcm5pbmZvKTsKICNlbmRpZgogCi0JcHV0bG9jYXRpb24gPSB3aGVyZTsKLQotCXdoaWxl ICgqY3ApIHsKLQkJaWYgKCpjcCA9PSdcbicpIHsKLQkJCXB1dHN0cigiXHJcbiIpOwotCQkJY3Ar KzsKLQkJCWNvbnRpbnVlOworCXdoaWxlICgqY3AgIT0gMCkgeworCQlpZiAoKmNwID09ICdcbicp IHsKKwkJCXN0cmxjYXQod2hlcmUsICJcclxuIiwgd2hlcmVfc2l6ZSk7CiAJCX0gZWxzZSBpZiAo KmNwICE9ICclJykgewotCQkJcHV0Y2hyKCpjcCsrKTsKLQkJCWNvbnRpbnVlOwotCQl9Ci0JCXN3 aXRjaCAoKisrY3ApIHsKLQorCQkJKmNoX3N0ciA9ICpjcDsKKwkJCXN0cmxjYXQod2hlcmUsIGNo X3N0ciwgd2hlcmVfc2l6ZSk7CisJCX0gZWxzZSBzd2l0Y2ggKCorK2NwKSB7CiAJCWNhc2UgJ3Qn OgogI2lmZGVmCVNUUkVBTVNQVFkKIAkJCS8qIG5hbWVzIGFyZSBsaWtlIC9kZXYvcHRzLzIgLS0g d2Ugd2FudCBwdHMvMiAqLwpAQCAtNDQ4LDQ2ICs0MjUsNDIgQEAKICNlbHNlCiAJCQlzbGFzaCA9 IHN0cnJjaHIobGluZSwgJy8nKTsKICNlbmRpZgotCQkJaWYgKHNsYXNoID09IChjaGFyICopIDAp Ci0JCQkJcHV0c3RyKGxpbmUpOworCQkJaWYgKHNsYXNoID09IE5VTEwpCisJCQkJc3RybGNhdCh3 aGVyZSwgbGluZSwgd2hlcmVfc2l6ZSk7CiAJCQllbHNlCi0JCQkJcHV0c3RyKCZzbGFzaFsxXSk7 CisJCQkJc3RybGNhdCh3aGVyZSwgJnNsYXNoWzFdLCB3aGVyZV9zaXplKTsKIAkJCWJyZWFrOwot CiAJCWNhc2UgJ2gnOgotCQkJcHV0c3RyKGVkaXRlZGhvc3QpOworCQkJc3RybGNhdCh3aGVyZSwg ZWRpdGVkaG9zdCwgd2hlcmVfc2l6ZSk7CiAJCQlicmVhazsKLQogCQljYXNlICdkJzoKICNpZmRl ZiBfX0ZyZWVCU0RfXwogCQkJc2V0bG9jYWxlKExDX1RJTUUsICIiKTsKICNlbmRpZgogCQkJKHZv aWQpdGltZSgmdCk7CiAJCQkodm9pZClzdHJmdGltZShkYiwgc2l6ZW9mKGRiKSwgZm10c3RyLCBs b2NhbHRpbWUoJnQpKTsKLQkJCXB1dHN0cihkYik7CisJCQlzdHJsY2F0KHdoZXJlLCBkYiwgd2hl cmVfc2l6ZSk7CiAJCQlicmVhazsKLQogI2lmZGVmIF9fRnJlZUJTRF9fCiAJCWNhc2UgJ3MnOgot CQkJcHV0c3RyKGtlcm5pbmZvLnN5c25hbWUpOworCQkJc3RybGNhdCh3aGVyZSwga2VybmluZm8u c3lzbmFtZSwgd2hlcmVfc2l6ZSk7CiAJCQlicmVhazsKLQogCQljYXNlICdtJzoKLQkJCXB1dHN0 cihrZXJuaW5mby5tYWNoaW5lKTsKKwkJCXN0cmxjYXQod2hlcmUsIGtlcm5pbmZvLm1hY2hpbmUs IHdoZXJlX3NpemUpOwogCQkJYnJlYWs7Ci0KIAkJY2FzZSAncic6Ci0JCQlwdXRzdHIoa2Vybmlu Zm8ucmVsZWFzZSk7CisJCQlzdHJsY2F0KHdoZXJlLCBrZXJuaW5mby5yZWxlYXNlLCB3aGVyZV9z aXplKTsKIAkJCWJyZWFrOwotCiAJCWNhc2UgJ3YnOgotCQkJcHV0c3RyKGtlcm5pbmZvLnZlcnNp b24pOworCQkJc3RybGNhdCh3aGVyZSwga2VybmluZm8udmVyc2lvbiwgd2hlcmVfc2l6ZSk7CiAJ CQlicmVhazsKICNlbmRpZgotCiAJCWNhc2UgJyUnOgotCQkJcHV0Y2hyKCclJyk7CisJCQkqY2hf c3RyID0gJyUnOworCQkJc3RybGNhdCh3aGVyZSwgY2hfc3RyLCB3aGVyZV9zaXplKTsKIAkJCWJy ZWFrOworCQljYXNlIDA6CisJCQlyZXR1cm47CiAJCX0KIAkJY3ArKzsKIAl9Cg== ------=_Part_2638_24198527.1115652492256--