From owner-freebsd-current Mon Sep 28 15:43:22 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id PAA12659 for freebsd-current-outgoing; Mon, 28 Sep 1998 15:43:22 -0700 (PDT) (envelope-from owner-freebsd-current@FreeBSD.ORG) Received: from smtp02.primenet.com (smtp02.primenet.com [206.165.6.132]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id PAA12607 for ; Mon, 28 Sep 1998 15:43:04 -0700 (PDT) (envelope-from tlambert@usr04.primenet.com) Received: (from daemon@localhost) by smtp02.primenet.com (8.8.8/8.8.8) id PAA10100; Mon, 28 Sep 1998 15:42:50 -0700 (MST) Received: from usr04.primenet.com(206.165.6.204) via SMTP by smtp02.primenet.com, id smtpd010054; Mon Sep 28 15:42:46 1998 Received: (from tlambert@localhost) by usr04.primenet.com (8.8.5/8.8.5) id PAA09725; Mon, 28 Sep 1998 15:42:38 -0700 (MST) From: Terry Lambert Message-Id: <199809282242.PAA09725@usr04.primenet.com> Subject: Re: VM question Re m->valid ... To: rvb@cs.cmu.edu (Robert V. Baron) Date: Mon, 28 Sep 1998 22:42:37 +0000 (GMT) Cc: tlambert@primenet.com, current@FreeBSD.ORG, dyson@iquest.net In-Reply-To: from "Robert V. Baron" at Sep 28, 98 10:46:45 am X-Mailer: ELM [version 2.4 PL25] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG > The change mentioned below does not solve my problem. I have > two ways to go. I'd like feed back and will commit something > later today. I thought it might not; I think the result of the bug is only to orphan pages and force them to be needlessly reread. > There are two ways to go. One is to have vnode_pager_input_old > set m->valid iff there are no errors. This works fine for me. This is the correct fix. The page is not supposed to be valid unless it is valid. 8-). This may not be happening as a side effect of needing cleanup. You might need to avoid clearing PG_ZERO in the error case, as well... ? Terry Lambert terry@lambert.org --- Any opinions in this posting are my own and not those of my present or previous employers. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message