From owner-freebsd-fs@FreeBSD.ORG Wed Jan 6 22:10:34 2010 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9F3B2106568B; Wed, 6 Jan 2010 22:10:34 +0000 (UTC) (envelope-from mattjreimer@gmail.com) Received: from mail-gx0-f209.google.com (mail-gx0-f209.google.com [209.85.217.209]) by mx1.freebsd.org (Postfix) with ESMTP id 4C10F8FC23; Wed, 6 Jan 2010 22:10:34 +0000 (UTC) Received: by gxk1 with SMTP id 1so5642960gxk.14 for ; Wed, 06 Jan 2010 14:10:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:date:message-id:subject :from:to:content-type; bh=kUJkS6iCAj+aDkKzROkliJX5gldDLxYSopBbnQCRu8c=; b=mV1lks+T2FSg5tyxNBmHs4iNsBOpLR9PufU5nltaoFu2uUJJ6BKzkSRGQ9SyfEA8Yw kuk9X18WmOSk2GSnnHr8Er8LhbyWf+F0O9+DC0tnBauEIEfJzurU8bIHZAfjSDjuRsBF I9zspJU5O1fKiBgngrLMa0MicxtuK94MuJ1m0= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:date:message-id:subject:from:to:content-type; b=tU8SI8CJqnK8kL3w84ORipOEcHxoKYYuhPJR5cXvFEzsUElaMig/8RubuG2CCQjUPX UU8UkNaWw9U4hyUtVwCXOvc21yunobvrmu5IsWZ3SPavVMLwlQiO+t+eulBcDhyGz0t+ SDFIK5qApZBGJBabl99k6G15/iAQESNZEPOc8= MIME-Version: 1.0 Received: by 10.151.88.17 with SMTP id q17mr15702691ybl.190.1262815828628; Wed, 06 Jan 2010 14:10:28 -0800 (PST) Date: Wed, 6 Jan 2010 14:10:28 -0800 Message-ID: From: Matt Reimer To: freebsd-fs , Doug Rabson , Pawel Jakub Dawidek Content-Type: multipart/mixed; boundary=000e0cd7040ae20e63047c86387f Cc: Subject: PATCH: more efficient raidz memory usage for (gpt)zfsboot, zfsloader X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Jan 2010 22:10:34 -0000 --000e0cd7040ae20e63047c86387f Content-Type: text/plain; charset=ISO-8859-1 Would one of you be able to review this patch and commit it if it's acceptable? This is the same patch I submitted last month. Matt ---- Teach the (gpt)zfsboot and zfsloader raidz code to use its buffers more efficiently. Before this patch, in the worst case memory use would increase exponentially on the number of drives in the raidz vdev. Sponsored by: VPOP Technologies, Inc. Matt Reimer --000e0cd7040ae20e63047c86387f Content-Type: application/octet-stream; name="raidz-mem.patch" Content-Disposition: attachment; filename="raidz-mem.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_g37tvwgu0 LS0tIC9zeXMvY2RkbC9ib290L3pmcy96ZnNzdWJyLmMuT1JJRwkyMDA5LTExLTE0IDA4OjE0OjUx LjAwMDAwMDAwMCAtMDgwMAorKysgL3N5cy9jZGRsL2Jvb3QvemZzL3pmc3N1YnIuYwkyMDA5LTEy LTA3IDE1OjI3OjQ5LjAwMDAwMDAwMCAtMDgwMApAQCAtNDU0LDcgKzQ1NCw3IEBACiAKIHN0YXRp YyB2b2lkCiB2ZGV2X3JhaWR6X3JlY29uc3RydWN0X3BxKHJhaWR6X2NvbF90ICpjb2xzLCBpbnQg bnBhcml0eSwgaW50IGFjb2xzLAotICAgIGludCB4LCBpbnQgeSkKKyAgICBpbnQgeCwgaW50IHks IHZvaWQgKnRlbXBfcCwgdm9pZCAqdGVtcF9xKQogewogCXVpbnQ4X3QgKnAsICpxLCAqcHh5LCAq cXh5LCAqeGQsICp5ZCwgdG1wLCBhLCBiLCBhZXhwLCBiZXhwOwogCXZvaWQgKnBkYXRhLCAqcWRh dGE7CkBAIC00NzgsMTAgKzQ3OCw4IEBACiAJeHNpemUgPSBjb2xzW3hdLnJjX3NpemU7CiAJeXNp emUgPSBjb2xzW3ldLnJjX3NpemU7CiAKLQljb2xzW1ZERVZfUkFJRFpfUF0ucmNfZGF0YSA9Ci0J CXpmc19hbGxvY190ZW1wKGNvbHNbVkRFVl9SQUlEWl9QXS5yY19zaXplKTsKLQljb2xzW1ZERVZf UkFJRFpfUV0ucmNfZGF0YSA9Ci0JCXpmc19hbGxvY190ZW1wKGNvbHNbVkRFVl9SQUlEWl9RXS5y Y19zaXplKTsKKwljb2xzW1ZERVZfUkFJRFpfUF0ucmNfZGF0YSA9IHRlbXBfcDsKKwljb2xzW1ZE RVZfUkFJRFpfUV0ucmNfZGF0YSA9IHRlbXBfcTsKIAljb2xzW3hdLnJjX3NpemUgPSAwOwogCWNv bHNbeV0ucmNfc2l6ZSA9IDA7CiAKQEAgLTU1MSw5ICs1NDksMTIgQEAKIAl1aW50NjRfdCBmID0g YiAlIGRjb2xzOwogCXVpbnQ2NF90IG8gPSAoYiAvIGRjb2xzKSA8PCB1bml0X3NoaWZ0OwogCXVp bnQ2NF90IHEsIHIsIGNvZmY7Ci0JaW50IGMsIGMxLCBiYywgY29sLCBhY29scywgZGV2aWR4LCBh c2l6ZSwgbjsKKwlpbnQgYywgYzEsIGJjLCBjb2wsIGFjb2xzLCBkZXZpZHgsIGFzaXplLCBuLCBt YXhfcmNfc2l6ZTsKIAlzdGF0aWMgcmFpZHpfY29sX3QgY29sc1sxNl07CiAJcmFpZHpfY29sX3Qg KnJjLCAqcmMxOworCXZvaWQgKm9yaWcsICpvcmlnMSwgKnRlbXBfcCwgKnRlbXBfcTsKKworCW9y aWcgPSBvcmlnMSA9IHRlbXBfcCA9IHRlbXBfcSA9IE5VTEw7CiAKIAlxID0gcyAvIChkY29scyAt IG5wYXJpdHkpOwogCXIgPSBzIC0gcSAqIChkY29scyAtIG5wYXJpdHkpOwpAQCAtNTYxLDYgKzU2 Miw3IEBACiAKIAlhY29scyA9IChxID09IDAgPyBiYyA6IGRjb2xzKTsKIAlhc2l6ZSA9IDA7CisJ bWF4X3JjX3NpemUgPSAwOwogCQogCWZvciAoYyA9IDA7IGMgPCBhY29sczsgYysrKSB7CiAJCWNv bCA9IGYgKyBjOwpAQCAtNTc3LDYgKzU3OSw4IEBACiAJCWNvbHNbY10ucmNfdHJpZWQgPSAwOwog CQljb2xzW2NdLnJjX3NraXBwZWQgPSAwOwogCQlhc2l6ZSArPSBjb2xzW2NdLnJjX3NpemU7CisJ CWlmIChjb2xzW2NdLnJjX3NpemUgPiBtYXhfcmNfc2l6ZSkKKwkJCW1heF9yY19zaXplID0gY29s c1tjXS5yY19zaXplOwogCX0KIAogCWFzaXplID0gcm91bmR1cChhc2l6ZSwgKG5wYXJpdHkgKyAx KSA8PCB1bml0X3NoaWZ0KTsKQEAgLTc3Nyw4ICs3ODEsMTMgQEAKIAkJCS8vQVNTRVJUKGMgIT0g YWNvbHMpOwogCQkJLy9BU1NFUlQoIXJjLT5yY19za2lwcGVkIHx8IHJjLT5yY19lcnJvciA9PSBF TlhJTyB8fCByYy0+cmNfZXJyb3IgPT0gRVNUQUxFKTsKIAorCQkJaWYgKCF0ZW1wX3ApCisJCQkJ dGVtcF9wID0gemZzX2FsbG9jX3RlbXAobWF4X3JjX3NpemUpOworCQkJaWYgKCF0ZW1wX3EpCisJ CQkJdGVtcF9xID0gemZzX2FsbG9jX3RlbXAobWF4X3JjX3NpemUpOworCiAJCQl2ZGV2X3JhaWR6 X3JlY29uc3RydWN0X3BxKGNvbHMsIG5wYXJpdHksIGFjb2xzLAotCQkJICAgIGMxLCBjKTsKKwkJ CSAgICBjMSwgYywgdGVtcF9wLCB0ZW1wX3EpOwogCiAJCQlpZiAoemlvX2NoZWNrc3VtX2Vycm9y KGJwLCBidWYpID09IDApCiAJCQkJcmV0dXJuICgwKTsKQEAgLTg0NSwxOCArODU0LDEyIEBACiAJ CXJldHVybiAoRUlPKTsKIAl9CiAKLQlhc2l6ZSA9IDA7Ci0JZm9yIChjID0gMDsgYyA8IGFjb2xz OyBjKyspIHsKLQkJcmMgPSAmY29sc1tjXTsKLQkJaWYgKHJjLT5yY19zaXplID4gYXNpemUpCi0J CQlhc2l6ZSA9IHJjLT5yY19zaXplOwotCX0KIAlpZiAoY29sc1tWREVWX1JBSURaX1BdLnJjX2Vy cm9yID09IDApIHsKIAkJLyoKIAkJICogQXR0ZW1wdCB0byByZWNvbnN0cnVjdCB0aGUgZGF0YSBm cm9tIHBhcml0eSBQLgogCQkgKi8KLQkJdm9pZCAqb3JpZzsKLQkJb3JpZyA9IHpmc19hbGxvY190 ZW1wKGFzaXplKTsKKwkJaWYgKCFvcmlnKQorCQkJb3JpZyA9IHpmc19hbGxvY190ZW1wKG1heF9y Y19zaXplKTsKIAkJZm9yIChjID0gbnBhcml0eTsgYyA8IGFjb2xzOyBjKyspIHsKIAkJCXJjID0g JmNvbHNbY107CiAKQEAgLTg3NCw4ICs4NzcsOCBAQAogCQkvKgogCQkgKiBBdHRlbXB0IHRvIHJl Y29uc3RydWN0IHRoZSBkYXRhIGZyb20gcGFyaXR5IFEuCiAJCSAqLwotCQl2b2lkICpvcmlnOwot CQlvcmlnID0gemZzX2FsbG9jX3RlbXAoYXNpemUpOworCQlpZiAoIW9yaWcpCisJCQlvcmlnID0g emZzX2FsbG9jX3RlbXAobWF4X3JjX3NpemUpOwogCQlmb3IgKGMgPSBucGFyaXR5OyBjIDwgYWNv bHM7IGMrKykgewogCQkJcmMgPSAmY29sc1tjXTsKIApAQCAtODk1LDkgKzg5OCwxNCBAQAogCQkv KgogCQkgKiBBdHRlbXB0IHRvIHJlY29uc3RydWN0IHRoZSBkYXRhIGZyb20gYm90aCBQIGFuZCBR LgogCQkgKi8KLQkJdm9pZCAqb3JpZywgKm9yaWcxOwotCQlvcmlnID0gemZzX2FsbG9jX3RlbXAo YXNpemUpOwotCQlvcmlnMSA9IHpmc19hbGxvY190ZW1wKGFzaXplKTsKKwkJaWYgKCFvcmlnKQor CQkJb3JpZyA9IHpmc19hbGxvY190ZW1wKG1heF9yY19zaXplKTsKKwkJaWYgKCFvcmlnMSkKKwkJ CW9yaWcxID0gemZzX2FsbG9jX3RlbXAobWF4X3JjX3NpemUpOworCQlpZiAoIXRlbXBfcCkKKwkJ CXRlbXBfcCA9IHpmc19hbGxvY190ZW1wKG1heF9yY19zaXplKTsKKwkJaWYgKCF0ZW1wX3EpCisJ CQl0ZW1wX3EgPSB6ZnNfYWxsb2NfdGVtcChtYXhfcmNfc2l6ZSk7CiAJCWZvciAoYyA9IG5wYXJp dHk7IGMgPCBhY29scyAtIDE7IGMrKykgewogCQkJcmMgPSAmY29sc1tjXTsKIApAQCAtOTA5LDcg KzkxNyw3IEBACiAJCQkJbWVtY3B5KG9yaWcxLCByYzEtPnJjX2RhdGEsIHJjMS0+cmNfc2l6ZSk7 CiAKIAkJCQl2ZGV2X3JhaWR6X3JlY29uc3RydWN0X3BxKGNvbHMsIG5wYXJpdHksCi0JCQkJICAg IGFjb2xzLCBjLCBjMSk7CisJCQkJICAgIGFjb2xzLCBjLCBjMSwgdGVtcF9wLCB0ZW1wX3EpOwog CiAJCQkJaWYgKHppb19jaGVja3N1bV9lcnJvcihicCwgYnVmKSA9PSAwKQogCQkJCQlyZXR1cm4g KDApOwo= --000e0cd7040ae20e63047c86387f--