From owner-freebsd-current@freebsd.org Mon Dec 16 23:12:53 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id F377C1D11A0 for ; Mon, 16 Dec 2019 23:12:53 +0000 (UTC) (envelope-from nomadlogic@gmail.com) Received: from mail-vs1-xe43.google.com (mail-vs1-xe43.google.com [IPv6:2607:f8b0:4864:20::e43]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 47cH9x2046z4Rcp for ; Mon, 16 Dec 2019 23:12:52 +0000 (UTC) (envelope-from nomadlogic@gmail.com) Received: by mail-vs1-xe43.google.com with SMTP id x123so5301674vsc.2 for ; Mon, 16 Dec 2019 15:12:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=zOxBadUJIR28tr6D19JbWp+D0oK0NKEMqTSiyxiiPqQ=; b=Tb8J2ZkrrbbgktKPThMOiOowWcylio7hH9NaaBt6KT1XoGzBuNCgQfVf3+nVAC4SaT x8KmgqCb1oJ6qhlL0yTmCdFtaegxd9+hfy5L+QFfggZryG8RWoFUXyGZw2atsNs+lHvS XKV9mbTFF6+ef1MbZtxRpJyX5aZwkHokELKdZK4fHFQ/761jizN8dgtlkZ915UOErWiG NPi2ZyIL6Z+Ofmv2Zd1asEJix3l32wM2D/JRlaLdogQvsZqkycCvLtWSMBiZVHEKZp35 6TMmXFdyVA5C32T45ETKnnSyC3tBVJhDxZwMUVUpiZIuWwkPCxws0uqOmqpaBPjjCfjc AvXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zOxBadUJIR28tr6D19JbWp+D0oK0NKEMqTSiyxiiPqQ=; b=YEm4fq7gPR2PPSSs1mTUR9oGZb/zPFFqeMz6fY2pplcQ8JgKho6PwIHV0ELKdz62Cr gQyAy5xdW8Joqk0ksFP6romctQeIWqP41tq9v/WX+l7IS4Uye6c2z9N6aCg7SSGPfUod LvtREsjhWrnBehc3IImxFS55xs/JDZhxI/x6l4skCoxy1BY8Ce7PsAnMKxBsIs8u5bEP atI7IqJB7CtXGEnFH4Q/BVhG5jptE2Ec3auRxacR5OWGJFdYiDpeQiPDyQtz015eBEg4 sv9S0noBdGuMy/OfoxV2mPDrnrhTEcV0lWPPamEsCTP3w4imfooofgjwPOBe4wKRwlHR draA== X-Gm-Message-State: APjAAAV+fJatX7plN18iqJ/wxOLUxtOvXZuBOCGbb/OFHQvudai8X/h4 DVBz0eQPOzO7i40ckYl61RDKw4EJROXfnTp4VHgH2g== X-Google-Smtp-Source: APXvYqw1D5QH92hQh7zzrE9B2ZEzGB2KQJnmeYHMzWrTyVV8pEq2dupNuE+EduPj7iCNaO9KxIVViUYyUfuOsdzH2rk= X-Received: by 2002:a67:e3c8:: with SMTP id k8mr1067007vsm.121.1576537971881; Mon, 16 Dec 2019 15:12:51 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: pete wright Date: Mon, 16 Dec 2019 15:12:40 -0800 Message-ID: Subject: Re: error building scsi_da.c with recent current To: Warner Losh Cc: FreeBSD Current X-Rspamd-Queue-Id: 47cH9x2046z4Rcp X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=Tb8J2Zkr; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of nomadlogic@gmail.com designates 2607:f8b0:4864:20::e43 as permitted sender) smtp.mailfrom=nomadlogic@gmail.com X-Spamd-Result: default: False [-2.00 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; FREEMAIL_FROM(0.00)[gmail.com]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-current@freebsd.org]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; IP_SCORE_FREEMAIL(0.00)[]; URI_COUNT_ODD(1.00)[9]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; RCPT_COUNT_TWO(0.00)[2]; RCVD_IN_DNSWL_NONE(0.00)[3.4.e.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; IP_SCORE(0.00)[ip: (2.47), ipnet: 2607:f8b0::/32(-2.19), asn: 15169(-1.90), country: US(-0.05)]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com.dwl.dnswl.org : 127.0.5.0] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Dec 2019 23:12:54 -0000 Thanks, maybe git mirror was lagging will test in a bit. Thanks! -pete On Mon, Dec 16, 2019, 3:09 PM Warner Losh wrote: > Update. That version was in place for about an hour before I fixed it. > r355815 broke it and r355818 fixed it. > > Warner > > > On Mon, Dec 16, 2019 at 3:27 PM pete wright wrote: > >> here's the error i'm getting when building: >> /usr/home/pete/git/freebsd/sys/cam/scsi/scsi_da.c:1544:28: error: expected >> identifier >> SYSCTL_INT64(_kern_cam_da, OID_AUTO, default_max_delete, CTLFLAG_RWTUN, >> ^ >> /usr/home/pete/git/freebsd/sys/sys/sysctl.h:126:18: note: expanded from >> macro 'OID_AUTO' >> #define OID_AUTO (-1) >> ^ >> /usr/home/pete/git/freebsd/sys/cam/scsi/scsi_da.c:1544:1: error: type >> specifier missing, defaults to 'int' [-Werror,-Wimplicit-int] >> SYSCTL_INT64(_kern_cam_da, OID_AUTO, default_max_delete, CTLFLAG_RWTUN, >> ^ >> /usr/home/pete/git/freebsd/sys/cam/scsi/scsi_da.c:1544:13: error: this >> function declaration is not a prototype [-Werror,-Wstrict-prototypes] >> SYSCTL_INT64(_kern_cam_da, OID_AUTO, default_max_delete, CTLFLAG_RWTUN, >> ^ >> 3 errors generated. >> *** [scsi_da.o] Error code 1 >> >> >> >> might be this commit? >> commit 5fa79c6768be78d78815156f8ecf50cb2008233f (HEAD -> master, >> origin/master, origin/HEAD) >> Author: imp >> Date: Mon Dec 16 18:16:44 2019 +0000 >> >> Implement a system-wide limit or da and ada devices for delete. >> >> Excesively large TRIMs can result in timeouts, which cause big >> problems. Limit trims to 1GB to mititgate these issues. >> >> Reviewed by: scottl >> Differential Revision: https://reviews.freebsd.org/D22809 >> >> >> >> if there is any additional info needed happy to provide it. >> >> cheers, >> -pete >> >> -- >> pete wright >> www.nomadlogic.org >> @nomadlogicLA >> _______________________________________________ >> freebsd-current@freebsd.org mailing list >> https://lists.freebsd.org/mailman/listinfo/freebsd-current >> To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org >> " >> >