From owner-freebsd-ports@FreeBSD.ORG Tue Feb 13 21:56:46 2007 Return-Path: X-Original-To: freebsd-ports@freebsd.org Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 1EBCC16A402 for ; Tue, 13 Feb 2007 21:56:46 +0000 (UTC) (envelope-from danny@ricin.com) Received: from smtpq1.groni1.gr.home.nl (smtpq1.groni1.gr.home.nl [213.51.130.200]) by mx1.freebsd.org (Postfix) with ESMTP id 41B1913C4BA for ; Tue, 13 Feb 2007 21:56:45 +0000 (UTC) (envelope-from danny@ricin.com) Received: from [213.51.130.190] (port=58042 helo=smtp1.groni1.gr.home.nl) by smtpq1.groni1.gr.home.nl with esmtp (Exim 4.30) id 1HH5HY-0004zu-HV; Tue, 13 Feb 2007 22:33:48 +0100 Received: from cp464173-a.dbsch1.nb.home.nl ([84.27.221.74]:58393 helo=desktop.homenet) by smtp1.groni1.gr.home.nl with esmtp (Exim 4.30) id 1HH5ES-0003RQ-D1; Tue, 13 Feb 2007 22:30:36 +0100 From: Danny Pansters To: freebsd-ports@freebsd.org Date: Tue, 13 Feb 2007 22:30:22 +0100 User-Agent: KMail/1.9.5 References: <47998907@srv.sem.ipt.ru> <200702122145.19885.danny@ricin.com> <20070213030913.GA23018@darklight.abyss.local> In-Reply-To: <20070213030913.GA23018@darklight.abyss.local> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200702132230.22373.danny@ricin.com> X-AtHome-MailScanner-Information: Please contact support@home.nl for more information X-AtHome-MailScanner: Found to be clean Cc: Yuri Pankov Subject: Re: multimedia/kbtv: broken saa kmod? X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Feb 2007 21:56:46 -0000 On Tuesday 13 February 2007 04:09, Yuri Pankov wrote: > Hi, > > I've attached a patch allowing saa kmod to compile cleanly on amd64 with > WERROR defined. > > I don't use kbtv but am interested in saa713x driver, so improvements to > make it work in SECAM are welcome. Just setting SECAM video standard to get > colour picture seems pretty easy, given the code in > saa/saa/support/set_videoopt.c. Diff adding SECAM option to it is also > attached. Thanks. Should be in the driver really, so that GETVIDEOSTD provides it. > > Another question - is anyone successfully running this driver on -CURRENT? > I'm wondering cause of the following change by imp@ to iicbus.c, denying > attach of generic iic device: > > =================================================================== > RCS file: /usr/local/www/cvsroot/FreeBSD/src/sys/dev/iicbus/iicbus.c,v > retrieving revision 1.21 > retrieving revision 1.22 > diff -u -p -r1.21 -r1.22 > > > > @@ -139,51 +139,52 @@ iicbus_attach(device_t dev) > printf("\n"); > #endif > > - /* attach any known device */ > device_add_child(dev, "ic", -1); > - device_add_child(dev, "iic", -1); > device_add_child(dev, "iicsmb", -1); Outch. I would think yes, this would be a problem (I don't run 7-current yet). BTW, I did notice that iic(4) behaves different than its manpage says. At least with the (mk3) tuner programming I found that write command doesn't automagically takes care of start/stop conditions. I really must START first (and write first cmd) then after that can use write. The Philips tuner documentation also specifically says first start then optionally write/read then stop. I see the same in Rohit's tuning code (plus some bus resets). In the kbtv saa module I only reset the bus at tuner/IF init, not while changing channels. Sometimes it loses its way and tunes to 0 MHz but fortunately it can then be correctly tuned again. I recall Rohit's ftvv app having a button "restart IF" or something alike the meaning of which I only understood much later :) Dan > - > +#if 0 > + /* attach any known device */ > + device_add_child(dev, "iic", -1); > +#endif > bus_generic_attach(dev); > - > return (0); > } > > > > > HTH, > Yuri