From owner-freebsd-ports-bugs@FreeBSD.ORG Tue Oct 6 08:00:12 2009 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1D49810656A3 for ; Tue, 6 Oct 2009 08:00:12 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id D29668FC23 for ; Tue, 6 Oct 2009 08:00:11 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id n9680Bpg099304 for ; Tue, 6 Oct 2009 08:00:11 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id n9680Bn5099303; Tue, 6 Oct 2009 08:00:11 GMT (envelope-from gnats) Resent-Date: Tue, 6 Oct 2009 08:00:11 GMT Resent-Message-Id: <200910060800.n9680Bn5099303@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, dirk.meyer@dinoex.sub.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 78C3D106568F for ; Tue, 6 Oct 2009 07:51:40 +0000 (UTC) (envelope-from dm@home3.dinoex.sub.de) Received: from uucp.dinoex.sub.de (uucp.dinoex.sub.de [194.45.71.2]) by mx1.freebsd.org (Postfix) with ESMTP id DECB78FC19 for ; Tue, 6 Oct 2009 07:51:39 +0000 (UTC) Received: from home3.dinoex.sub.de (home3.dinoex.sub.de [194.45.71.20]) by uucp.dinoex.sub.de (8.14.3/8.14.2) with ESMTP id n967oBVO077979 for ; Tue, 6 Oct 2009 09:50:28 +0200 (CEST) (envelope-from dm@home3.dinoex.sub.de) Received: (from dm@localhost) by home3.dinoex.sub.de (8.14.3/8.14.3/Submit) id n967q5L1036533; Tue, 6 Oct 2009 09:52:05 +0200 (CEST) (envelope-from dm) Message-Id: <200910060752.n967q5L1036533@home3.dinoex.sub.de> Date: Tue, 6 Oct 2009 09:52:05 +0200 (CEST) From: dirk.meyer@dinoex.sub.org To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: ports/139374: [patch] graphics/xpdf fix build with lesstif X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: dirk.meyer@dinoex.sub.org List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Oct 2009 08:00:12 -0000 >Number: 139374 >Category: ports >Synopsis: [patch] graphics/xpdf fix build with lesstif >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Tue Oct 06 08:00:11 UTC 2009 >Closed-Date: >Last-Modified: >Originator: Dirk Meyer >Release: FreeBSD 8.0-BETA4 >Organization: privat >Environment: FreeBSD 7.x FreeBSD 8.x /etc/make.conf WANT_LESSTIF=YES >Description: xdpf does not build with lesstif. Error mesasge: In file included from XPDFApp.cc:18: XPDFViewer.h:338: error: 'nColorMenuItems' was not declared in this scope bails out at: [...] #if USE_COMBO_BOX Widget zoomComboBox; #else Widget zoomMenu; Widget zoomMenuBtns[nZoomMenuItems]; Widget colorMenuBtns[nColorMenuItems]; #endif [...] nColorMenuItems is not defined at all, neither in lestif nor in open-motif itself. The following detection stuff is wrong. [...] #if (XmVERSION >= 2 && !defined(LESSTIF_VERSION)) # define USE_COMBO_BOX 1 #else # undef USE_COMBO_BOX #endif [...] Problem reported at 08th Nov 2008 To: araujo@freebsd.org Feedback received at 10th Nov 2008 Details reported at 11th Nov 2008 >How-To-Repeat: pkg_add lesstif-0.95.2_1,2.tbz cd /usr/ports/graphics/xpdf && make WANT_LESTIF=1 >Fix: a) fix the patch-zz-xpdf-annot.20080728a by removing "!defined(LESSTIF_VERSION))" in XPDFViewer.h b) or Apply this patch. Index: Makefile =================================================================== RCS file: /home/pcvs/ports/graphics/xpdf/Makefile,v retrieving revision 1.91 diff -u -r1.91 Makefile --- Makefile 18 Apr 2009 17:27:21 -0000 1.91 +++ Makefile 6 Oct 2009 07:34:30 -0000 @@ -78,6 +78,10 @@ # add support for adding/deleting drawing annotations in PDF files PATCH_SITES+= http://info.iet.unipi.it/~luigi/FreeBSD/ PATCHFILES+= patch-zz-xpdf-annot.20080728a + +post-patch: + ${REINPLACE_CMD} -e 's|undef USE_COMBO_BOX|define USE_COMBO_BOX 1|' \ + ${WRKSRC}/xpdf/XPDFViewer.h .endif post-install: >Release-Note: >Audit-Trail: >Unformatted: