From owner-freebsd-current Tue Mar 21 9: 7:24 2000 Delivered-To: freebsd-current@freebsd.org Received: from nimitz.ca.sandia.gov (nimitz.ca.sandia.gov [146.246.243.56]) by hub.freebsd.org (Postfix) with ESMTP id 8E91037B8D3 for ; Tue, 21 Mar 2000 09:07:17 -0800 (PST) (envelope-from bmah@nimitz.ca.sandia.gov) Received: (from bmah@localhost) by nimitz.ca.sandia.gov (8.10.0/8.10.0) id e2LH6YJ86200; Tue, 21 Mar 2000 09:06:34 -0800 (PST) (envelope-from bmah) Message-Id: <200003211706.e2LH6YJ86200@nimitz.ca.sandia.gov> X-Mailer: exmh version 2.1.1-cvs 10/15/1999 To: Yoshinobu Inoue Cc: nnd@mail.nsk.ru, current@FreeBSD.ORG Subject: Re: 'machine/param.h' required for 'sys/socket.h' In-Reply-To: <20000322013459L.shin@nd.net.fujitsu.co.jp> References: <200003210838.OAA01544@wint.itfs.nsk.su> <20000322013459L.shin@nd.net.fujitsu.co.jp> Comments: In-reply-to Yoshinobu Inoue message dated "Wed, 22 Mar 2000 01:34:59 +0900." From: bmah@CA.Sandia.GOV (Bruce A. Mah) Reply-To: bmah@CA.Sandia.GOV X-Face: g~c`.{#4q0"(V*b#g[i~rXgm*w;:nMfz%_RZLma)UgGN&=j`5vXoU^@n5v4:OO)c["!w)nD/!!~e4Sj7LiT'6*wZ83454H""lb{CC%T37O!!'S$S&D}sem7I[A 2V%N&+ X-Url: http://www.ca.sandia.gov/~bmah/ Mime-Version: 1.0 Content-Type: multipart/signed; boundary="==_Exmh_-389727046P"; micalg=pgp-sha1; protocol="application/pgp-signature" Content-Transfer-Encoding: 7bit Date: Tue, 21 Mar 2000 09:06:34 -0800 Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG --==_Exmh_-389727046P Content-Type: text/plain; charset=us-ascii If memory serves me right, Yoshinobu Inoue wrote: > > > 'sys/scocket.h' header file start using ALIGN macro > > defined in 'machine/param.h' header file while the man page > > for "socket" only mentioned 'sys/types.h' as the prerequisite > > for 'sys/socket.h'. > > > > As a result the 'net/pchar' port is now broken. > > Yes, this problem is already found by Bruce A. Mah and some > mail is exchanged between related people. I'm doing a pointrev to pchar to "fix" this problem...see below. > > What must be done to solve this ? > > Is it possible to '#include ' in 'sys/socket.h' OR > > the man page must be corrected to explicitly state 'param.h' > > (sys/ or machine/ ?) as the prerequisite to 'sys/socket.h' and > > all the programms using it patched accordingly ? > > As itojun's experience, including machine/param.h in socket.h > also cause problems in some other apps. > > I feel requesting inclusion of machine/param.h for any apps > which use socket is better. But if there are any other smarter > solution, please let me know and I'll appreciate it much. Just speaking as the slightly whiny developer of pchar: What bothers me is that out of all the platforms where pchar can do IPv6 support, recent FreeBSD versions seem the *only* case where I need to include machine/ param.h in order to use the CMSG* macros. This means that FreeBSD is forcing me to make some code changes that aren't required for *any* other platform. According to itojun's earlier mail, I can't just blindly include machine/param.h either. So I need to figure out at compile-time or configure-time whether or not I need machine/param.h. Personally, I think this is a lose. Unfortunately I don't have any better suggestion than "back out your last commit". In the specific case of pchar, I need to make code changes in order to work with 4.0-RELEASE, now that it's been shipped with the header files as we've discussed. So I wrote a bunch of autoconf code to detect this breakage and fix it. I'll probably roll in some Solaris fixes also and call this pchar-1.1.2 or something like that. Bruce. --==_Exmh_-389727046P Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: PGPfreeware 5.0i for non-commercial use MessageID: 3uCh5X62cIbIdDoqZ//j08o34NzF4+46 iQA/AwUBONesGdjKMXFboFLDEQJU2QCgxSDcOInXsdYhVmzsijyMDyv03TsAoIaw FZQHXjJyqthiooRftebXdDtF =FUFT -----END PGP SIGNATURE----- --==_Exmh_-389727046P-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message