From owner-cvs-all Mon Apr 8 5:20:25 2002 Delivered-To: cvs-all@freebsd.org Received: from mail.sat.t.u-tokyo.ac.jp (nat.keisu.t.u-tokyo.ac.jp [133.11.68.2]) by hub.freebsd.org (Postfix) with ESMTP id AD15B37B400; Mon, 8 Apr 2002 05:20:04 -0700 (PDT) Received: from ett.sat.t.u-tokyo.ac.jp (ett.sat.t.u-tokyo.ac.jp [10.6.1.30]) by mail.sat.t.u-tokyo.ac.jp (Postfix) with ESMTP id 7A9B62DAC3; Mon, 8 Apr 2002 21:20:02 +0900 (JST) Date: Mon, 08 Apr 2002 21:20:02 +0900 Message-ID: From: Hidetoshi Shimokawa To: Josef Karthauser Cc: Hidetoshi Shimokawa , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/cam/scsi scsi_all.c scsi_da.c In-Reply-To: <20020408095521.GF54610@genius.tao.org.uk> References: <200204080844.g388iG629845@freefall.freebsd.org> <20020408095521.GF54610@genius.tao.org.uk> User-Agent: Wanderlust/2.4.1 (Stand By Me) REMI/1.14.3 (Matsudai) FLIM/1.13.2 (Kasanui) APEL/10.3 MULE XEmacs/21.2 (beta19) (Shinjuku) (i386-unknown-freebsd3.2) X-Face: OE([KxWyJI0r[R~S/>7ia}SJ)i%a,$-9%7{*yihQk|]gl}2p#"oXmX/fT}Bn7:#j7i14gu$ jgR\S*&C3R/pJX List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG At Mon, 8 Apr 2002 10:55:21 +0100, Josef Karthauser wrote: > > On Mon, Apr 08, 2002 at 01:44:16AM -0700, Hidetoshi Shimokawa wrote: > > simokawa 2002/04/08 01:44:16 PDT > > > > Modified files: (Branch: RELENG_4) > > sys/cam/scsi scsi_all.c scsi_da.c > > Log: > > MFC: > > - Add support for Simplified Direct Access Device. > > - Automatically detect devices that do not support READ(6)/WRITE(6). > > > > scsi_all.c: rev. 1.29 > > scsi_da.c: rev. 1.98, 1.101 > > Does this mean that the usb umass quirks can be removed? If the device returns SCSI error (illegal request), it can be removed. But if it returns no error, you have to do sysctl kern.cam.da.no_6_byte=1 or keep the quirks or enable ad-hoc workaround (the follwing patch). Justin ask me to disable this part until he looks into the umass-sim. As far as I know umass-sim doesn't return any error for the most of the drives. I think umass-sim should be return some errors if tranfer length is 0. /\ Hidetoshi Shimokawa \/ simokawa@sat.t.u-tokyo.ac.jp PGP public key: http://www.sat.t.u-tokyo.ac.jp/~simokawa/pgp.html Index: scsi_da.c =================================================================== RCS file: /home/ncvs/src/sys/cam/scsi/scsi_da.c,v retrieving revision 1.102 diff -u -r1.102 scsi_da.c --- scsi_da.c 31 Mar 2002 22:28:03 -0000 1.102 +++ scsi_da.c 8 Apr 2002 12:16:35 -0000 @@ -1402,7 +1402,7 @@ bp->bio_error = 0; if (bp->bio_resid != 0) { /* Short transfer ??? */ -#if 0 +#if 1 if (cmd6workaround(done_ccb) == ERESTART) return; @@ -1422,7 +1422,7 @@ bp->bio_resid = csio->resid; if (csio->resid > 0) { /* Short transfer ??? */ -#if 0 /* XXX most of the broken umass devices need this ad-hoc work around */ +#if 1 /* XXX most of the broken umass devices need this ad-hoc work around */ if (cmd6workaround(done_ccb) == ERESTART) return; #endif To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message