From owner-cvs-src@FreeBSD.ORG Tue Jan 20 16:41:13 2004 Return-Path: <owner-cvs-src@FreeBSD.ORG> Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AD4E816A4CF; Tue, 20 Jan 2004 16:41:13 -0800 (PST) Received: from ozlabs.org (ozlabs.org [203.10.76.45]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3AD7E43D1F; Tue, 20 Jan 2004 16:41:11 -0800 (PST) (envelope-from grog@lemis.com) Received: from blackwater.lemis.com (blackwater.lemis.com [192.109.197.80]) by ozlabs.org (Postfix) with ESMTP id 2F5722BD75; Wed, 21 Jan 2004 11:41:08 +1100 (EST) Received: by blackwater.lemis.com (Postfix, from userid 1004) id 38E6A51205; Wed, 21 Jan 2004 11:11:06 +1030 (CST) Date: Wed, 21 Jan 2004 11:11:06 +1030 From: Greg 'groggy' Lehey <grog@FreeBSD.org> To: John Baldwin <jhb@FreeBSD.org>, Poul-Henning Kamp <phk@phk.freebsd.dk> Message-ID: <20040121004106.GO47639@wantadilla.lemis.com> References: <200401201600.19855.jhb@FreeBSD.org> <9810.1074634398@critter.freebsd.dk> <9202.1074631158@critter.freebsd.dk> <200401201600.19855.jhb@FreeBSD.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Pk/CTwBz1VvfPIDp" Content-Disposition: inline In-Reply-To: <9810.1074634398@critter.freebsd.dk> <200401201600.19855.jhb@FreeBSD.org> User-Agent: Mutt/1.4.1i Organization: The FreeBSD Project Phone: +61-8-8388-8286 Fax: +61-8-8388-8725 Mobile: +61-418-838-708 WWW-Home-Page: http://www.FreeBSD.org/ X-PGP-Fingerprint: 9A1B 8202 BCCE B846 F92F 09AC 22E6 F290 507A 4223 cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/alpha/alpha support.s src/sys/i386/i386 swtch.s src/sys/kern kern_shutdown.c src/sys/sys systm.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org> List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>, <mailto:cvs-src-request@freebsd.org?subject=unsubscribe> List-Archive: <http://lists.freebsd.org/pipermail/cvs-src> List-Post: <mailto:cvs-src@freebsd.org> List-Help: <mailto:cvs-src-request@freebsd.org?subject=help> List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>, <mailto:cvs-src-request@freebsd.org?subject=subscribe> X-List-Received-Date: Wed, 21 Jan 2004 00:41:13 -0000 --Pk/CTwBz1VvfPIDp Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tuesday, 20 January 2004 at 16:00:19 -0500, John Baldwin wrote: > On Tuesday 20 January 2004 03:39 pm, Poul-Henning Kamp wrote: >> In message <200401201445.24897.jhb@FreeBSD.org>, John Baldwin writes: >>> On Tuesday 20 January 2004 01:23 pm, Poul-Henning Kamp wrote: >>>> In message <200401201234.45472.jhb@FreeBSD.org>, John Baldwin writes: >>>>> On Monday 19 January 2004 04:27 pm, Poul-Henning Kamp wrote: >>>>>> Log: >>>>>> Add linenumber and source filename to panic(9) output. >> >> May I kindly remind you all that even if one person doesn't find >> that it adds anything to his already trained skills as a debugger, >> it does make life easier for other less gifted people in our project, >> or God forbid: actual users who may try to report a problem. > > By adding even more clutter to a panic message (esp. the fatal page faults > that happen more often than any other panic) you make it even harder for any > debugger to glean out the useful information from all of the rest. OK, I haven't seen this output, but if it's just line number and source file name, I think it's a Good Idea. >> And no, this does not solve the mid-east crisis, but it is still >> an improvement, even for me: If I save 1 minute because I do not >> have to hunt for the panic in the first place, then that is one >> minute more I can spend on the code. > > It is not an improvement in all cases and most of the people in this > thread have opposed this. I'm very much in favour. > The only response you got on the mailing list to your post was a > "please do not commit" from Bruce and you went ahead and committed > anyway. Do all of our opinions just not count when the Almighty > Poul-Henning has a patch he wants to commit? Certainly committing without consensus is wrong. I've been out of touch for the last week due to a conference, so I didn't see the discussion, but that's a separate issue. I'll concentrate on the technical issue in this message. >> So if this makes your eyes water, I suggest you comment it out in >> your local source tree and pop in on the next meeting in your >> local user-group for some much needed perspective. > > I have been very busy helping people with bug reports including > closing PR's etc. I'm not hiding in my white tower cursing users as > you seem to imply, so you can lay off that lame argument. In my > real world experience, the panic message is enough to find where the > problem is. OK, fine for you. And yes, I can grep too. But finding bugs is hard enough; any help can only be an improvement. > Several of them already include far more relevant file and line > numbers anyways. These are obviously not the newbies on FreeBSD-questions who say "My machine panicked. What went wrong?". On Tuesday, 20 January 2004 at 22:33:18 +0100, Poul-Henning Kamp wrote: > In message <200401201600.19855.jhb@FreeBSD.org>, John Baldwin writes: > > I suggest you and everybody else calm down and let dust settle for > a couple of days, maybe other people should have a chance to say > their opinion. If there is a clear concensus that this is bad > (maybe somebody neutral should take a count ?), then we'll back it > out. Sounds reasonable to me. Greg -- See complete headers for address and phone numbers. --Pk/CTwBz1VvfPIDp Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.0 (FreeBSD) iD8DBQFADcqiIubykFB6QiMRAhGRAJ49IJJM67K8qZx30c3OrLYqJHcJFgCfWhUd rwM7XCLWgPlQkAjCHD/PVHg= =wGo3 -----END PGP SIGNATURE----- --Pk/CTwBz1VvfPIDp--