From owner-svn-ports-head@freebsd.org Fri Nov 8 09:42:18 2019 Return-Path: Delivered-To: svn-ports-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id AA7411AD11D; Fri, 8 Nov 2019 09:42:18 +0000 (UTC) (envelope-from zeising@freebsd.org) Received: from mail.daemonic.se (mail.daemonic.se [176.58.89.161]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 478b0B3xRTz47H6; Fri, 8 Nov 2019 09:42:18 +0000 (UTC) (envelope-from zeising@freebsd.org) Received: from cid.daemonic.se (localhost [IPv6:::1]) by mail.daemonic.se (Postfix) with ESMTP id 478b084TFnz3lPc; Fri, 8 Nov 2019 09:42:16 +0000 (UTC) X-Virus-Scanned: amavisd-new at daemonic.se Received: from mail.daemonic.se ([IPv6:::1]) (using TLS with cipher ECDHE-RSA-AES128-GCM-SHA256) by cid.daemonic.se (mailscanner.daemonic.se [IPv6:::1]) (amavisd-new, port 10587) with ESMTPS id pLPOQFkrDimo; Fri, 8 Nov 2019 09:42:16 +0000 (UTC) Received: from garnet.daemonic.se (host-95-198-200-128.mobileonline.telia.com [95.198.200.128]) by mail.daemonic.se (Postfix) with ESMTPSA id 478b075lT1z3lPb; Fri, 8 Nov 2019 09:42:15 +0000 (UTC) Subject: Re: svn commit: r516921 - head/Mk/Uses To: Tobias Kortkamp Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org References: <201911061902.xA6J2hV6031987@repo.freebsd.org> <20191108045247.GA82122@urd.tobik.me> From: Niclas Zeising Message-ID: <3f3eac2c-d705-c7dd-ccfd-a0ab5fef9c23@freebsd.org> Date: Fri, 8 Nov 2019 10:42:15 +0100 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:68.0) Gecko/20100101 Thunderbird/68.2.0 MIME-Version: 1.0 In-Reply-To: <20191108045247.GA82122@urd.tobik.me> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 478b0B3xRTz47H6 X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-1.87 / 15.00]; local_wl_from(0.00)[freebsd.org]; NEURAL_HAM_MEDIUM(-0.88)[-0.875,0]; ASN(0.00)[asn:36236, ipnet:176.58.89.0/24, country:US]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Nov 2019 09:42:18 -0000 On 2019-11-08 05:52, Tobias Kortkamp wrote: > On Wed, Nov 06, 2019 at 07:02:43PM +0000, Niclas Zeising wrote: >> Author: zeising >> Date: Wed Nov 6 19:02:42 2019 >> New Revision: 516921 >> URL: https://svnweb.freebsd.org/changeset/ports/516921 >> >> Log: >> Mk/Uses: Add USES+=xorg when including xorg.mk >> >> Add USES+=xorg to the places where MK/Uses/xorg.mk is included from other >> files in the Uses infrastructure. This is done to silence an erroneous >> warning about USES=xorg not being set when using USES=gl, motif or xorg-cat, >> even when it's included from the framework. >> >> This is a different proposal than what was originally suggested in pr 241627 >> and https://reviews.freebsd.org/D22210 . >> >> PR: 238988, 241627 >> Discussed with: mat >> MFH: 2019Q4 >> Differential Revision: https://reviews.freebsd.org/D22210 > > Something is still wrong. A port with for example > > USES= gl > USE_GL= glut > > will still give the bogus warning. It goes away with: > > Index: Mk/Uses/gl.mk > =================================================================== > --- Mk/Uses/gl.mk (revision 517030) > +++ Mk/Uses/gl.mk (working copy) > @@ -40,7 +40,9 @@ > .if !defined(_GL_${_component}_LIB_DEPENDS) > IGNORE= uses unknown GL component > .else > +.if defined(_GL_${_component}_USE_XORG) > USE_XORG+= ${_GL_${_component}_USE_XORG} > +.endif > LIB_DEPENDS+= ${_GL_${_component}_LIB_DEPENDS} > .endif > .endfor > Ok, I have to look into this as well, but your patch is probably good. I wonder if this is still needed after the warnings in bsd.port.mk are removed (since I've tried to move everything to USES). Do you have an example of a port that's an issue? Regards -- Niclas Zeising